From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 408D341EB1; Thu, 16 Mar 2023 14:31:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF0C240DF6; Thu, 16 Mar 2023 14:31:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 55B1440A89 for ; Thu, 16 Mar 2023 14:31:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678973504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BmdugOIa/+hEN7gvtgv8dkHVHHZEnoyXR4tGQitU8us=; b=giDZU4Ympvm7hdDpD+sC23rPi05CMELElCtcG/LrpYsUEiqXACVQeXIypkefTVn7qRZS5D UjkBZrzWvs7xvQkRRBAUJYsvIUsFnhEQLBFUKkdnKbNBz1Y4zVI2sPpnyqUGi0cI5SUwdO ZBiYiK15/yFgSIDBm1D5cGY3y4aBj6c= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-8165erRQN2GjFz2YgX9UvQ-1; Thu, 16 Mar 2023 09:31:43 -0400 X-MC-Unique: 8165erRQN2GjFz2YgX9UvQ-1 Received: by mail-wr1-f72.google.com with SMTP id y11-20020a056000168b00b002ce179d1b90so282794wrd.23 for ; Thu, 16 Mar 2023 06:31:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678973502; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BmdugOIa/+hEN7gvtgv8dkHVHHZEnoyXR4tGQitU8us=; b=ALUjjtFUE0ZH4Db7tw0M4kC3yT6cfPkSFVBUw44VY8GowjJalGRwnHsPJV0LV7bBi4 8RVtyI2SfqIZPx+EewyC1OWaz+wVDalfoZKUAj4hg0lkDEO3pnSnbnyDVAufMzEzPOa5 sCfNAzEhkwJ5YAG8oKuY+rq6tGtHaTMtSNRsGU16//6y1rTib993Jdg9mlXNb0krXZVc tkzgsJglQ1XfWP8AOIJKH97DDYxSgw0ZT0/Em3x1c8o5QcMzn15Sresmr897Okg+UNo+ rtc8vdNpSEQw1ei/Cxqpz5sfzM5lxln/Vv9Aljv8XXlofmt4DXrwktt9WeGlVMc93zZn Tahw== X-Gm-Message-State: AO0yUKV/mihoKFFVqfaivzYPlr+ThKX7No0FhKu3dshqhm0KuPiMoJHb fTIAyPix3HkZT+uAmhZoX/kCJgW/5c6bR8BJ4L2MFuQtZUfGIOTYMZfvC4G688nt9F3V79NOzoa oErU= X-Received: by 2002:a05:600c:a11:b0:3dc:433a:e952 with SMTP id z17-20020a05600c0a1100b003dc433ae952mr20221152wmp.33.1678973502396; Thu, 16 Mar 2023 06:31:42 -0700 (PDT) X-Google-Smtp-Source: AK7set9iMPp9H/wpn11Vc91RpV+B8lleqBVhj/LAqk4mFEUB1wpBcz3qb8ot4KbQhEOZ84fVNslnXQ== X-Received: by 2002:a05:600c:a11:b0:3dc:433a:e952 with SMTP id z17-20020a05600c0a1100b003dc433ae952mr20221118wmp.33.1678973502071; Thu, 16 Mar 2023 06:31:42 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id f2-20020a7bc8c2000000b003ed243222adsm4933284wml.42.2023.03.16.06.31.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 06:31:41 -0700 (PDT) Message-ID: <1f1c1d68-7fdf-5ce4-2ba5-4a5340dcbc2f@redhat.com> Date: Thu, 16 Mar 2023 13:31:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Kevin Traynor To: Andrew Rybchenko , Ciara Loftus , dev@dpdk.org, "Zhang, Qi Z" , shibin.koikkara.reeny@intel.com Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com, David Marchand References: <20220624102354.1516606-1-ciara.loftus@intel.com> <0fcfe78a-72c6-788d-867e-0ff554ba5004@oktetlabs.ru> <29f03d86-bc81-c39f-76b1-bb51b9999cfb@redhat.com> Subject: Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 15/03/2023 11:47, Kevin Traynor wrote: > On 21/12/2022 09:28, Kevin Traynor wrote: >> On 21/12/2022 06:09, Andrew Rybchenko wrote: >>> Hi Kevin, >>> >>> On 12/20/22 17:05, Kevin Traynor wrote: >>>> On 24/06/2022 11:23, Ciara Loftus wrote: >>>>> libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd >>>>> functions. Use meson to detect if libbpf >= v0.7.0 is linked and if >>>>> so, use >>>>> the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach >>>>> and bpf_xdp_detach which are available to use since libbpf v0.7.0. >>>>> >>>>> Also prevent linking with libbpf versions > v0.8.0. >>>>> >>>>> Signed-off-by: Ciara Loftus >>>> >>>> Hi Andrew/Qi (assuming Ciara is still out of office), >>>> >>>> I am seeing a similar issue [1] on 21.11 branch with Fedora 37 >>>> (libbpf-0.8.0-2.fc37.x86_64 and libxdp-1.2.6-1.fc37.x86_64). >>>> >>>> This patch alone won't apply as there are other dependencies. Looking at >>>> the commits in main branch, it seems like I could take all these [2] to >>>> resolve the issue. With these cherry-picked the build warnings on Fedora >>>> 37 are removed. >>>> >>>> It's a bit late to take these for DPDK 21.11.3 as I intend to release >>>> later today/tomorrow, so it can be resolved for DPDK 21.11.4. >>>> >>>> Do the commits below look ok for backport? Main branch might be able to >>>> demand user uses new libbpf/libxdp versions etc, but with stable we >>>> never want to break the users existing setup when they upgrade from >>>> 2X.11.n to 2X.11.n+1. > > N.B. ^^^^ > >>>> >>>> Let me know what you think? >>> >>> IMO these patches are to to be backported to stable branch. >> >> Thanks Andrew. >> >>> However, af_xdp maintainers opinion is more important here. >>> >> >> Qi, what do you think? >> > > Hi Qi/Ciara, this issue is still present approaching 21.11.4. > > What is your opinion on backporting these patches? Please especially > note the paragraph above wrt users not being required to upgrade libbpf. > +Shibin, following discussion in DPDK release meeting. > thanks, > Kevin. > >>>> >>>> thanks, >>>> Kevin. >>>> >>>> [1] https://paste.centos.org/view/e4eec764 >>>> [2] >>>> 1eb1846b1a net/af_xdp: make compatible with libbpf 0.8.0 >>>> 5ff3dbe6ce net/af_xdp: add log on XDP program removal failures >>>> 0ed0bc3834 net/af_xdp: avoid version-based check for program load >>>> e024c7e838 net/af_xdp: avoid version-based check for shared UMEM >>>> f76dc44ded net/af_xdp: make clear which libxdp version is required >>>> 50b855fc47 net/af_xdp: move XDP library presence flag setting >>>> >>> >> >