From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11E0B45ECB; Tue, 17 Dec 2024 18:48:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFECE406B6; Tue, 17 Dec 2024 18:48:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0539D402B1 for ; Tue, 17 Dec 2024 18:48:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734457694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gqsuR5rQUMVwAKEcezQ7ZGOUN00tKQr83pJ9jmb4lzE=; b=ABEZjNMVdwdOjKjF7ce3gxirXgO1CY4pjGcm0wv5DTheVdaelbTFu10fhm3/faTnu+La05 UCBC0gGiPj0PMTBSN+o0A95rJpjFbuPGLEDB7tRc2ndGyVRZfH5PIPlplwiDXwpqUE8TXJ eVpbwY+YgWCCjsNJJJfM5GAOdWpx+jM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-UY_ELXG_OhOvkuNZFE6Bsg-1; Tue, 17 Dec 2024 12:48:13 -0500 X-MC-Unique: UY_ELXG_OhOvkuNZFE6Bsg-1 X-Mimecast-MFC-AGG-ID: UY_ELXG_OhOvkuNZFE6Bsg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-385dcadffebso2638405f8f.0 for ; Tue, 17 Dec 2024 09:48:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734457692; x=1735062492; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gqsuR5rQUMVwAKEcezQ7ZGOUN00tKQr83pJ9jmb4lzE=; b=EadHyHEfSUR+6gTgQw1nqpBCbzBeJIN8Y6j60G0NFXqq61YpEEUZkEQmeuHNViKCVO TTACEbBxpQfIm7dqXBMCj23DcpWjxDUaaXtwUwReePldhJiCrt1jCP/rZlJB2fe8Y6DY Lr3swG4OGQDVoTUfNNVYLjJpAIrEziGmHl86rC3U/NVF/i3x76henI+WPwAoiD9CcSrv +mqgYrEeJIy6M+XViM6hoM/xZuQylsIWFJlvGMvqL6asjwgGuoQoZs9n1g0bU5Au1IgD jcmCI6OO/OlT5yLc9G+511DTYbKQrC4Ukfr56VyjRZSSZb2GujTbHcCjbFlacSCWMjpb 1DeQ== X-Gm-Message-State: AOJu0Yx0lzWhoqcfU6KnHFjrCRZapN1d3MzXT+obg0hfoC1DctNzTsxm c+8YaifOk+vqVWzupUq9mUDnbXUOqrBdYGZBMRZgb5DO1iGvlPOp/uarZc6Lz8juuL7GkyAd6ch Yue0WaxxeNqMwSiErxg9j79STSJk/8oo6Ml6217ri X-Gm-Gg: ASbGnct2CA7WWeIhDyQrHz7YhqVBwbQRVGfUtwpslOyPMj2/XYwUv5AmfKeiDqn1B6c ZI4KY6kvI4N4V+XG01FfEzS9+kgpbvxsiAqqMV6WrKRqpUDjSKeasoGLY8Rt1CPop3St6+GBIT2 vTMVGDruUOOWL1OPDDNfCicYHGH91ovNzyw8GHO0ZdV/DaiU1Gn8zYYEX9lHsvFrwwCMwKPPg2b /Fy/9pe/XHw/CG01ZbndYiobAQ5iY+SBAbf64XUU5xTwIIS37XqrnfczTE= X-Received: by 2002:a05:6000:4a0a:b0:382:4f9e:711f with SMTP id ffacd0b85a97d-388e45fa8a3mr171057f8f.6.1734457691910; Tue, 17 Dec 2024 09:48:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwd/7Bb+1opBiJF8ZKq4M53lZhR+JrY9BKyYNTfQPhSJh4Gaonsd0ptNHo+1gyhmXWNV0jZQ== X-Received: by 2002:a05:6000:4a0a:b0:382:4f9e:711f with SMTP id ffacd0b85a97d-388e45fa8a3mr171024f8f.6.1734457691425; Tue, 17 Dec 2024 09:48:11 -0800 (PST) Received: from [192.168.0.36] ([78.16.250.229]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c801acaesm11732458f8f.54.2024.12.17.09.48.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2024 09:48:10 -0800 (PST) Message-ID: <1f24ff14-7fe8-413d-b516-8534ad639c54@redhat.com> Date: Tue, 17 Dec 2024 17:48:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: 21.11.9 patches review and test From: Kevin Traynor To: "Xu, HailinX" , "stable@dpdk.org" Cc: "dev@dpdk.org" , Abhishek Marathe , Ali Alnubani , David Christensen , Hemant Agrawal , "Stokes, Ian" , Jerin Jacob , "Mcnamara, John" , Ju-Hyoung Lee , Luca Boccassi , Pei Zhang , Raslan Darawsheh , Thomas Monjalon , "yanghliu@redhat.com" , "Richardson, Bruce" , Maxime Coquelin References: <20241204155837.1730849-1-ktraynor@redhat.com> <914d8848-1339-483f-8707-05276cee856a@redhat.com> Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <914d8848-1339-483f-8707-05276cee856a@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: w7hurrXgaulnji1HDpa_3MhiAX2z4-WfN3LfWboqlpA_1734457692 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 17/12/2024 11:30, Kevin Traynor wrote: > On 17/12/2024 10:01, Xu, HailinX wrote: >>> -----Original Message----- >>> From: Kevin Traynor >>> Sent: Wednesday, December 4, 2024 11:59 PM >>> To: stable@dpdk.org >>> Cc: dev@dpdk.org; Abhishek Marathe ; >>> Ali Alnubani ; David Christensen >>> ; Hemant Agrawal ; >>> Stokes, Ian ; Jerin Jacob ; >>> Mcnamara, John ; Ju-Hyoung Lee >>> ; Kevin Traynor ; Luca >>> Boccassi ; Pei Zhang ; Raslan >>> Darawsheh ; Thomas Monjalon >>> ; yanghliu@redhat.com >>> Subject: 21.11.9 patches review and test >>> >>> Hi all, >>> >>> Here is a list of patches targeted for stable release 21.11.9. >>> >>> The planned date for the final release is 17th December 2024. >>> >>> Please help with testing and validation of your use cases and report any >>> issues/results with reply-all to this mail. For the final release the fixes and >>> reported validations will be added to the release notes. >>> >>> A release candidate tarball can be found at: >>> >>> https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1 >>> >>> These patches are located at branch 21.11 of dpdk-stable repo: >>> https://dpdk.org/browse/dpdk-stable/ >>> >>> Thanks. >>> >>> Kevin >>> >>> --- >> Update the test status for Intel part. Vhost part is done, the other part is in progress and Found one build issue. >> >> issue: >> DPDK meson build failed with EXTRA_CFLAGS='-O1' on Ubuntu 24.04.1 -> fix patch from Kaiwen Deng >> > > Thanks Hailin. What is the issue reported ? Are you saying the patch > below [1] is cause ? The patch seems fine to me, it is just adding a > NULL check before dereference: > > - if (vf->vf_res->vf_cap_flags & > - VIRTCHNL_VF_CAP_ADV_LINK_SPEED) { > + if (vf->vf_res != NULL && > + vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED) { > > [1] > commit c78d01172de035fa7e997841d44b01f58ed7cf83 > Author: Kaiwen Deng > Date: Tue Aug 6 08:35:27 2024 +0800 > > net/iavf: fix crash when link is unstable > > [ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ] > > Physical link instability may cause a core dump because unstable > physical links can result in a large number of link change events. Some > of these events may be captured by vf before vf resources are allocated, > and that will result in a core dump. > > This commit will check if vf_res is invalid before dereferencing it. > > Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message > without interrupt") > > Signed-off-by: Kaiwen Deng > Acked-by: Bruce Richardson > Hi Hailin/All, I have an update on 21.11. I had to make the release due to a CVE embargo lifting, so I wrote up the validation status at the time of release. There is a link to this thread in the release notes, so any further testing reported here can be found. Thanks for your testing. On the compiler issue reported above. I tested on Ubuntu 24.04 with -O1 and there is a maybe-uninitialized warning on the iavf code. For ref [1]. However, it is not new in 21.11.9 and is not caused by the patch above. I can reproduce it as far back as 21.11.3, and probably earlier (can't confirm as earlier version have other build issue with new the latest gcc). It was too late for a fix so I listed it as a known issue in the release notes. thanks, Kevin. [1] In file included from /usr/lib/gcc/x86_64-linux-gnu/13/include/xmmintrin.h:1322, from /usr/lib/gcc/x86_64-linux-gnu/13/include/immintrin.h:31, from /usr/lib/gcc/x86_64-linux-gnu/13/include/x86intrin.h:32, from ../lib/eal/x86/include/rte_vect.h:31, from ../lib/eal/x86/include/rte_memcpy.h:17, from ../lib/net/rte_ether.h:21, from ../lib/ethdev/rte_ethdev.h:172, from ../lib/ethdev/ethdev_driver.h:22, from ../drivers/net/iavf/iavf_rxtx_vec_sse.c:6: In function \u2018_mm_unpacklo_epi32\u2019, inlined from \u2018flex_desc_to_olflags_v\u2019 at ../drivers/net/iavf/iavf_rxtx_vec_sse.c:338:4, inlined from \u2018_recv_raw_pkts_vec_flex_rxd\u2019 at ../drivers/net/iavf/iavf_rxtx_vec_sse.c:969:3: /usr/lib/gcc/x86_64-linux-gnu/13/include/emmintrin.h:1048:19: error: \u2018descs_bh[0]\u2019 may be used uninitialized [-Werror=maybe-uninitialized] 1048 | return (__m128i)__builtin_ia32_punpckldq128 ((__v4si)__A, (__v4si)__B); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/iavf/iavf_rxtx_vec_sse.c: In function \u2018_recv_raw_pkts_vec_flex_rxd\u2019: ../drivers/net/iavf/iavf_rxtx_vec_sse.c:828:25: note: \u2018descs_bh[0]\u2019 was declared here 828 | __m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP]; | ^~~~~~~~ >> # Basic Intel(R) NIC testing >> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as >> Ubuntu24.10, Ubuntu24.04, Fedora40, RHEL8.10, RHEL9.4, FreeBSD14.1, SUSE15, AzureLinux3.0, OpenAnolis8.9 etc. -> one new issue is found >> - All test done. No new dpdk issue is found. >> * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. >> - All test done. No new dpdk issue is found. >> * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. >> - All test done. No new dpdk issue is found. >> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc. >> - on going. No new dpdk issue is found. >> * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc. >> - on going. No new dpdk issue is found. >> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc. >> - on going. No new dpdk issue is found. >> >> # Basic cryptodev and virtio testing >> * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc. >> - All test done. No new dpdk issue is found. >> * Cryptodev: >> *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc. >> - on going. No new dpdk issue is found. >> *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc. >> - on going. No new dpdk issue is found. >> >> >> Regards, >> Xu, Hailin >> >