From: fengchengwen <fengchengwen@huawei.com>
To: Kevin Laatz <kevin.laatz@intel.com>, <dev@dpdk.org>
Cc: <bruce.richardson@intel.com>, <gmuthukrishn@marvell.com>
Subject: Re: [PATCH] test/dma: fix api testuite teardown
Date: Tue, 12 Mar 2024 09:29:06 +0800 [thread overview]
Message-ID: <1f3988ea-8e74-ce66-f749-4d0003f9eced@huawei.com> (raw)
In-Reply-To: <20240311152550.1406686-1-kevin.laatz@intel.com>
It's not a bugfix, but a best practice for test (clean state before continuing).
The other is LGTM,
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/3/11 23:25, Kevin Laatz wrote:
> The API testsuite previously only used the dmadev skeleton. Now that real
> devices are being used for the API tests, the DMA stats need to be reset
> during testsuite teardown to ensure a known, clean state before continuing.
>
> Fixes: 14b477ed1740 ("test/dma: use unit test framework")
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> app/test/test_dmadev_api.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_api.c
> index a130e74b51..d40c05cfbf 100644
> --- a/app/test/test_dmadev_api.c
> +++ b/app/test/test_dmadev_api.c
> @@ -82,6 +82,7 @@ testsuite_teardown(void)
> dst = NULL;
> /* Ensure the dmadev is stopped. */
> rte_dma_stop(test_dev_id);
> + rte_dma_stats_reset(test_dev_id, RTE_DMA_ALL_VCHAN);
>
> rte_log_set_level_pattern("lib.dmadev", RTE_LOG_INFO);
> }
>
next prev parent reply other threads:[~2024-03-12 1:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 15:25 Kevin Laatz
2024-03-12 1:29 ` fengchengwen [this message]
2024-03-15 12:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f3988ea-8e74-ce66-f749-4d0003f9eced@huawei.com \
--to=fengchengwen@huawei.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gmuthukrishn@marvell.com \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).