From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 234E2A04B1; Wed, 23 Sep 2020 10:48:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 057181C1D3; Wed, 23 Sep 2020 10:48:00 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CC7D71C198 for ; Wed, 23 Sep 2020 10:47:58 +0200 (CEST) IronPort-SDR: DP6OrnEwqgxNRmHPi43hNzFOpXKBfdNyhK2+K9HY9v30NmU1Dw5QOmmo0i6jL5Ru5MMJQ9R5yt QjnUVBetViFQ== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="245669643" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="245669643" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 01:47:57 -0700 IronPort-SDR: lzL60Xcnl8aAaIsxR5+hIo0OcfhMxaQBAsLH1Z/6U99NUrN2gpatYioCwwn7mXD18SDTjBKeJR xbMlyszThaow== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="454819961" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.251.15]) ([10.213.251.15]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 01:47:57 -0700 To: Lukasz Wojciechowski Cc: dev@dpdk.org References: <20200915193449.13310-1-l.wojciechow@partner.samsung.com> <20200923014713.16932-1-l.wojciechow@partner.samsung.com> From: David Hunt Message-ID: <1f47b06e-58b6-d1c9-defd-955063858e23@intel.com> Date: Wed, 23 Sep 2020 09:47:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200923014713.16932-1-l.wojciechow@partner.samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v2 0/8] fix distributor synchronization issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Lukasz, On 23/9/2020 2:47 AM, Lukasz Wojciechowski wrote: > During review and verification of the patch created by Sarosh Arif: > "test_distributor: prevent memory leakages from the pool" I found out > that running distributor unit tests multiple times in a row causes fails. > So I investigated all the issues I found. > > There are few synchronization issues that might cause deadlocks > or corrupted data. They are fixed with this set of patches for both tests > and librte_distributor library. > > --- > v2: > * assign NULL to freed mbufs in distributor test > * fix handshake check on legacy single distributor > rte_distributor_return_pkt_single() > * add patch 7 passing NULL to legacy API calls if no bufs are returned > * add patch 8 fixing API documentation > Please include any Acked-by or Tested-by tags from previous versions. Rgds, Dave.