Re: [dpdk-dev] [PATCH v1 1/1] vfio: add page-by-page mapping API

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 28-Oct-21 9:18 AM, David Marchand wrote:
> On Wed, Sep 29, 2021 at 12:19 PM Burakov, Anatoly
> <anatoly.burakov@intel.com> wrote:
>>> @@ -2179,7 +2208,29 @@ rte_vfio_container_dma_map(int container_fd, uint64_t vaddr, uint64_t iova,
>>>                return -1;
>>>        }
>>>
>>> -     return container_dma_map(vfio_cfg, vaddr, iova, len);
>>> +     /* not having page size means we map entire segment */
>>> +     return container_dma_map(vfio_cfg, vaddr, iova, len, 0);
>>> +}
>>> +
>>> +int
>>> +rte_vfio_container_dma_map_paged(int container_fd, uint64_t vaddr,
>>> +             uint64_t iova, uint64_t len, uint64_t pagesz)
>>> +{
>>> +     struct vfio_config *vfio_cfg;
>>> +
>>> +     if (len == 0 || pagesz == 0 || !rte_is_power_of_2(pagesz) ||
>>> +                     (len % pagesz) != 0) {
>>
>> This should also check if VA/IOVA is page-aligned. Will fix in v2.
> 
> Can you send v2?
> Thanks.
> 

Yes, working on it :)

-- 
Thanks,
Anatoly