From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E214A0528; Thu, 9 Jul 2020 15:51:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63A961E934; Thu, 9 Jul 2020 15:51:28 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 5548E1E919 for ; Thu, 9 Jul 2020 15:51:27 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200709135127euoutp027a8bfa17a7d50cd8f1c0600e6c230f96~gGdjTozFR0905509055euoutp02O for ; Thu, 9 Jul 2020 13:51:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200709135127euoutp027a8bfa17a7d50cd8f1c0600e6c230f96~gGdjTozFR0905509055euoutp02O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594302687; bh=BXHKmMMNlWWswZC/eJp75Nq1rWKXizNU5c2sFhYEWf8=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=P1Gdej2Ejy4qoPcBMN7xn9H3u0AHGWOLb9zDLICREWS6WA7bb6xux65aLErVQOk1T F/2Scnn4LnqedvBq5AiK8aDqoPAGaUYI8ZYxMk3MH8N7luF8impJNxOb10ln1Yhh4p uFx7GsRxr2zJHxsKoVixdP5zGoObVvLC/oOKCNKs= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200709135126eucas1p1b47a99164fcdd67c1963cc651f4e3a99~gGdi935LR2496924969eucas1p1L; Thu, 9 Jul 2020 13:51:26 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 95.1E.05997.ED0270F5; Thu, 9 Jul 2020 14:51:26 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200709135126eucas1p1817b97f0f6c67b78ee3f690a946a9ca9~gGdijM7d62488924889eucas1p1Q; Thu, 9 Jul 2020 13:51:26 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200709135126eusmtrp131ca20a6e2408e9a7db2d7c3726a3a09~gGdiimg_R1498114981eusmtrp1u; Thu, 9 Jul 2020 13:51:26 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-5f-5f0720de56f1 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id D3.3F.06314.ED0270F5; Thu, 9 Jul 2020 14:51:26 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200709135125eusmtip137682a3a58ff79c67f6d70c59f116756~gGdiExyB-1495714957eusmtip1N; Thu, 9 Jul 2020 13:51:25 +0000 (GMT) To: Bruce Richardson Cc: Thomas Monjalon , dev@dpdk.org, "\"'Lukasz Wojciechowski'\"," From: Lukasz Wojciechowski Message-ID: <1f900349-6701-d355-9084-c97cf5dccb75@partner.samsung.com> Date: Thu, 9 Jul 2020 15:51:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200626165630.GA564@bricha3-MOBL.ger.corp.intel.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsWy7djPc7r3FNjjDQ4c1LW4scre4t2n7UwW z3rWMVp8enCCxYHF49eCpawei/e8ZPI4dnMau8fBd3uYAliiuGxSUnMyy1KL9O0SuDL+vT7N XtAiWPF6/nLGBsaJfF2MnBwSAiYSB66+Y+1i5OIQEljBKHFh5yMmCOcLo8Sdv+tZIJzPjBKz fuxmhmlpmdHACJFYzijRtH4mlPOWUWJe+0p2kCphAWeJ+3+fMYHYIgKGElsXbgXq5uBgFqiW uN6uBxJmE7CVODLzKyuIzSvgJrHs3A6wVhYBFYkvD6+A2aICcRLrX25ngqgRlDg58wkLiM0J NH7T5qVgNcwC8hLNW2czQ9jiEreezGeCOHQyu0RjSzaE7SLx99svRghbWOLV8S3sELaMxOnJ PWBfSghsY5S4+vsnI4Szn1Hieu8KqCpricP/frNBPKApsX6XPkTYUeLatjusIGEJAT6JG28F IW7gk5i0bTozRJhXoqNNCKJaT+Jpz1RGmLV/1j5hmcCoNAvJZ7OQfDMLyTezEPYuYGRZxSie Wlqcm55abJSXWq5XnJhbXJqXrpecn7uJEZhaTv87/mUH464/SYcYBTgYlXh4E/6yxQuxJpYV V+YeYpTgYFYS4XU6ezpOiDclsbIqtSg/vqg0J7X4EKM0B4uSOK/xopexQgLpiSWp2ampBalF MFkmDk6pBkaB64HqyRzO7VsWT1Y9H+PgkVj5nDuY/Z+jymX+x/pNreYfuPc9bhLKfXr6PNtC k5mFHlEzZm5ZdcmdIbfp4NOWGaYPXUxtD8eyfLS7K2Z+U5iZb1Vp+i+Tvcs+B2wpmn7NWzhn 4a1Y5t+TIqbN1eC3STdV3Nz3bYG2fIGjaCrzmQfeP5XrXimxFGckGmoxFxUnAgCoFjOBKQMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsVy+t/xu7r3FNjjDSZ28FvcWGVv8e7TdiaL Zz3rGC0+PTjB4sDi8WvBUlaPxXteMnkcuzmN3ePguz1MASxRejZF+aUlqQoZ+cUltkrRhhZG eoaWFnpGJpZ6hsbmsVZGpkr6djYpqTmZZalF+nYJehn/Xp9mL2gRrHg9fzljA+NEvi5GTg4J AROJlhkNjF2MXBxCAksZJebP/8jUxcgBlJCR+HBJAKJGWOLPtS42iJrXjBJvlv9iBUkICzhL 3P/7jAnEFhEwlNi6cCsziM0sUC1xYNtpZoiGU0wSja8ngRWxCdhKHJn5FayZV8BNYtm5Hewg NouAisSXh1fAbFGBOInlW+azQ9QISpyc+YQFxOYEWrZp81J2iAVmEvM2P4RaJi/RvHU2lC0u cevJfKYJjEKzkLTPQtIyC0nLLCQtCxhZVjGKpJYW56bnFhvqFSfmFpfmpesl5+duYgRG07Zj PzfvYLy0MfgQowAHoxIP747/bPFCrIllxZW5hxglOJiVRHidzp6OE+JNSaysSi3Kjy8qzUkt PsRoCvTcRGYp0eR8YKTnlcQbmhqaW1gamhubG5tZKInzdggcjBESSE8sSc1OTS1ILYLpY+Lg lGpgDF1RsvqY9kee2oaS+Xt73i2OdeqdV3f1/eFQqalb3hlK8LAKMsTI2N/q3PRnRskJm73l Nxlm23f0sanOL/OaExV3/uZ+9h6eIDtPBrEXS6Z7GV6dF2zKrbdpSq7h2hVnHMS5eJl7N2or R/88Kp17XOLmHHsD3wjWY/63L3Z63f+2zUl4ppyaEktxRqKhFnNRcSIA6Y3DobwCAAA= X-CMS-MailID: 20200709135126eucas1p1817b97f0f6c67b78ee3f690a946a9ca9 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200422214614eucas1p1044184e60bcb04469783ef0dd95091c1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200422214614eucas1p1044184e60bcb04469783ef0dd95091c1 References: <20200417215739.23180-1-l.wojciechow@partner.samsung.com> <20200422214555.11837-1-l.wojciechow@partner.samsung.com> <20200422214555.11837-2-l.wojciechow@partner.samsung.com> <20200626165630.GA564@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH v2 1/3] config: introduce global rte debug flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 26.06.2020 o 18:56, Bruce Richardson pisze: > On Wed, Apr 22, 2020 at 11:45:53PM +0200, Lukasz Wojciechowski wrote: >> A new boolean meson build flag is introduced with this patch: rte_debug. >> To enable this option add -Drte_debug=true to the meson configure command. >> >> By enabling this flag the globaly defined macro RTE_DEBUG becomes >> defined. It should be used for enabling debug code in all dpdk project >> components. Using this flag allows to make additional checks or tests >> and provide additional logs even in performance sensitive parts of code. >> >> The flag is disabled by default. >> >> Additionally for all enabled to be built libraries >> a RTE_DEBUG_{library name} is defined and assigned a value 1. >> This standardize names of library specific debug macros. Those can >> be used also without rte_debug option by using CFLAGS="-D..." build >> parameter. >> >> Code put inside RTE_DEBUG* #ifdef sections should be also put inside >> if (rte_log_can_log(...)) condition to allow run-time filtering of >> sanity checks, validations, logs and dumps when using rte_debug option. >> >> Libraries will be adjusted to the change in separate patches. >> >> Suggested-by: Bruce Richardson >> Signed-off-by: Lukasz Wojciechowski > The drivers are missing debug flag options, which probably need to be > defined as _ e.g. RTE_DEBUG_NET_I40E, > RTE_DEBUG_EVENT_SW, etc. I added also flags for drivers constructed as you suggested (see v3). It might however be a bit tricky to differentiate library debug flags form drivers, e.g. RTE_DEBUG_MEMPOOL (library) vs RTE_DEBUG_MEMPOOL_DPAA (driver). If there is a need the macro names can be changed by adding _LIB_ or _DRV_. What do you think? > However, this is definitely a good start. > > Reviewed-by: Bruce Richardson > Acked-by: Bruce Richardson > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com