From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB153A0C52; Tue, 2 Nov 2021 11:04:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 623054068F; Tue, 2 Nov 2021 11:04:26 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id B256D40689 for ; Tue, 2 Nov 2021 11:04:24 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="294679641" X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="294679641" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 03:04:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="583332294" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 02 Nov 2021 03:04:22 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 03:04:22 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 03:04:22 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 03:04:20 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 03:04:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdQ7RgQle8uceFpsIZtITjr4yYLh+K/V8BTJMp5oMTAdcoZd9mcK1KrHAk/hFgZGVXqaiZPESc5vzSEdlpuHjKYaYgTDTE91NNMrpr3Ewc6Cg6/WtCS+UmIrbk+RN5BWfZPonTuE3mx0gkz98jIdkhvVKgJJxleR6oGGbFV+AVSsEFY2S+tU35nPHg2W8XxKTvzQRbRDP6CLDJZd1AU4Obk+02WqKHjfTRXiqWz32t3WItGqr9+IfjE6xrPwUoKMXdrib0vHgY7+oqJyLzNqnM1OuvVnuq+byG9WR18KoZGWP8ZfVHmYVC9VoYMbHMFGuPgKGnAcucaATgALXDBlVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eD5zwxKugm7yB+RTifY8KksLRMLj5tQDBVx1DE384aE=; b=TXMzrjiFUSYXYt9d9iRRS+MfQZWnwgJkOMLMR42qmk3ylboKZxQzSW2Qt7Dez2dO6ztGshGYNSYzIcB+/TRVDRSPOtizie/AMNar9xvhP8BcIhPkocf4q01PUAtJ+TSgDQLuKs7iU0JPb18H8rziYzdfqvgoE1GgkpkKKbPFpG8yat/bO1zHgq/BWcrbAEBYlAMeFhmXZ9fdp3r5y80Dp4Mj/nT0Xgxz7OmHQhnM9jchpD28UIEvvjFbJDqinbWyuW8oTMd233vgRpfXp6vGR9UXLyJXKWaA56zEPUgGkQdllvYQ32dm/BZ2IF9Y9eNEr4dAW/a7MvkniwCWHcU6EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eD5zwxKugm7yB+RTifY8KksLRMLj5tQDBVx1DE384aE=; b=l9RCJnINTMgwczDWPNpMmY+/CeeR6kDAzK5mGOs4hEaOeelyKTHOjdr56WjAKdavJW2HR+AnMQXZ3Tt7N4b2D8qFW5AoncX9PdkYdJX/fydcjn3luuEhFzx3SrXIbmEESqXLAR5DWcf3MqnalxFP5OA+tTo5uZuWLQ/7WtSktys= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4901.namprd11.prod.outlook.com (2603:10b6:510:3a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 10:04:18 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 10:04:18 +0000 Message-ID: <1f940709-5b29-3a80-6966-8938d5034f3d@intel.com> Date: Tue, 2 Nov 2021 10:04:12 +0000 Content-Language: en-US To: Thomas Monjalon CC: , Joe Perches References: <20211101133533.3402007-1-ferruh.yigit@intel.com> <20211101133533.3402007-2-ferruh.yigit@intel.com> <5473001.4jAN4JvoLB@thomas> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <5473001.4jAN4JvoLB@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:10:1db::7) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:10:1db::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Tue, 2 Nov 2021 10:04:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f87a549-b9ec-4156-91cb-08d99de82269 X-MS-TrafficTypeDiagnostic: PH0PR11MB4901: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1060; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gjv4+HEUzYzTlpEMv6QvIRuKOmYCfoX2sk8GANTfRIr43Eqff63bfvGwOmwjFopD2l4TQmOke3ichQ7j3yok3+oKHS3KS69HPj8PTuy1L2AUiQ8zqQ+vUUTIer4EpRzSiFZ6vDGisSs2P7wjZ6+VOHrv2l0TYyctE3jIdBT8dQGLwoSSeTEJyVTU4UW9PDIPhwYHKfadPLwbYCRHwGUeWlMOSeBV4j2faAzlyB6vsoo1mYU0e5BaJVI73wUgW/wJ8/KXgr6F+bHsFLV59BdjQ0ucPHJ5+G8o4JzjaW6AZPLW9EsmFtZmeV2kjfx3Mb/HaqwJ24/t9RmgZnsceidb67cMUMxFDE9lIOotQyvjScPiUrozJ+GOsT4LNvBvOEAGC3rr+SIOO03j4kiTrY+PGyXrStLUHnehr5/jlcJKYHtCZ80gLmgLyGh3oh0v8abNgVILJIisYV2u47AHfX9j4GXYU31PnFExefUM8LC0khfmFO0RpeV9sEZ/E+5wTvvvajX1mNuMqBQSEYf1ZhOXnI6ja5/rZzR6vXT8s79Lb0g2+dmjuR2ntfbuKGdEhedtmExtMySrK1Ye5lnlcgp+oVFGvJb5dfb+1gPKlS0bU6W5HIzVT7noc8WWRdvFs/TP6RAijgkxF7iEX7yZzUkparxeIgeY0EeubBY8vN6scJTGbJhTZ1Z0+b5L+0jxStJPIgYV8k7lPRfJfkOJszRVhrJqRn6uNQ10FaBIt/dQ8ac= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(53546011)(956004)(26005)(38100700002)(2616005)(16576012)(6666004)(5660300002)(36756003)(31686004)(8676002)(6486002)(31696002)(2906002)(86362001)(316002)(66556008)(66476007)(4326008)(8936002)(44832011)(66946007)(508600001)(82960400001)(186003)(6916009)(21314003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzF5SE5kMFpScXRzcTBXMlNQOEorcWMwWSs3eXE5WVdUSHM3RzVQVVhaYzZn?= =?utf-8?B?OC8vaWdLNkRGTldrbkMrVldrY1hzaWZnT0JUcktzdmFMcVJQMkZKZXkyS0FV?= =?utf-8?B?Q2tzOVVyamhlejVpR2U0aUQ0ZEJkRzVkTWpuWk96cS9XTW15WW5rbEpMSi9t?= =?utf-8?B?R2RwTXVBNXhJdzhVa1dJQVZVSy8xbldTeEpXZ0MzTWJyb2htMXhKQkdYTkk5?= =?utf-8?B?QXF2UmFxM3hSdStNNDUwZG4yeVgzbDRFNFdrcThiRE5WMWQrMVZ1RnB4Ynky?= =?utf-8?B?RlV3ZlVTV2g5MmozRktJU25wNFFxVVd5L3FyWlp3TWtwMmQ3eS9ycWZ4c1o2?= =?utf-8?B?YmRyY09HbXZXRVJvMnRKeTI2eVBwY2NNYlpQY1E0aFV1NzVvdTErM2htUkkw?= =?utf-8?B?WHpaZmVMM0YzUk5HUzYvZTNWWXVHZE8xZXNiV3kzaEx1b3JncGZuUnFWeXNz?= =?utf-8?B?UHBobzBMZlc3R1kyak5QOGgyV3htM25IYmtib1oxcnhPZWxjL2xYZFdZcU5z?= =?utf-8?B?bFdWZ1F3anFCbjFsUjNoWTRJTEJxL0cxajJsVVY0K21FdFFESndVQ1pWeWJl?= =?utf-8?B?Rmtodzc3Ym1hMjZZdzZtRWNGeUd1bmhnVmZ4VmdPbzhhdDRzNGxiMVZDa3VT?= =?utf-8?B?bFVKWmFacUVQL1c3Y2JEUlB1MDhMV1h4VTljTmxESWNqK0JVZzVJSG43K3Ax?= =?utf-8?B?M3prZ2FoMzBPR3p1cW13bEkwdjROejNPTFI3NGZUTnZHVUxwS3ZJNkNNNU5C?= =?utf-8?B?RkNVYVFocG1PSU1CdFlqcFZKQVRmMURyc1M3b1crZVlnVGNNRWdDenp5N09S?= =?utf-8?B?a1ZLSHAxcHIvRnRHUGgzTCtUZnVrSmN4MXpqZkdib2EvYTcwTUtIRzRPblQ2?= =?utf-8?B?M3JhZmdRTjRFanpCRUdxZHQvNGxadTJybE1Fc0Vjd05jMnRDWjdvZkJhb01O?= =?utf-8?B?MnRISGh2T2xRVWt4WjRsM0l6WFhTQmxSR0hubmR5cDBVNDQyYi90eVA4b2ha?= =?utf-8?B?UkNiRzNsbnZWVFg5WmZrYVk3N2RpdnJwcjZkVE1XVG44ZGJ3dTVpUS9ib29R?= =?utf-8?B?NW91VG5YRVlzQW5mR25vTk5PcTdYczdxamYzbnRjTWlQdU90MGg2UUdGQndS?= =?utf-8?B?T3F1MktJYmt2SGYwN3g2ZkdPeTZVSjNBSnRISlllRjcyUjhVNERlb1hqNEJI?= =?utf-8?B?YUtvU0pXVUVjUFkxdEZvaDRpUnZPUU4vMmF0OU1pUW5KRlhIckdUQUdNVHlP?= =?utf-8?B?SzdnUXBPQmV2OTNkTWM0Q1d3OTRab0NEU3hTR2hDdHJLQVZ4TUZ0MkVlR1pj?= =?utf-8?B?M2llekVTMjhpRVVJMkZPRm04QTJCdFlNOU9FOWtXcWhkd3pzZGxvTVgrMUV0?= =?utf-8?B?eXdnU1JZRW1nZ1lRRlo1TTRmUjI1NFhna0hoQTFqZ0NpTzZPRW9LRW1ERkRH?= =?utf-8?B?bkpwYnpUVkcyN1NoTXQ1ZEhjaHhBRjFkUUhldGY5c1Fxbyt5dTBOcnNVL01S?= =?utf-8?B?WkZLTVlnTzRhZzl1NW9Ga0wwMXpqRUJrTlREdkNYc2MvemNoTmFxT0M0ZTZm?= =?utf-8?B?Sk0vT2FVV3AxZXRVaUl4Qm9FTkw5RzluL1dTRlhmWUdaR25oUWZ1QVV3RHR4?= =?utf-8?B?ZGJsTGZWUzZCUFg4Ui9EOW1seXdZMDlIbW1TbTkvUGd6NXR5TlRmbUU0RS8y?= =?utf-8?B?d20zZUFwbVI5d1d1MVViQy83NXpTcXZJRDY4MG8vSFRnQzZ4bVRYaS9sdUtM?= =?utf-8?B?YWM1c2pQTGx0cC83bEQrYU1qRDdUK2tYdDNRdjBTQjEyUDBCQStWSGQvZENp?= =?utf-8?B?OU81VzlvMDZzYzVIZnJ0MlFBQXl4eittRCtiKzJXK24rZzUzNXBpeklXUFJv?= =?utf-8?B?eDQzMUhSVnhFbmdjZlhmaWdNalZZN3drQkxTaERNT1B4eFpHTTNGdjMvb0pB?= =?utf-8?B?SlNHV3BIdDROaWk1bVc4dk5ybE1GaThnRzMvVThxRWFBdUpvOEJZdDVFazMx?= =?utf-8?B?cGFvWXg5SWpNK3JXZ2lrdHFtbjk1VmxhSjhFMWxVRU1rWDJ5UmVnRzRuZURV?= =?utf-8?B?UTRORE9VMWpJWTB2bFRXb3pySE5SMVppNTdKY2pEV1F5M2ZkQ0FoQkNxZWdC?= =?utf-8?B?WHVENU9KOW1ucjZLeWJWRjJKTDBuTlhlVDBwZ2trU2UwVno4bXBjamxoblBQ?= =?utf-8?Q?TTm5Ecbm8IDm5fKlSAvn6RU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2f87a549-b9ec-4156-91cb-08d99de82269 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 10:04:18.7651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rRwOcFf0zlJ7sRJ5OhdOceXufq4JUu/PfTgRVsp07IhHlDqU74q+dWq/RuoR7fEXeJQgc1MvQtikeCwi7aMwPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4901 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/1/2021 10:20 PM, Thomas Monjalon wrote: > 01/11/2021 14:35, Ferruh Yigit: >> 'get_maintainer.pl' by default returns authors that has fixes in >> relevant code, to reduce the output only maintainers from MAINTAINERS >> file, disabling fixes authors, by making '--no-fixes' default. > > Do you mean it is not Cc'ing people who have contributed to the file? > Is it keeping Cc of people having contributed to the commit being fixed? > It is adding both, people contributed to the file and contributed to the commit it is fixing. More details from tool is below [1]. Intention to cc'ing the people who introduced the commit you are fixing makes sense. But as far as I can see it adds all xxx-by names from the fix commit, not just author, that may add some unrelated people. Let me give a sample: Commit A: ("ethdev: add namespace") It updates bunch of drivers and it has acks from various driver maintainers. Commit B: ("net/txgbe: fix link macro") Fixing Commit A for one driver (txgbe) If --fixes is used on 'Commit B', the author of 'Commit A' and all people acked 'Commit A' is added. But none of the acks were related to 'Commit B'. So as a result unrelated people cc'ed for 'Commit B'. If the commit and fix commit are more narrow scope, this make sense. So we may prefer to keep '--fixes' if we are OK to some noises in some cases. [1] From 'get_maintainer.pl': --fixes => for patches, add signatures of commits with 'Fixes: ' (default: 1 (on)) And form commit log that adding the feature: 2f5bd343694e ("scripts/get_maintainer.pl: add signatures from Fixes: lines in commit message") A Fixes: lines in a commit message generally indicate that a previous commit was inadequate for whatever reason. The signers of the previous inadequate commit should also be cc'd on this new commit so update get_maintainer to find the old commit and add the original signers.