From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A886A0613 for ; Sat, 31 Aug 2019 04:10:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CBC61BE8F; Sat, 31 Aug 2019 04:10:51 +0200 (CEST) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id A001B1E20 for ; Sat, 31 Aug 2019 04:10:48 +0200 (CEST) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 878B9A76F1F587803F15; Sat, 31 Aug 2019 10:10:46 +0800 (CST) Received: from [127.0.0.1] (10.57.115.182) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Sat, 31 Aug 2019 10:10:37 +0800 To: Jerin Jacob Kollanukkaran , "dev@dpdk.org" References: <1566568031-45991-1-git-send-email-xavier.huwei@huawei.com> <1566568031-45991-23-git-send-email-xavier.huwei@huawei.com> CC: "xavier_huwei@163.com" , "linuxarm@huawei.com" , "forest.zhouchang@huawei.com" From: "Wei Hu (Xavier)" Message-ID: <1faf6ee1-7dbf-4c58-994f-86a5ee09868f@huawei.com> Date: Sat, 31 Aug 2019 10:10:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2019/8/30 11:22, Wei Hu (Xavier) wrote: > Hi, Jerin > > > On 2019/8/23 22:08, Jerin Jacob Kollanukkaran wrote: >>> -----Original Message----- >>> From: dev On Behalf Of Wei Hu (Xavier) >>> Sent: Friday, August 23, 2019 7:17 PM >>> To: dev@dpdk.org >>> Cc: linuxarm@huawei.com; xavier_huwei@163.com; >>> liudongdong3@huawei.com; forest.zhouchang@huawei.com >>> Subject: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files >>> >>> This patch add build related files for hns3 PMD driver. >>> >>> Signed-off-by: Wei Hu (Xavier) >>> Signed-off-by: Min Hu (Connor) >>> Signed-off-by: Chunsong Feng >>> Signed-off-by: Hao Chen >>> Signed-off-by: Huisong Li >>> --- >>> +# Hisilicon HNS3 PMD driver >>> +# >>> +CONFIG_RTE_LIBRTE_HNS3_PMD=y >> # Please add meson support > This patch already contains meson support, thanks >> # Move build infra to the first patch >> # See git log drivers/net/octeontx2 as example > OK, I will adjust the order of the patches in this series and send V2. >> >>> diff --git a/config/common_base b/config/common_base >>> index 8ef75c2..71a2c33 100644 >>> --- a/config/common_base >>> +++ b/config/common_base >>> @@ -282,6 +282,11 @@ >>> CONFIG_RTE_LIBRTE_E1000_PF_DISABLE_STRIP_CRC=n >>> CONFIG_RTE_LIBRTE_HINIC_PMD=n >>> >>> # >>> +# Compile burst-oriented HNS3 PMD driver >>> +# >>> +CONFIG_RTE_LIBRTE_HNS3_PMD=n >>> + >>> +# >>> # Compile burst-oriented IXGBE PMD driver >>> # >>> CONFIG_RTE_LIBRTE_IXGBE_PMD=y >>> diff --git a/config/defconfig_arm64-armv8a-linuxapp-clang >>> b/config/defconfig_arm64-armv8a-linuxapp-clang >>> index d3b4dad..c73f5fb 100644 >>> --- a/config/defconfig_arm64-armv8a-linuxapp-clang >>> +++ b/config/defconfig_arm64-armv8a-linuxapp-clang >>> @@ -6,3 +6,5 @@ >>> >>> CONFIG_RTE_TOOLCHAIN="clang" >>> CONFIG_RTE_TOOLCHAIN_CLANG=y >>> + >>> +CONFIG_RTE_LIBRTE_HNS3_PMD=n >>> diff --git a/doc/guides/nics/features/hns3.ini >>> b/doc/guides/nics/features/hns3.ini >>> new file mode 100644 >>> index 0000000..d38d35e >>> --- /dev/null >>> +++ b/doc/guides/nics/features/hns3.ini >>> @@ -0,0 +1,38 @@ >>> +; >>> +; Supported features of the 'hns3' network poll mode driver. >> Add doc changes when driver feature gets added. >> # See git log drivers/net/octeontx2 as example > OK, I will modify the patches and send V2. > Thanks >>> +; >>> +; Refer to default.ini for the full list of available PMD features. >>> +; >>> +[Features] >>> +Link status = Y >>> +MTU update = Y >>> +Jumbo frame = Y >>> +Promiscuous mode = Y >>> +Allmulticast mode = Y >>> diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst >>> new file mode 100644 >>> index 0000000..c9d0253 >>> --- /dev/null >>> +++ b/doc/guides/nics/hns3.rst >>> @@ -0,0 +1,55 @@ >>> +.. SPDX-License-Identifier: BSD-3-Clause >>> + Copyright(c) 2018-2019 Hisilicon Limited. >>> + >>> +HNS3 Poll Mode Driver >>> +=============================== >>> + >>> +The Hisilicon Network Subsystem is a long term evolution IP which is >>> +supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920. >>> + >>> +The HNS3 PMD (librte_pmd_hns3) provides poll mode driver support >>> +for hns3(Hisilicon Network Subsystem 3) network engine. >>> + >>> +Features >>> +-------- >>> + >>> +Features of the HNS3 PMD are: >>> + >>> +- Arch support: ARMv8. >> Is it an integrated NIC controller? Why it is supported only on ARMv8? >> The reason why I asking because, Enabling CONFIG_RTE_LIBRTE_HNS3_PMD=y >> only on arm64 will create a case where build fails for arm64 and passes for >> x86. I would like to avoid such disparity. If the build is passing on x86 make it >> enable in the common code, not in arm64 config. > Currently this network engine is integrated in the SoCs, the SoCs can be > used > as a PCIe EP integrated NIC controllers or be used as universal cpus on > the device, > such as servers. The network engine is accessed by ARM cores in the SoCs. > We will enabling CONFIG_RTE_LIBRTE_HNS3_PMD=y in common_linux config in V2. > Thanks. Hi, Jerin as a PCIe EP integrated NIC controllers -> as a PCIe EP Intelligent NIC controllers Since it is currently only accessed by ARM cores on SoCs, maybe it is also reasonable to compile only on ARMv8, right? Regards Xaiver >>> +- Multiple queues for TX and RX >>> +- Receive Side Scaling (RSS) >>> +- Packet type information >>> +- Checksum offload >>> +- Promiscuous mode >>> +- Multicast mode >>> +- Port hardware statistics >>> +- Jumbo frames >>> +- Link state information >>> +- VLAN stripping >>> +cflags += '-DALLOW_EXPERIMENTAL_API' >>> diff --git a/drivers/net/hns3/rte_pmd_hns3_version.map >>> b/drivers/net/hns3/rte_pmd_hns3_version.map >>> new file mode 100644 >>> index 0000000..3aef967 >>> --- /dev/null >>> +++ b/drivers/net/hns3/rte_pmd_hns3_version.map >>> @@ -0,0 +1,3 @@ >>> +DPDK_19.08 { >> Change to 19.11 > OK, I will modify the patches and send V2. Thanks. > > Regards > Xavier >> >> > > _______________________________________________ > Linuxarm mailing list > Linuxarm@huawei.com > http://hulk.huawei.com/mailman/listinfo/linuxarm > > . >