From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33AA74568F; Tue, 23 Jul 2024 10:15:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20A3940E42; Tue, 23 Jul 2024 10:15:35 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2069.outbound.protection.outlook.com [40.107.220.69]) by mails.dpdk.org (Postfix) with ESMTP id 49C7840150 for ; Tue, 23 Jul 2024 10:05:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tivHCX8He9wvFkRP3Ah8PZzx2NBsE2PW6jSRAa+nPmB0W0ZIzwKL7lDbxDwsioxkv1yf1qb11bk1nIuF9POclCchHnvBSyp+uBLBwcRBXGySATs6QdhXl4aduTPSw06YEWpo2+rQ/85omOyDfMKTxUPUChYfvdazTdhoLAc2ibu7/VDw5m6gPUtjAd0LQWbkJqkIJrYHjXTJMJbqxmguANEgiDGHLDLhqvSZ3ghVxiJM1wje4ix4Njsx/VNJvhOVmjkYyHnmzCFADGs1cjZC/PNIkLtoWf+4Pn0QwSPSzmUcj4i9L6WAmUrCzWL/dnyeak2gqESROSiutmDG2nbYHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=80JkZRYKQRbqwk+yJohcQf+XiSTcwQXtJPz0WOzCZfc=; b=HiVyl2EOHn/wdr9K4jZKad/MuAQdUFoY72JBVKFoca8cPevrykilezNefVJgT7A7eQW001+DV3gfVIje/Mq1x6LFLVzCBTaojbc6Ib7VOuKZkdJARfIKQMDX+BE0olCPmkmRxx1s9r3p3Tm+gIeRUXQbXIDFnYTTbhZ+62cTk+0C5fNWHBazwIIly3XTHfJdd0S9fX0uBsuZ8bAVx4OeI5sxArCqCEcGd6nzTblbpkP+hxo9L6Pw1xCUFquYpxMybbGsUH871FKjKnYP160LZn1Z8D4rCqxJvLy8rNu13/6X86/XMlUR6sNxj8SbvZTSD+wFq80hdcImcPCcNkk47Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=80JkZRYKQRbqwk+yJohcQf+XiSTcwQXtJPz0WOzCZfc=; b=hc+VIlk0fdxMV5OMLMzjROeHjJfUqiqvjdpK0pc89nBfOL/aikxT6hEiDsh9SxFSfJm7eQKr17cwukV8ZrBBpoMtoavqlDQUSfwI32wdIYVm/b5FCT4NzHdzZwgS27Z/0easuqpzbACd6o2IREkfDxwGuU6H8YMSSetWIsTSwqY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5915.namprd12.prod.outlook.com (2603:10b6:8:68::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20; Tue, 23 Jul 2024 08:05:42 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7784.017; Tue, 23 Jul 2024 08:05:42 +0000 Message-ID: <1fb2b005-8b99-4550-aed2-f40f49b257a9@amd.com> Date: Tue, 23 Jul 2024 09:05:37 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [V2] app/testpmd: restore VXLAN-GPE support To: Gavin Li , matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net, Aman Singh Cc: dev@dpdk.org, rasland@nvidia.com References: <20240717071130.1548425-1-gavinl@nvidia.com> <20240723073730.33272-1-gavinl@nvidia.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240723073730.33272-1-gavinl@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b7::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5915:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b991c32-0f2c-45e6-f57e-08dcaaee3f7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZlpjQThKbGhZcldGaTZYSzJYSmJ4VkQ5V3kwdU1FZjFoOWIyL21zVGJOSHA2?= =?utf-8?B?Mlk2cG8vOXBxbnNiZWU2SWhJZ3h2SEhQWnowd1Y4aFdxVUtteGNmLyt5cmRF?= =?utf-8?B?V1lDclpxc2tjQk53M2pDd3JQcktCdk5kU0tvd3RRUEg0bjNNS3RsQ0NuL3NL?= =?utf-8?B?SVlrWEc2UW5JRHZNekphR2NMaHhJTnMrUHZlellQQ1ArVzVSVi9YSXpDdmlF?= =?utf-8?B?a0JrSzFsbDNabW1jVTBqMWdZTmp1VzJvTXJJdVNla2dqT1NRTncrSjdpbnR1?= =?utf-8?B?bThickovNUZGdzdqdm5yWGV2Y2U5aHIrbjVVSmo4TzBLWm41dW45bUxCWWNk?= =?utf-8?B?VTRSVzJaQUR1RWxUditsVE1UL3B1aTEyU3grV3VBZC8rTCtCUFEvK3NIa3lD?= =?utf-8?B?cUJjOS96QlBkbDFDSDViVk1FZUp4Wjg2aHVqVnRUekFKRWtPckxlWWJPOVZo?= =?utf-8?B?Wjg2U2REZ3lPZXhwN0E4aTFJcUVHbkUxOURGR3JRMTdBMmlwY0ZrMzl0QjNF?= =?utf-8?B?YTFIYy8wWHdycVhQaTY2c2F1VWpNdUNvMUpmN3k5c1IvZlhNQ09ieDFwU3VK?= =?utf-8?B?aEtKTjBwd0JvUnNFVmYzUXZQQTJ0VVdLdGtReFFmbWgybWJlVFJYTStkR01K?= =?utf-8?B?N1c5SlZjdUpnY1dxZERqdTJHQ1FpOGhxdzdBYytablBsRVczZVNnZzhkUnMw?= =?utf-8?B?MitzNktwS0JhVmJXcTNUcExIUGxYMGMyeEVFMDBMSFRaMUdkNWtWK3NGR0tp?= =?utf-8?B?dTU1VStuQmRpWjNvdHppYzlwbERkTVdzNTVmQmVBUHZJQzFFL3cxRXcrQU9r?= =?utf-8?B?T1ZuK013RHd2b09NdStrNnM5Q0p5RG5LVWJ1cWhlbThrOThBZFVITlgzTE5m?= =?utf-8?B?Y0lFYnFaR3VrWEoxMHJHNXhDdGk3NENTR2VEeHRDMGZyTHlBcnh5dVM2Visv?= =?utf-8?B?Q3Y5WTI2SytuSVR1VkJYVmhRZS83QjBZTDZabGxobExTTUluYkVtRzBHUHh0?= =?utf-8?B?ZDB0MmprT2w2eFNiTXNqelI1MncyUi91eWg2aHBrMnlGUFZoZ2p2UzhJT1VZ?= =?utf-8?B?RE1yNlhhWkdHL1NlMTBUSlpNWHhBSEdKWFNFYkY1aU1KMlJXNVZuN1JnMi9p?= =?utf-8?B?cE9PUHNucFU4MDV2Y3RIR0JTM0E2WlYzOWJhQXdrVXl6ZEZDMllVc0o0bFEw?= =?utf-8?B?WlJaVWcrT1NOM05FK2NKQVltSE1UK1grWUZjOW8yYXF6WHgzc2ZXdk5USE9V?= =?utf-8?B?S2pkWVozVzhHUzB2NFA3SlA5dDdublRDektWaDhsT0h2M28xZGROaTYyN1Fi?= =?utf-8?B?Q1U2SnQrOUljaDVvbm1RUkNFZzZKazJ3dGtsWTFweDM0WFdnTXNyRW1Fa3hw?= =?utf-8?B?RFRtK2l3V25TMzZSb1JOWVh5MmFHd3NNZzM4TUdBVkh1cmFoblJpd2M5akwx?= =?utf-8?B?U1lsTUQzSThFWTRnTzNZeEVKWGc4dmZRK09yRzdrZkJsQ3dtVnZZa0dBd1Ra?= =?utf-8?B?UDlWVHJpSkdpNzREbGdMVFVEVDcrWG8yaURTNkdocnR3NGVxdjYzOTl6RW56?= =?utf-8?B?T1dWaVY0WTBwRU82ODA4bFU0aHliMjBqbk1JdTNma0FxdnJtWWpIcUc4SEQ4?= =?utf-8?B?dWRxUHc5ZEJiUmZ3ZDd1SVkrd1hDSFVWMUR3V1crSTN5dVdTTEx6T1ZKM2JH?= =?utf-8?B?a2xwQ0t5Z3oxU3h6Y1NOM0JwT2FaSVorZ28wOGU3RlJWc2E0VmVlV1BKMWt3?= =?utf-8?B?QkhsNGJnTFN2MkR6K2hZZ1YwaW9QUkJ1RlBRZG4xQlIwOUp3YkdNc3luWXVW?= =?utf-8?B?R3pBVHlENjRrMVR0cEJJQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGs2N05KSmhlVTg5OVhaQ2xmallpb2ZoNFdYNGdwa09mRk91cTV2d2VHdmFC?= =?utf-8?B?enNJMzBZdTh2LzVFaXMzZXQzYUZBLzVJYVdWaU9ia0s4Yjh0MklFQ3l6bGt1?= =?utf-8?B?VVZhK3IvN1NpajFiMGEyMlZnd3JoZkRUSDVWNGsrTE5yRjFCSmI5Y0Q2eExX?= =?utf-8?B?aVd0bWJSWFJobDFMU09WQ1F6eExQSFdSK092MkV3STFvSlRUb1lsZThoN1lM?= =?utf-8?B?RzFwWjF2WUV5NG92MkxhaGN3cWJLOVZJU0E0ZXFKZUl1UHFXWVBIOE1Na3BC?= =?utf-8?B?dk4zK25tdllsRGVWNTF1Q2pxTUo1aVJIRWlMK2JtODJoTGxpN0hpcWx1OXdw?= =?utf-8?B?MHFQOUlkOW9ka2dYR1RmNCtFSGJRVjBEb2NlWVdZYXhrUVp5YXh4N2J5dXRR?= =?utf-8?B?Zk9mQWJyaTk4NkRFSS9hb2xud0RWU2I2UGdPQm05N29zaytWekVjOW1iZzc4?= =?utf-8?B?SnN2ZFlpQ2dRQTEwQmxWS1VpS2ZEem5KUXA2MkREVUcwUVZHZlBKS05PaU54?= =?utf-8?B?NzA4VG5WT2FxaEZCRnpXb3Z3SlA0OFRHUktUQngyUkEyeHJmWlhVZ2o3Z3cx?= =?utf-8?B?d2xsNGFvWVc4b09aU3p5d3VHenpuTEJDRC9GN1VsWDBVSUE5WnVPOFhoZVJh?= =?utf-8?B?Z2ZpOTVYTkl5TTdJeDhiMVEzTkh1bG0wRWtJWDBBRVhVY2hZemxidVpML3JO?= =?utf-8?B?THNhbWhydEtuUjhZMVA4NE56dC90aEZoUHcxV09SU21OaWFxUGlZbUJqMFQ1?= =?utf-8?B?M2VENzJ2OHFIZTNHaWdtRDBtVGw0aFAwSWUveThJRS9za3ZHUjZNZ1AvY2hL?= =?utf-8?B?Rng0cWovZ2tYd0hiQTNLWm1kS1JoVDcwQTlZaWNDMFByZGtSNTlEUGRON3Jh?= =?utf-8?B?c082VXlyTjRsY09ySFVQZnN6ams5ZEdKc1RERU1RTDlVTjZ6SmhPL2h2ZjNQ?= =?utf-8?B?SnhkZEh5ditiVmxPTzdmZjZoNWJHcGhmUWw1SExYNUJud3NodXIweG1wSGFh?= =?utf-8?B?UXhiN3l2aGtyZkNYMWx1NFpYaXN4TDltZ1ZxTmtoZFZpUGdOSmJ4QXUzMjhZ?= =?utf-8?B?Y282YkxPSkprRXpPRmJLdTV2ajQ1M2NVcVFPZHJSa3V3RkF2VExPVERNWFZL?= =?utf-8?B?NVh1M3dqN2NIdEVqQ1hsMGxXSzZPQ3RlMmNVa281aWUvc05idmU3cmZ1SUJz?= =?utf-8?B?U0dUNW9tZWtFOG01ZjJhRld1ci93U3BpNU1BMkp2amQveXFVaWNsaU5MZXlw?= =?utf-8?B?STl0SFFQQWVka3VKSklDSk84WlVCTW5LR000VGl0THFTdCtCL2VqVWszL2Ru?= =?utf-8?B?aEozdkJQZHJsazc0cExPWkZvWTRJMjJaejdaWllMeVViWVJydXZtTEpHZlht?= =?utf-8?B?Y3hyVWdYcCtZZWkxbjd6TzBYSVdMVmMrd092U3ZCenFDRExlQ2oyY1FsOTAz?= =?utf-8?B?TEFnT01SbXRJTDg4NEZiRjJDQjBKQVhsdk1wdFU5NjArWDFlU1NPUHZOZm5y?= =?utf-8?B?azhsL1g1bXN4OFpIQk9XdU5rMllMT3F1RUE5SUJ4bkN2cHlGSDhTcjBFSjl6?= =?utf-8?B?VFhGM3QwUFVHcjRDUExVOGtvVzlrek1KSDRxSlZHMXV1Y1BIS3FDcFMrRUkr?= =?utf-8?B?cFpneCtJSnNRcmhKaFBXRnZSZzA5TjBQQk5DdVZSc0JpZkVTUUptR1FwbEhP?= =?utf-8?B?UndJVHBQeUw5T3FMajdLWHA1VlVHTUltOFlCUVVhM1FTVU5mSDJGRXo5djhQ?= =?utf-8?B?cTBUWDlLSHN5a09oTjVpdVI2cjBkNGM3cjBoZURTVW1jZHBhVHhoeXRSSUN2?= =?utf-8?B?b09tcFdHU09MUlA1cDQvWTk1VVVkSjJvNWRLQWNkemhiQ3EyRWl1WFNSSHRE?= =?utf-8?B?YzdsTG10WldBRXA3L2VyQ08ySEZneWs4dkR1Y0lQVjBucEEveWVGamJKV3pG?= =?utf-8?B?Wkt2N3VuckhNOSs1YzNEN2luZEw0Q1k1SGhTSzNuYlRBNkQyTjhwVXRUVHRt?= =?utf-8?B?c3RkQUlkTFFzMXVLajljQmRlVkE1dFdzQ2NTYzc2V0ZRTzg0VXU4YjdnYzB4?= =?utf-8?B?N2ordUNxVlc2NTVvS1BrL3BNUkxMZVdlVU9tKzV1dW5iVlNjVFJiOGUvNDIx?= =?utf-8?Q?nGp3fSA5lMvis2DlWn6gcjlBS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b991c32-0f2c-45e6-f57e-08dcaaee3f7b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 08:05:42.5613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yhn9whEPQnflXwVGnuFxM9+uoiCvaxRMTU48a+XIz9qxMuq7nzztD6fWoa/7USDx X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5915 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/23/2024 8:37 AM, Gavin Li wrote: > VXLAN-GPE support was removed from testpmd recently. Drivers which are > not migrated are still using VXLAN-GPE in tests. > > This commit is to restore the support for VXLAN-GPE in testpmd. > > After this change, there are two command line items with the same name, ie. > "protocol". One is for the new VXLAN extensions and the other is for the > deprecated VXLAN-GPE. Add a new one that is more obvious for the new VXLAN > structure since the two have different command line context. > > Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field") > Signed-off-by: Gavin Li > --- > app/test-pmd/cmdline_flow.c | 71 ++++++++++++++++++++- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 21 ++++-- > 2 files changed, 83 insertions(+), 9 deletions(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index a76b44bf39..2c5a0491d2 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -391,7 +391,7 @@ enum index { > ITEM_VXLAN_FLAG_D, > ITEM_VXLAN_FLAG_A, > ITEM_VXLAN_GBP_ID, > - ITEM_VXLAN_GPE_PROTO, > + ITEM_VXLAN_GPE_PROTOCOL, > With more obvious naming I was suggesting something like: ITEM_VXLAN_GPE_PROTO_IN_COMBINED_STRUCT Or we can go the other way around, give obvious name to the other one, and when it is removed, this saves us some work to rename. Whichever you thik better is good. Also can you please add code comment, I think at least giving struct names can be useful, something like: /* Used for "struct rte_vxlan_gpe_hdr", deprecated, prefer ... */ Similar comment to the both can help. > ITEM_VXLAN_FIRST_RSVD, > ITEM_VXLAN_SECND_RSVD, > ITEM_VXLAN_THIRD_RSVD, > @@ -423,6 +423,12 @@ enum index { > ITEM_GENEVE_VNI, > ITEM_GENEVE_PROTO, > ITEM_GENEVE_OPTLEN, > + ITEM_VXLAN_GPE, > + ITEM_VXLAN_GPE_VNI, > + ITEM_VXLAN_GPE_PROTO, > + ITEM_VXLAN_GPE_FLAGS, > + ITEM_VXLAN_GPE_RSVD0, > + ITEM_VXLAN_GPE_RSVD1, > ITEM_ARP_ETH_IPV4, > ITEM_ARP_ETH_IPV4_SHA, > ITEM_ARP_ETH_IPV4_SPA, > @@ -1612,6 +1618,7 @@ static const enum index next_item[] = { > ITEM_GTPC, > ITEM_GTPU, > ITEM_GENEVE, > + ITEM_VXLAN_GPE, > ITEM_ARP_ETH_IPV4, > ITEM_IPV6_EXT, > ITEM_IPV6_FRAG_EXT, > @@ -1794,7 +1801,7 @@ static const enum index item_vxlan[] = { > ITEM_VXLAN_FLAG_D, > ITEM_VXLAN_FLAG_A, > ITEM_VXLAN_GBP_ID, > - ITEM_VXLAN_GPE_PROTO, > + ITEM_VXLAN_GPE_PROTOCOL, > ITEM_VXLAN_FIRST_RSVD, > ITEM_VXLAN_SECND_RSVD, > ITEM_VXLAN_THIRD_RSVD, > @@ -1864,6 +1871,16 @@ static const enum index item_geneve[] = { > ZERO, > }; > > +static const enum index item_vxlan_gpe[] = { > + ITEM_VXLAN_GPE_VNI, > + ITEM_VXLAN_GPE_PROTO, > + ITEM_VXLAN_GPE_FLAGS, > + ITEM_VXLAN_GPE_RSVD0, > + ITEM_VXLAN_GPE_RSVD1, > + ITEM_NEXT, > + ZERO, > +}; > + > static const enum index item_arp_eth_ipv4[] = { > ITEM_ARP_ETH_IPV4_SHA, > ITEM_ARP_ETH_IPV4_SPA, > @@ -4992,7 +5009,7 @@ static const struct token token_list[] = { > .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_vxlan, > hdr.policy_id)), > }, > - [ITEM_VXLAN_GPE_PROTO] = { > + [ITEM_VXLAN_GPE_PROTOCOL] = { > .name = "protocol", > .help = "VXLAN GPE next protocol", > .next = NEXT(item_vxlan, NEXT_ENTRY(COMMON_UNSIGNED), > @@ -5241,6 +5258,54 @@ static const struct token token_list[] = { > ver_opt_len_o_c_rsvd0, > "\x3f\x00")), > }, > + [ITEM_VXLAN_GPE] = { > + .name = "vxlan-gpe", > + .help = "match VXLAN-GPE header", > + .priv = PRIV_ITEM(VXLAN_GPE, > + sizeof(struct rte_flow_item_vxlan_gpe)), > + .next = NEXT(item_vxlan_gpe), > + .call = parse_vc, > + }, > + [ITEM_VXLAN_GPE_VNI] = { > + .name = "vni", > + .help = "VXLAN-GPE identifier", > + .next = NEXT(item_vxlan_gpe, NEXT_ENTRY(COMMON_UNSIGNED), > + item_param), > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_vxlan_gpe, > + hdr.vni)), > + }, > + [ITEM_VXLAN_GPE_PROTO] = { > + .name = "protocol", > + .help = "VXLAN-GPE next protocol", > + .next = NEXT(item_vxlan_gpe, NEXT_ENTRY(COMMON_UNSIGNED), > + item_param), > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_vxlan_gpe, > + protocol)), > + }, > + [ITEM_VXLAN_GPE_FLAGS] = { > + .name = "flags", > + .help = "VXLAN-GPE flags", > + .next = NEXT(item_vxlan_gpe, NEXT_ENTRY(COMMON_UNSIGNED), > + item_param), > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_vxlan_gpe, > + flags)), > + }, > + [ITEM_VXLAN_GPE_RSVD0] = { > + .name = "rsvd0", > + .help = "VXLAN-GPE rsvd0", > + .next = NEXT(item_vxlan_gpe, NEXT_ENTRY(COMMON_UNSIGNED), > + item_param), > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_vxlan_gpe, > + rsvd0)), > + }, > + [ITEM_VXLAN_GPE_RSVD1] = { > + .name = "rsvd1", > + .help = "VXLAN-GPE rsvd1", > + .next = NEXT(item_vxlan_gpe, NEXT_ENTRY(COMMON_UNSIGNED), > + item_param), > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_vxlan_gpe, > + rsvd1)), > + }, > [ITEM_ARP_ETH_IPV4] = { > .name = "arp_eth_ipv4", > .help = "match ARP header for Ethernet/IPv4", > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index c19b4f8958..f00ab07605 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -214,6 +214,7 @@ For example: > vxlan > geneve > nvgre > + vxlan-gpe > > show port (module_eeprom|eeprom) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > @@ -1103,12 +1104,12 @@ Where: > * ``ip|udp|tcp|sctp`` always relate to the inner layer. > > * ``outer-ip`` relates to the outer IP layer (only for IPv4) in the case where the packet is recognized > - as a tunnel packet by the forwarding engine (geneve, gre, gtp, ipip and vxlan are supported). > - See also the ``csum parse-tunnel`` command. > + as a tunnel packet by the forwarding engine (geneve, gre, gtp, ipip, vxlan and vxlan-gpe are > + supported). See also the ``csum parse-tunnel`` command. > > * ``outer-udp`` relates to the outer UDP layer in the case where the packet is recognized > - as a tunnel packet by the forwarding engine (geneve, gtp and vxlan are supported). > - See also the ``csum parse-tunnel`` command. > + as a tunnel packet by the forwarding engine (geneve, gtp, vxlan and vxlan-gpe are > + supported). See also the ``csum parse-tunnel`` command. > > .. note:: > > @@ -1123,7 +1124,7 @@ engine:: > testpmd> csum parse-tunnel (on|off) (tx_port_id) > > If enabled, the csum forward engine will try to recognize supported > -tunnel headers (geneve, gtp, gre, ipip, vxlan). > +tunnel headers (geneve, gtp, gre, ipip, vxlan, vxlan-gpe). > > If disabled, treat tunnel packets as non-tunneled packets (a inner > header is handled as a packet payload). > @@ -2221,7 +2222,7 @@ port config udp_tunnel_port > > Add/remove UDP tunnel port for VXLAN/GENEVE tunneling protocols:: > > - testpmd> port config (port_id) udp_tunnel_port add|rm vxlan|geneve|ecpri (udp_port) > + testpmd> port config (port_id) udp_tunnel_port add|rm vxlan|geneve|vxlan-gpe|ecpri (udp_port) > > port config tx_metadata > ~~~~~~~~~~~~~~~~~~~~~~~ > @@ -3745,6 +3746,14 @@ This section lists supported pattern items and their attributes, if any. > - ``data {hex string}``: GENEVE option data, the length is defined by > ``length`` field. > > +- ``vxlan-gpe``: match VXLAN-GPE header. > + > + - ``vni {unsigned}``: VXLAN-GPE identifier. > + - ``flags {unsigned}``: VXLAN-GPE flags. > + - ``protocol {unsigned}`` : VXLAN-GPE next protocol. > + - ``rsvd0 {unsigned}``: VXLAN-GPE reserved field 0. > + - ``rsvd1 {unsigned}``: VXLAN-GPE reserved field 1. > + > - ``arp_eth_ipv4``: match ARP header for Ethernet/IPv4. > > - ``sha {MAC-48}``: sender hardware address.