From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8930A0548; Tue, 31 May 2022 18:35:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A6074067B; Tue, 31 May 2022 18:35:21 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 194BC40143 for ; Tue, 31 May 2022 18:35:20 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.81.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 50B1B86; Tue, 31 May 2022 19:35:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 50B1B86 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654014919; bh=Q0dT/IgTE80mnYASkXTyzu6sR4UCQCC7no5o9XcMyJM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oBmaXfRe5klEq4A+4d3lDwo2eAvf98QdEfhE9KJZMkGYhN5+VCiS0w+DV7tbQ0+8J bQe9Owxgdfs+Q2FVT999ucGQXDbiFzJwRC4QSMW0Cfam+tTJCR04XpZl/+hzR1VX2s jdT6hOr9whHZ74JWZm3BqsCVEZcZtciUuV7wmyfs= Message-ID: <1fc4d0b9-a948-03a2-8a0b-b5250d8cf700@oktetlabs.ru> Date: Tue, 31 May 2022 19:35:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 3/3] app/testpmd: compact RSS flow type output in port info Content-Language: en-US To: Ferruh Yigit , Xiaoyun Li , Aman Singh , Yuying Zhang Cc: dev@dpdk.org, Thomas Monjalon References: <20220525173736.3394787-1-ferruh.yigit@xilinx.com> <20220525173736.3394787-3-ferruh.yigit@xilinx.com> From: Andrew Rybchenko In-Reply-To: <20220525173736.3394787-3-ferruh.yigit@xilinx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/25/22 20:37, Ferruh Yigit wrote: > In port info command output, 'show port info all', supported RSS flow > types printed one type per line, and although this information is not > most important part of the command it takes big part of the command > output. > > Compacting the supported RSS flow type output by printing 6 (hardcoded > value) items per line, instead of one per line. Output becomes as > following: > > Supported RSS offload flow types: > ipv4 ipv4-frag ipv4-tcp ipv4-udp ipv4-sctp ipv4-other > ipv6 ipv6-frag ipv6-tcp ipv6-udp ipv6-sctp ipv6-other > l2-payload ipv6-ex ipv6-tcp-ex ipv6-udp-ex port vxlan > geneve nvgre mpls > > Signed-off-by: Ferruh Yigit > --- > app/test-pmd/config.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 47de5b6d9458..5496ccd7f8ad 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -805,6 +805,7 @@ port_infos_display(portid_t port_id) > else { > uint64_t rss_types = dev_info.flow_type_rss_offloads; > uint16_t i; > + uint16_t len = 0; > > printf("Supported RSS offload flow types:\n"); > for (i = 0; rss_types != 0; i++) { > @@ -813,12 +814,21 @@ port_infos_display(portid_t port_id) > const char *p = rsstype_to_str(rss_type); > > if (p) > - printf(" %s\n", p); > + printf(" %s", p); > else > - printf(" user defined 0x%"PRIx64"\n", rss_type); > + printf(" user defined 0x%"PRIx64, rss_type); > + > + len++; > + /* wrap on every 6 items */ > + if (len == 6) { Variable name 'len' is misleading here since the first idea is like length, not a number of items. Also 6 sounds to be to much in the worst case scenario with 6 user defined types. Each uses at least 18 chars. So, 18 * 6 = 108. May be printing algorithm should be a bit more sophisticated and really track line length. > + printf("\n"); > + len = 0; > + } > } > rss_types >>= 1; > } > + if (len) > + printf("\n"); > } > > printf("Minimum size of RX buffer: %u\n", dev_info.min_rx_bufsize);