From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13084A00C3; Thu, 3 Feb 2022 14:49:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC8424014F; Thu, 3 Feb 2022 14:49:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8979740140 for ; Thu, 3 Feb 2022 14:49:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643896184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rsKHR0fNy9VaWy+uGPSXnWhkcdgzHZvlk/Fl03hB+mw=; b=Uk/MVEIlQp3noTRNMo/v7+q/lN8aX0757zmXHWuFFpijxaRjZhh0R6hQbUjyBzCvch5gis prUaet4qdKWu7QXrSbJGWnDdTiQ+1dwnGldWntn/wild3vFZXswlmk86RcYJFMIZcNbfXp zfoOF9CMl1uG7FTkkfNvlueC8AFJvHI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-a9q53FF9MYqpMtzSKfLoBQ-1; Thu, 03 Feb 2022 08:49:43 -0500 X-MC-Unique: a9q53FF9MYqpMtzSKfLoBQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0CBDD343CB; Thu, 3 Feb 2022 13:49:42 +0000 (UTC) Received: from [10.39.208.15] (unknown [10.39.208.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 461A1519CD; Thu, 3 Feb 2022 13:49:40 +0000 (UTC) Message-ID: <1fcb2f5a-3ebe-1f9f-61b7-bb85ee65c08e@redhat.com> Date: Thu, 3 Feb 2022 14:49:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] vhost: fix null pointer dereference To: Weiguo Li , chenbo.xia@intel.com Cc: dev@dpdk.org References: From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/29/22 20:07, Weiguo Li wrote: > Fixes: 155ee3542fb1 ("vhost: improve vhost-user layer logs") > > Signed-off-by: Weiguo Li > --- > lib/vhost/vhost_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index e8297a09eb..d032998488 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -671,7 +671,7 @@ numa_realloc(struct virtio_net *dev, int index) > dev = rte_realloc_socket(old_dev, sizeof(*dev), 0, node); > if (!dev) { > VHOST_LOG_CONFIG(ERR, "(%s) failed to realloc dev on node %d\n", > - dev->ifname, node); > + old_dev->ifname, node); > return old_dev; > } > Thanks for the fix. Reviewed-by: Maxime Coquelin Thanks, Maxime