From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0069.outbound.protection.outlook.com [104.47.33.69]) by dpdk.org (Postfix) with ESMTP id 5BFB32BB2 for ; Tue, 28 Feb 2017 09:43:33 +0100 (CET) Received: from BLUPR0301CA0035.namprd03.prod.outlook.com (10.162.113.173) by SN2PR03MB1949.namprd03.prod.outlook.com (10.164.114.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Tue, 28 Feb 2017 08:43:31 +0000 Received: from BN1BFFO11FD041.protection.gbl (2a01:111:f400:7c10::1:174) by BLUPR0301CA0035.outlook.office365.com (2a01:111:e400:5259::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.12 via Frontend Transport; Tue, 28 Feb 2017 08:43:30 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD041.mail.protection.outlook.com (10.58.144.104) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.933.11 via Frontend Transport; Tue, 28 Feb 2017 08:43:30 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v1S8hRFJ010226; Tue, 28 Feb 2017 01:43:28 -0700 To: Jan Blunck , dev References: <1487600262-14382-1-git-send-email-jblunck@infradead.org> <1488018496-995-1-git-send-email-jblunck@infradead.org> CC: David Marchand , Ferruh Yigit From: Shreyansh Jain Message-ID: <1fe7b405-0b78-08fe-4696-5d96e6769567@nxp.com> Date: Tue, 28 Feb 2017 14:18:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131327450109085851; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39410400002)(39850400002)(39840400002)(39450400003)(39860400002)(39380400002)(39400400002)(2980300002)(1110001)(1109001)(339900001)(189002)(24454002)(199003)(377454003)(9170700003)(229853002)(50466002)(53546006)(6306002)(54906002)(33646002)(2906002)(4001350100001)(53376002)(38730400002)(77096006)(85426001)(83506001)(4326007)(23676002)(189998001)(64126003)(86362001)(106466001)(65806001)(6666003)(31696002)(2950100002)(76176999)(54356999)(305945005)(50986999)(966004)(65956001)(105606002)(65826007)(36756003)(8936002)(47776003)(8676002)(92566002)(356003)(53936002)(104016004)(6246003)(5660300001)(626004)(31686004)(81166006)(230700001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB1949; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD041; 1:iXXPMwV/t9f0x73aigHtSzxtf5JJoWZxMm8oG5b9SHkUldIfjyIjR5oO64SXpKAFpUbgW/Dn6rBTTZJEcsvlUB52b/AP6mBCQ2Nwr9ICMu1L/bLp7d4TWCAbxJgHE1mZHOQshbXD121EueHPYA/mRz4wFPNdPelsP1Zcr3EBf9zFg8fJez+ECzBSxNI1ma8a3ufPDm1UW8RPIOLe83XOO7ocuU5e96jOy6IleLmpROWW/MvNtqxpnaIfnygwugOKIvdc2/B2ZBb8pDR4vuNDp95vPkXUuR6LX+pxtS48QhCqs9FgppeBZ7XF8G02m1WlmmKWMALk2d43mK51gyQgj1FEpC2QGo85xX31DTG7ivRa2ns35x0WdUw4Fe1qAhW6SC5rX1wKULPUQpKu3AYxJSV8lOnED0NyRXrGIDOjKgGJArKg6VZ045h6/EH++J+HcuWtzdwyT6lyxQgYD3CLf0dvuDkG34MSsGZQuHpozCo9Z+LUp0WTWzZxquejRUg5DiA0djFOxRWARVs7P6wz6usI094mrUqSoR0JwK1DVNy9SphezW/uM9AF5HwtiJcDo2Ptf1XA6JR27lbR1DSiD3Q7FGT8vumvL+N490VFxrM= X-MS-Office365-Filtering-Correlation-Id: 27cd1d15-4515-4af8-889b-08d45fb5df79 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN2PR03MB1949; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB1949; 3:JzVMTzbiZSRMzdjA39cj3Yr8F2IfBfY6ZE/3tX/rS74HlEnApG3ngCP1Qw2f8wOoh5nyOjhKALz1NBPvYVHJXQ6X726620pFsKRw4cpH/ZN0n+UeZLeUC9KykLliM8WFzEksmV5zxQdbfW7uguHykgNym0KGjL+4gGpoWBZ0uu9bq9hB+f/gIsWNOgrCz7r6eWgM4Z7o3zV4r7Z06vQNEEAeFRJOA72Qa/gMNQqGUV7nWSqTWukn7oeZBzn0y6yZBMPRVtDqAuCN8eBo9rWJ694HcyNNQ6meEVunlfxPZ2k6x76p5qfglIGCsQcbK0yLgF09sDioqAdXH9aaAf6NO73E/5YQLTs4pdxgDVZGHeoNbCQY4iCwRpLkhhOixvmx; 25:yu288PC6DnZm0+tfRHGzDA9hKyKZDyBLdi+4LPudmFy0OtN6fQGI8dx/SUJCuGQYHR2uKGVH+Hxx/z9Rd1CZfhi/wpYZ2NwjLg4QKbbksA8Aeya4NwV9O1+WOL7aRH6la0vOvwtIZOZqK1KMZxkQrERD4y62TXlA2Yqmb1tUO6NEBnjYuGFhD61uLI5keZNuVjtAsXaTnpIs/M4VlKqounv3bXHlhJsR+/BRMvxFTAyY12nOtNctSPj9D/Qn6pLOLZCrn1t6RTidR94UpHJn91YwuTIxjT9YSoYYbaf8EvdUNtfnw/RRk4gw37QZVRaC0IRPD+ivP3I227Fcp01ryNn7u6mTU/7msMOYxHXWCnKemWMxg1vBRO9T5BfZi7HGlzUNaFbuojiS0dliBhiro+l1Tq43p71Jn5e/o7eSv8PTE0GG+nQpmfAH3FYEUaTljIeVyfXyfNROl9DgRRTkTA== X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB1949; 31:mODgg2S9zr4A169zM6wGLhqW/F/svHrEeUjhdxY1Uzgwqi7xtaCGKo037HOlTVcRifjOpbhfgw4zsDwTIDjRE10okQ1kxlRunr0gbI3JvqN3/kDMX0P/TDnqpM3ynvwloy3122Hu30TeDHj8gJ6xlpeh38Ab8RA66BQ7Rj7RLbWn09XJw4HeTl6QL2WjuL+YsWKoKMDHkbCvi/K95q1MLCvhUuyYeYWijvn8Uzv6TVJfRYwAfDZbRLl1TlJb27Z+oj86n0+oIKCKT6bBOyFwPlYqbMhyiqh+hiHmMPbuoec= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(5005006)(8121501046)(13017025)(13015025)(13023025)(13024025)(13018025)(3002001)(10201501046)(6055026)(6096035)(20161123559025)(20161123565025)(20161123563025)(20161123561025)(20161123556025); SRVR:SN2PR03MB1949; BCL:0; PCL:0; RULEID:(400006); SRVR:SN2PR03MB1949; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB1949; 4:Mx5mSZOACqrrg/2+xcmxqZ9+4QsKp457jU3MR2lQSC/GGqa+V2IumlWo9K5oceqSkPUWF+EJgelKPJja2yDOU4rXyCXZcPhAE9mjZiHbw8yR1oFuBiBiZ70OCxcZVWsRKEXQ29Ss7YgYP49n3d7dr27lNkInwkBYkC7ycTwZhE85t4Jv+xrrew3pFwm/bGa0h2Encv2IhxT+dCk8p6j2sPQNW1kxecAotTNMregK5S8J9Djp7mVA4zRtYmIc2vFEAx4a7wrKiVWRnchb95l0DLTSGcQ6W6a2JjK84Z4czUofAK+1LXaSwT++ehiwhf5I5UU/mxABG6eCGBtuukxMerP43M15Tkt9AmalVoOEXDsH1UnAWzejqVks4Jzh5TmOw+iDafCuPSkog2vr0EoYJMDcnEXUzcwSKCJZ7gmLBQSRSH2PMPVBh6fFcKpfPlC/Jqx2wxM4yXUadiI3eKd44ZWr6wbjPdrrOsEGxevpmJe3FNBQA6HMhjXXjHQ6bG9cdzjTT8LyCHi0F9lTOCGP6gmHZDW37upepgVhntFDcCTuq3gMpzhMt25lhBKZ2SS6Lc5xF28KRo99neTqOmZzYsCOtQ0if48RxjfsSwXU4dl0TQMP7/uSVqe4E8GNfPSTaIQWjwa+KDKGycVmk8UN4OLCzkEyGTeuEf3AKblc2gSIFsJWX3jsoC60DTjVTYns7Ds3jUUg0achJYC6wSYgLg== X-Forefront-PRVS: 0232B30BBC X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjAzTUIxOTQ5OzIzOkUvdFFjMi92VUJqUkZXNEV6UXBiUkM3SWI1?= =?utf-8?B?Vk5adWpFTHNnUTN1OEcvaHZGSHF2bngrRGJOQndDZ2RCMVN2T0lmZ1I5RExV?= =?utf-8?B?WFczc0xJWlFSK2E5VGJiKy9EOFpKZ1gvQkJCYnpxTEM4Mys2VFBwVU56b29T?= =?utf-8?B?UDNvK2ROU250TDF0Zi9IRzhnNlJzeGhzQlFtK0RudE1rODBSU0lmOU5td0dr?= =?utf-8?B?dnp3WlAxejNSd0dJWExOUVIyK1ByOUJVREkvNnphYjRLak1mdEg1bk14UkdZ?= =?utf-8?B?MDFjT2hkVm9HdW9CVXArOUF0YmpwVktKNFM0TjlXNjcwRVh0Qy9PR2Jsc1hJ?= =?utf-8?B?aFpuQXVxMzVlby9GL3ZMZWhGQ2pETk1TV0kxR2ZTN0doYWc2N0xjK2xWaEI1?= =?utf-8?B?ODJPdlJaYkJSeWt3S3VQTk5WNXBrNzNESWk1SzBReVEzN3ZDZjVwcmZVRm9h?= =?utf-8?B?TW9lU3QvTGZRakhpbUxDbndwUjVvVy8za3k3dkF3MkdyTHBCZ1k5Wk1QQWNo?= =?utf-8?B?WU02MllvdjA1Z1RPK2RKaFpiMnhYejNuNWxmUVJtQ2ZYVmJrRjVPQ0s2aTEz?= =?utf-8?B?dHI1dVVsb3F5WHBqM0lUdmoxUFd0QlUvVmx6aWh3NXk1anppWThxc0IwcFFo?= =?utf-8?B?REFmbEZnSC9ZRGk2dGFBR1g2cEJ1RjB6MnAwTnlXSWRFQjlIcFdHTER1bkF3?= =?utf-8?B?eDBjeEFjcG10cDVVMmZDNmV3SHRVd2gyV2RQZUQ4UFZBaGx5MSt3VU9wR0Rh?= =?utf-8?B?VFBYNTU4dmFTMzJKZ3krandNVnFleWVtdjRwK0NaaXU4dGhHR3ZKaklaZmUz?= =?utf-8?B?V1dDaFZBeElWU01tZ2RRTW8zNG9LZ21ZZFBwTG94OU9rQm85dUVoNEdCU2RO?= =?utf-8?B?QktuV0ZSSmp0bENQNmR6TmZMQXhVblVqUHdLaS9sL2hZWDlTWWtNRy9leHRW?= =?utf-8?B?cjBxc1RHOGZCcFRNTjNsamltVUNscmRrR283WXF1cFBJSmIvdnVheFA4VEpm?= =?utf-8?B?RklQblFHb1lCVWxmSE4vQ2RqeFZRRTQ5d1dhdU9MRVBONDQvem1xUlNTSGtZ?= =?utf-8?B?aVQwYktaUmhmaEV0cUZFS2tsZHZDRmVOS0VZUnVlSWtIcUhjcks5N2RzOHdo?= =?utf-8?B?bk9TZXJYRWtySU8rbFg3Wml1T0tPOUlOdDdsZk5uRnFKbG9SZjdHUUVCb0dX?= =?utf-8?B?UkFjT28xZTBCN0FRam5TekpwT29qeGlVdmNDZUg2SXFZdnQyOUl4bjV0NEFi?= =?utf-8?B?OFozaXNxMmlQWVM5Yi9LaU4yaWwxWEhhdWJaM2dWeDdLdVd2bXB5bmhVd1pS?= =?utf-8?B?a21nVWRCc1RGaExMQVUzbjlna0c2SWVCQktBMDhKMWFtdUN3UUplQUZpYSs1?= =?utf-8?B?cWlaZ1NXVGRncWI2TXV3U0dOcW5VVi92V21pOG5LRFhDUHpYR2ErVEFCaFRS?= =?utf-8?B?YjZPcG5vMHRCQk1yVHJ6QmpoWmwyZ3VHYUxaQlo2Vlppa1MrSHpzRytZVytZ?= =?utf-8?B?SDcwR08xSTZJYitoNUt3U05yazZHQXpQbU1mZnZvd2tYL1pMYWRLNWN0NXBP?= =?utf-8?B?cnhPVGc0NHVvNnhsV1pWT3lyRk53dWltUThzQW43V2x1K0w5aEpVSmswVXBI?= =?utf-8?B?VDVka281UU1iTVlqS2N3MjJoczdsSkErMWtmM21XOGJGUml6TVpaNnFESDF4?= =?utf-8?B?OCt3a2tDSVVra0VmYWJQOVpYT3JGMkJaL3FaaC9Rby9IYVl5aWR0MDJVRTBr?= =?utf-8?B?dm9wdjVVZFV1MDVwRzR1eXVubDZ1emp1ck4ySG1yelkwUnVYQ2cvWDJSU0xy?= =?utf-8?B?a0FWVFMwNkFRRlE1ZDRJb1pSYzhNSVdkRVBxRzRRNEVuYkVRQjNvVlhVSDN3?= =?utf-8?B?TGIvWEdiOXZERHordGU0YjdQK3RWTGF3RmhLcGRQZkh6eEZvOU5NeFYvaGFh?= =?utf-8?B?ckVxTnN3d1RsNlJ4MlBKMklhWWFmQVAvNjJsbXUrd0dsNTBSZTFOMmtEL2pX?= =?utf-8?B?MGNEY2hjYXpkNTVKQ25Dd2grd2dCNENtRTNuOXhDNlJkMmhrcHY5ZnlFRVRt?= =?utf-8?Q?lq3KAI9Sp65SLvxfe2JISAxHo?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB1949; 6:C/pv8VomzMp6+i5IQDilcO+PKbB4wgP252ftbGGIXr3U8zwPYlPDPccEB7cckdjUhq8hkCXU3gsyktcnyxxqdSgE2/OQ0Ar5Gjb14pL35dF6qKyC5UF9N8auzUHbswgUtplgMDYJaIYGJfZM0HjvSparB79Hye794qAFRjFdWDvcXzM3VxNisdRmZeAL2q47trvFhO9MdP5YnOQQXbTmdBHzMBsKB1iReK21mJnJKQebUQ7Y2SQRNzM7ufIgzRy/QlV6hGNjnNkUW4H/D5OHr/E4he0U1+EAz0+kuYOHXvwv22YQ6wxz08AZCBRKLGYXA6sIXSGOjDaDZ2joUlEf4CXhLq2stMjgZgoQRH/qP3kH+qi154gIQjfY41ZvIZ1YGW7N27moyifouqefdQHohJO+ZNzZ2wzasnhq7XHjSQw=; 5:G2OlfYTtYTGr+N4hh8luYR3vco3g+LPHbMgXskEqA5xOEfhXKrrwyZnknFMbMgNx4a44RXTrF/X/0fg8RBLZ0kP+kih+HvT5My/M6lqCv1qQ6EgO1/nVQzFFXVmwS9ThIr/R8Mjkh4uE9p8K+LxhmrbJxDJ7LICD/U/MRXZ9/NvcaZxe10CkNIad6AoWonA2; 24:c2IjI9WupAJsOqbuRhC7EKpHmhBaFNjt0DeFYFoj7rhFm2ojKsRnRVkPRF4huRS51IuHF9Yna83QsYCtM19jM76ORw4wFcXif8dbLtEvrVI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB1949; 7:1P+eDfGhUrQtEHBNY62Kk7oSSHD81vUaqG9Csx0zoXYY1adDSv9htP9ZwYG4TABzxmsdn48HzBeJ63DpOOojUlzH531WdhTPY12G2lh/+msx+3gysFsfGJqnf/FpnZexKZhrAz9oQFlp/nWrFMWdiUWHzsL1g74zVMmFUPxUFHQApoFpNujtrRG50Gs8kEhOzQ1OujMK7kqNTg23aicuXu3zL7Dqh7VZDXsvdT5RrE4aS1yKogMC4Tjg07ytfDqZOekkEKh7EA1CfGZBcbasbGjRInMPELRo9pTzMTyOsXJXLERD/v82wXjpVDbUPX2KxyRoA5jeKMGDccd5iJG0bQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2017 08:43:30.6901 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB1949 Subject: Re: [dpdk-dev] [PATCH v3 00/10] Rework vdev probing to use rte_bus infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 08:43:33 -0000 On Monday 27 February 2017 06:39 PM, Jan Blunck wrote: > On Sat, Feb 25, 2017 at 11:28 AM, Jan Blunck wrote: >> With the rte_bus infrastructure present in 17.02 it is possible to refactor >> the virtual device probing into a bus. This series also introduces the >> rte_vdev_device to better keep track of devices. >> >> This patchset depends on: >> http://dpdk.org/dev/patchwork/patch/20416/ >> http://dpdk.org/dev/patchwork/patch/20417/ >> >> Changes since version 2: >> * implicit bus registration through rte_eal_vdrv_register() > > On a second thought I don't think that this is correct though since it > opens up the possibility of racing an alternative "virtual" bus. I > don't think that this is a good thing though. I'll fix this in v4. > > Thoughts? I prefer the RTE_REGISTER* way. The issue of duplicate bus remains whether we use the macro or the implicit way. If you use RTE_*, do you think that duplicate registration issue is worth fixing? (It would mean rte_bus_register to return error which the caller would then need to handle). > > Thanks, > Jan > >> * explicit delay probing of virtual bus in rte_bus_probe() >> * addition of rte_vdev_device_args() helper >> * make virtual driver probe and remove take rte_vdev_device >> >> Changes since version 1: >> * addition of rte_vdev_device_name() helper >> * removed rte_eal_dev_init() from *.map files >> * use SOCKET_ID_ANY >> >> Jan Blunck (10): >> eal: probe legacy PCI devices before other bus devices >> eal: probe new virtual bus after other bus devices >> eal: move virtual device probing into a bus >> eal: remove unused rte_eal_dev_init() >> eal: Refactor vdev driver probe/remove >> eal: add struct rte_vdev_device >> eal: add virtual device name helper function >> eal: add virtual device arguments helper function >> eal: make virtual bus use rte_vdev_device >> eal: make virtual driver probe and remove take rte_vdev_device >> >> drivers/crypto/null/null_crypto_pmd.c | 18 +- >> drivers/net/af_packet/rte_eth_af_packet.c | 11 +- >> drivers/net/bonding/rte_eth_bond_pmd.c | 13 +- >> drivers/net/mpipe/mpipe_tilegx.c | 10 +- >> drivers/net/null/rte_eth_null.c | 13 +- >> drivers/net/pcap/rte_eth_pcap.c | 12 +- >> drivers/net/ring/rte_eth_ring.c | 9 +- >> drivers/net/tap/rte_eth_tap.c | 10 +- >> drivers/net/vhost/rte_eth_vhost.c | 10 +- >> drivers/net/virtio/virtio_user_ethdev.c | 18 +- >> drivers/net/xenvirt/rte_eth_xenvirt.c | 9 +- >> lib/librte_eal/bsdapp/eal/eal.c | 9 +- >> lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 - >> lib/librte_eal/common/eal_common_bus.c | 16 +- >> lib/librte_eal/common/eal_common_dev.c | 28 --- >> lib/librte_eal/common/eal_common_vdev.c | 259 +++++++++++++++++++++--- >> lib/librte_eal/common/include/rte_dev.h | 5 - >> lib/librte_eal/common/include/rte_vdev.h | 26 ++- >> lib/librte_eal/linuxapp/eal/eal.c | 9 +- >> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 - >> 20 files changed, 355 insertions(+), 132 deletions(-) >> >> -- >> 2.7.4 >> >