From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D2EFA0C41; Fri, 8 Oct 2021 08:17:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F33B140DF7; Fri, 8 Oct 2021 08:17:42 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id D6D9940140; Fri, 8 Oct 2021 08:17:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="289941767" X-IronPort-AV: E=Sophos;i="5.85,356,1624345200"; d="scan'208";a="289941767" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 23:17:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,356,1624345200"; d="scan'208";a="568918737" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 07 Oct 2021 23:17:39 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 23:17:38 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 8 Oct 2021 14:17:36 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Fri, 8 Oct 2021 14:17:36 +0800 From: "Zhang, Qi Z" To: "Zhang, AlvinX" , "Xing, Beilei" , "Guo, Junfeng" , "ktraynor@redhat.com" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] net/i40e: fix Rx packet statistics Thread-Index: AQHXtbrWEs3gkCexc0+GzEs4zc8if6vIrMaw Date: Fri, 8 Oct 2021 06:17:36 +0000 Message-ID: <1fef42b9d2ab4d8d829f010013dd957b@intel.com> References: <20210928032239.17756-1-alvinx.zhang@intel.com> <20210930051957.12628-1-alvinx.zhang@intel.com> In-Reply-To: <20210930051957.12628-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix Rx packet statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, AlvinX > Sent: Thursday, September 30, 2021 1:20 PM > To: Xing, Beilei ; Guo, Junfeng > ; ktraynor@redhat.com; Zhang, Qi Z > > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [PATCH v3] net/i40e: fix Rx packet statistics >=20 > Some packets are discarded by the NIC because they are larger than the MT= U, > these packets should be counted as "RX error" instead of "RX packet", for > example: >=20 > pkt1 =3D Ether()/IP()/Raw('x' * 1400) > pkt2 =3D Ether()/IP()/Raw('x' * 1500) >=20 > ---------------- Forward statistics for port 0 ----------------- > RX-packets: 2 RX-dropped: 0 RX-total: 2 > TX-packets: 1 TX-dropped: 0 TX-total: 1 > ---------------------------------------------------------------- >=20 > Here the packet pkt2 has been discarded, but still was counted > by "RX-packets" >=20 > The register 'GL_RXERR1' can count above discarded packets. > This patch adds reading and calculation of the 'GL_RXERR1' counter when > reporting DPDK statistics. >=20 > Fixes: f4a91c38b4ad ("i40e: add extended stats") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alvin Zhang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi