Re: [PATCH v2 05/19] net/xsc: add ioctl command interface

["WanRenyong" <wanry@yunsilicon.com>]

On 2024/9/12 13:50, Stephen Hemminger wrote:
> On Thu, 12 Sep 2024 12:14:08 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>>>   
>>>> +};
>>>> +
>>> Does this device driver depend on some upstr
>> Yes, it depends on linux kernel driver of the device.
>>
>> Hello, Stephen,
>>
>> Thanks for your review,  please see above.
> What is the driver? I don't see in the current kernel.org tree.
>
>
> My concern is that if the driver is not upstream, it is probably not
> going to pass the review of kernel developers. This means security and
> API changes would be required.
>
> Ioctl's are considered the worst API to the kernel and unlikely
> to be accepted.

Hello, Stephen,

Thank you for reply.Our kernel driver is being prepared to open source.

Our PMD is going to coexist with kernel driver to support flow 
bifurcation feature.

Ioctl API is used for interaction between PMD and kernel driver. As you 
said, ioctl is

the worst API, should I consider using read and write instead?

If not, could you please give me some advice?


-- 
Thanks,
WanRenyong