From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7302A4596C;
	Thu, 12 Sep 2024 10:19:35 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1A78A4029F;
	Thu, 12 Sep 2024 10:19:35 +0200 (CEST)
Received: from lf-2-33.ptr.blmpb.com (lf-2-33.ptr.blmpb.com [101.36.218.33])
 by mails.dpdk.org (Postfix) with ESMTP id C3BB64025E
 for <dev@dpdk.org>; Thu, 12 Sep 2024 10:19:32 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 s=feishu2403070942; d=yunsilicon.com; t=1726129166; h=from:subject:
 mime-version:from:date:message-id:subject:to:cc:reply-to:content-type:
 mime-version:in-reply-to:message-id;
 bh=ZG/ylEJ0CdBGFQafC0wwcN6ASC9Y5gGCDk5K7LZjgq4=;
 b=a129PWw3Hxee/hKEeiuN2pRN5Ab6zmhXN/TYZWNu29B8qGWoRiy6S38tu5/841q8YyimdQ
 f3aCzQ4NNZ/geUglkAnPe+l4877R9c4stqlOOpHjw4xXgRzd+qXTdIP6VHvgi/by3E1mqt
 4rKHYpSavIjgjrVIGqsNfG9c8AWkFvKG5ELm9lTHEe6zRaYnpn2OMUM93l62CgdL9Np7xC
 kuIn8NIo2u7FIQGuqDbxjiuyO3+A9rUWf/fTjWDmUsGLD5QF/gDCK40rmJWk7xBg47CsMQ
 Cu1Yhw68+E39ndAJkudFmN6zFe2EzzryZObsma3UFdZwtiHeXIp17HxuIm3ktA==
References: <20240911020740.3950704-6-wanry@yunsilicon.com>
 <20240910205058.25bf5f8c@hermes.local>
 <8cf9b5e8-cab4-45e6-b959-1d87f8a8ea99@yunsilicon.com>
 <20240911225021.16839cb2@hermes.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>
Subject: Re: [PATCH v2 05/19] net/xsc: add ioctl command interface
Mime-Version: 1.0
Date: Thu, 12 Sep 2024 16:19:23 +0800
In-Reply-To: <20240911225021.16839cb2@hermes.local>
X-Lms-Return-Path: <lba+266e2a40d+2bac59+dpdk.org+wanry@yunsilicon.com>
X-Original-From: WanRenyong <wanry@yunsilicon.com>
Received: from [127.0.0.1] ([222.64.242.227]) by smtp.feishu.cn with ESMTPS;
 Thu, 12 Sep 2024 16:19:24 +0800
User-Agent: Mozilla Thunderbird
To: "Stephen Hemminger" <stephen@networkplumber.org>
From: "WanRenyong" <wanry@yunsilicon.com>
Message-Id: <1ff7f17e-181b-49da-8f84-bf430f449dec@yunsilicon.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024/9/12 13:50, Stephen Hemminger wrote:
> On Thu, 12 Sep 2024 12:14:08 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>>>  =20
>>>> +};
>>>> +
>>> Does this device driver depend on some upstr
>> Yes, it depends on linux kernel driver of the device.
>>
>> Hello, Stephen,
>>
>> Thanks for your review,=C2=A0 please see above.
> What is the driver? I don't see in the current kernel.org tree.
>
>
> My concern is that if the driver is not upstream, it is probably not
> going to pass the review of kernel developers. This means security and
> API changes would be required.
>
> Ioctl's are considered the worst API to the kernel and unlikely
> to be accepted.

Hello, Stephen,

Thank you for reply.Our kernel driver is being prepared to open source.

Our PMD is going to coexist with kernel driver to support flow=20
bifurcation feature.

Ioctl API is used for interaction between PMD and kernel driver. As you=20
said, ioctl is

the worst API, should I consider using read and write instead?

If not, could you please give me some advice?


--=20
Thanks,
WanRenyong