From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0060.outbound.protection.outlook.com [104.47.37.60]) by dpdk.org (Postfix) with ESMTP id 87F11A495 for ; Tue, 16 Jan 2018 10:43:10 +0100 (CET) Received: from CY4PR03CA0010.namprd03.prod.outlook.com (10.168.162.20) by BN6PR03MB2691.namprd03.prod.outlook.com (10.173.144.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Tue, 16 Jan 2018 09:43:09 +0000 Received: from BL2FFO11FD032.protection.gbl (2a01:111:f400:7c09::108) by CY4PR03CA0010.outlook.office365.com (2603:10b6:903:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Tue, 16 Jan 2018 09:43:09 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD032.mail.protection.outlook.com (10.173.160.73) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Tue, 16 Jan 2018 09:43:08 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0G9h5Gn002106; Tue, 16 Jan 2018 02:43:06 -0700 From: Shreyansh Jain To: Ferruh Yigit , Stephen Hemminger CC: Hemant Agrawal , Bruce Richardson , Konstantin Ananyev , References: <20180108174514.14688-1-stephen@networkplumber.org> <20180111170658.2809-1-ferruh.yigit@intel.com> <20180111170658.2809-5-ferruh.yigit@intel.com> Message-ID: <1ffa95f4-fd66-6e6f-274b-751a18efcbb2@nxp.com> Date: Tue, 16 Jan 2018 15:27:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131605693889003671; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(396003)(376002)(346002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(189003)(24454002)(199004)(356003)(305945005)(53376002)(2906002)(2870700001)(105606002)(5660300001)(68736007)(4326008)(106466001)(31696002)(65826007)(104016004)(26005)(229853002)(6246003)(93886005)(6306002)(23676004)(2486003)(8936002)(8656006)(6666003)(77096006)(316002)(53936002)(64126003)(97736004)(2950100002)(50466002)(76176011)(8676002)(31686004)(81166006)(498600001)(966005)(110136005)(81156014)(47776003)(65956001)(58126008)(65806001)(86362001)(67846002)(36756003)(85426001)(54906003)(83506002)(59450400001)(533714002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2691; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD032; 1:X00UR54HhiQkaMFU9FKc90sWqWp6NN1vWu3xRZO9A36u2SidQYBn1K8uRU/IHw6hRW5hnDQSJdKX257L723PpAH4m54IsbUHpGd1GN1Nrt1t9Riw5KqvhII+n9mZHB9s X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72e79b58-388b-44dd-4097-08d55cc58d23 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:BN6PR03MB2691; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2691; 3:l9mMWz9tbh0QpptdX4/XwKriNo9PZ7y/4mi6ydvMPr73HoMd2f2CtGr7407a1LpZuCnqsgthvUbDnZa9AxaHUa+Bte+KQCmAumcuRFAJESyj77tqKEi+7wPQ/N9GKC5otc/fVj7fZzusPvfdIgF55B2dHk9LNjtoSa5sbXhFHhV7tJFeUek+8ZamGb9JLsE4c5MqCy+bCVeOISzvlsT0u8xOE2i9EEVACDUlfkhA960nLwRermjSw+VdbZW51cmByVqO4oBPOI5SCVGeqCaBmmKmrWegUIjQrtSdGGkM/y71/5isImkrkcc+0Jn+wZ9N9Ic1FRhbRT7yPD/TWAKocPWbKY0TpFAqZ0GtLLIaWaU=; 25:ABwkzuJU28zKQBgZanw0/Ar9yv93t8FNS89ITdoE9bJF/TOcqt8Yhbr79qL4dr6ErL1uHBayuqkleKJXXwmDweqgXchzAEr90JdkyWtWkFybTrRem8jeHtBvdZ0bdT1xtW4kz5L0GxAWiNCee/EbkhUGZYl4h4Rknh/HPIwWW+9x78x34erCs7uAKBrwN9kFBuWjjJ9ddv9NJM2ZiEOgfhhLXtbeO6uWeZ/x8ITuO+K+V0o0mUqyNziSvTH1nbEWWNXgDnc0Mjwa31BYkEGMatMRoFSuA3Em+exY8c6nDWeYh5d9ucWbFiDFFdqMDIqFVZNxSjvIZRjQbUfF/5i7Zw== X-MS-TrafficTypeDiagnostic: BN6PR03MB2691: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2691; 31:onUAkDNiMFl3ZEyTO/1Tacs+4G356uI4fr+dbJvVWZ6SMOK9c68a9QEYhs/xPfblRXSx+Ivamk8dL5wpHgakEnqpSrfUzJpXuaMjGyAShLOyBp3NKtqE/bpKLv6fUCdrfQHTo9v9w1xDabbqmpMS1hucP1wpO7YSMK6Ajf5SieoDo5v+s6Iy8wzSLZegZrCkKlDutP/Z4v2EYNg9Ov91Bjvr9A7f5cEfxTNv7jJ/uOI=; 4:P61bN2IwYh9SQXt8R43w3dBvQVIDMO15aZtaw042v7AnbhllJA1kL8CR8YIba0QJI79iYwGUvwegoK01I9k+sQ4UgqUwvWkaINzZZUVoBpC3lhLhsLkV/qfNWFpoQv2vrkloFd9ug6kA8JnTKRaGCqt3CSrOynxHGJgoEYKCg1NMfuX/koEwc5pOG3+fbzSHUI+98n28TxD8SizvERmMvJ+we5euTwf6rvzfPItaq9IcFEVvd/EWmWqhfAPPTvyVu0D5iMgHLt6LTvXZl91hXBSDkMmWVv5RdN3FeBHi3RHeVOSq+gkKxXbRAD+Ty0jQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3231023)(944501161)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123559100)(20161123565025)(20161123563025)(20161123561025)(20161123556025)(201703131430075)(201703131433075)(201703131448075)(201703151042153)(201708071742011); SRVR:BN6PR03MB2691; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BN6PR03MB2691; X-Forefront-PRVS: 0554B1F54F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNjkxOzIzOklsQ1lEcHdHVGt6ZFJRR1hKbW5vcUtkZGxF?= =?utf-8?B?WDUzRThZUXdKdEppQXZJaHg4Yk11S01adHZ6Sm04bmcvS0pWSy9xeXpnRWZi?= =?utf-8?B?OXVPc3hDMTZTUUc3aWRXMnBNTDNNOHJwOXB4U3dNMWd2ck4wWjlmei83OVVm?= =?utf-8?B?ZlNkSHdBV0RyVDQ0U2Y4clpyVkt5bFQ1ekJKZWZjSEhQTXA1ek5VQmhOU2t1?= =?utf-8?B?cUJ0VUp5MFI0TlpMUnNkNmdnNEN6elo3N3NqNElsWkptM0RkNXZPUVREOWxK?= =?utf-8?B?djRnaVpTaE1ROFV1RG9vYncrTWlUdE9ZMHNreTdqNC9RbGowNXZPUVV5RXhp?= =?utf-8?B?alNUaGFaUEkrOVRrdDlNZnZzZFJaejRkY0ZUVnUvdnpMelhyQ0VicDRHUDZ0?= =?utf-8?B?UmpkUUZhWEk0NnRTUUw0Z3Q2YU5zVlRUcThrTzJMTGJOTFRma1ZndGEwSGZ1?= =?utf-8?B?aEE1U0hLMktxdzRxS2UrSHc3c2pHMk5PZ0ljTy95dVR6Q1BZQ0IzWkxrY1FO?= =?utf-8?B?cTRqUWJmUlNyUUxDRHZHWTRFc1RBQ2U2UTJ1S0tLbVRBL1QySDdodnlzTjJ0?= =?utf-8?B?eDBXZWYxbkV5RnBvMjhzMVpVRkNkRzZ6aGRjZnh2RjlpNXhDVkkyTHI1bGQ2?= =?utf-8?B?NXZXdXpaRWxqY2NlYXBYQTl0YlhieDlicGE5M2tmRnM3OEk5UEEzdW5MTVZQ?= =?utf-8?B?M1pEc0YzNjRCZWhIL0d6bmdBUEpBTFpLbGpJdWNCTUdsNGVyVmJaZU8yRkRC?= =?utf-8?B?TytLL2kvQllJVklIRFlZS0l3Tm11SUJlNkJqMkhzVHNFVHJjYmQ1ZnpseVBt?= =?utf-8?B?eU5aTmU5TndWUmlNNm8xaEErZmFvKzlrU2RmL2Y4eDYrbFFVMTdyOUN6ak81?= =?utf-8?B?R3JOUWFXQlcvU2RBYVBXNG4rQlJ0cHBZYmNxakdLMDN3UFN5WUZqSHAvN1lR?= =?utf-8?B?SmEwamNzRDNRODQyMkdrcUJuTEVTY3FKT2NYZ29mM254WXFnUTBmRmJqSGoy?= =?utf-8?B?TVJ5Y1ErWG5XRTBJUHdhK3RpVTJkQkxBMy84TCtWbm9QdHhaSlllMXp0bDh4?= =?utf-8?B?Y0orMWJNZ0d4Wkl6TUZ2RHFvajlWTTZCQmJXMXdZV3BhM0M2Y1lyWXNzZVcr?= =?utf-8?B?Wml6Mi81MFc2UEs4SnMvcmtENDh5ZGxaay9QQ1hTTUVkWnlDTEY1a3U4WStm?= =?utf-8?B?U2dVajRqM2sxQ2hLMGJPQUVqaWtWbk9sYUpsc1dycjExMjlaWittU1dlWGc3?= =?utf-8?B?U0Q5clZTcm1JbHEzdTlFajNyR3dNL240N3pyYjN5TnhYMm5OSzlpUWJYYVVU?= =?utf-8?B?NFNlYnhiMm5JbktJSTc1QysxSDQyclZBNnRHOUhNZCt2YUtlUVl0SzRVOTI0?= =?utf-8?B?NnJ3UFBycElyTU56QVlpTUJBaUd3Y1NET2tpQTNhZXIrbzFIOGUyOUFNVXVw?= =?utf-8?B?UXh3YWdJZHR3ZzBJdmlvQXNZL3Bxb1pxK216WHVpMHRLNDRQc2FsYXplb05T?= =?utf-8?B?K25Hb01zcjdvQ2QrQmc1U2dHYnR4c3hCWTNZTUZJcXZ4MS9aRXlKbWhrdFhx?= =?utf-8?B?eVY4RG9MQ2NnSlVDYXcxUzBwTFhweDZYd3MxTUJyL0x2WEdKdk5vZ2JPVXAz?= =?utf-8?B?S0JsWVpWNnA0Sk4ycGovVXU1SWZIK25sQVJ3cUtqOVdqalpZdzl1WS9SaDBB?= =?utf-8?B?MmJOZG5OQXVpTDRmVlp5b1ZTMnlyTWQ5c2ZGbWw3VzhjWEpJVXo1Wk40YWxH?= =?utf-8?B?WUNYOEd5U0ROU0ZnWURMRUUxS3daeG1jL1crYWE2cnpja1ZVdStDUFkybDlm?= =?utf-8?B?MEJBOHBVaks1N0Z2RGZsTzlzVkF3L0ExaGJLenFMM2s1YmtlaTZ4NXovZ0ZZ?= =?utf-8?B?R1JQdzFSZytNWHY2Tk4yc1ZEaUl5T2xDc29GUkNVR3BaSlhRS0l3OWM1T1Ju?= =?utf-8?B?ZFB1eUdSdHVqQjFYSTBpa1AzQ3dSVTJFemVsS0pXWUhoWW14SVk3SStxSk5z?= =?utf-8?Q?p/uS4n?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2691; 6:bowA05zCeIIP/WX1dJSwJ2u96FPYS5Lfv5+nD9anpK+laaBNVvo1fziXEo7DmoVMORQYs6rCCMOqU0JrcfAlg08/Hc7/3LuwnKdcpHkQvNjSe36X1kodnXQCF4VR/Fu69i4VIJ3vbiGzHx+d9Ju+DtTrBEMPn5F+E8jJQ3VWwBOsBdgQr37l2/LPBEAxKs5hN+kmdcIVFCu4DWYXsiJVkJnFNYIeZD71IuQJuUt6rR/qgOsdFJ8kJQagQGY8VnI6wwPOnRyIqqFwAvW0f1vwWjBrw2WJbbQ6hbGj331V2hWYsxXCnGGP+R0xaW/wk/Fu4H4duIOKiTEGUM0yqoUvC3C7c1M6gnThwbH5rdtu45w=; 5:L0H8CPIy4Qy8ogJvz7kO8NJPVNK/2DByBQ+TCCOpBf7l6N9vdQTRjmoPJPEEJE4F4JZCt7NziMztBpK/32NPzlhO78ntD8a/X9Wdn+IcuMU9cnsVat/tareJXGsP5L2N51Ojw21cjk2iTFA227efbUgR+uaUrYivvJK9JGY2l38=; 24:m8tlOWSuQUI0/R1f/1KVaWalk5HqieQ4mK0g7GxLlM5yDc1ZYse5XA2y5vzCViuV3bj9U6PgMJAvy2SPlSD+G4OhKCJF1ny1oFaOFudYM7g=; 7:nWfSD+PPo4PGR0ZBhreAkvgY10nMTnnBIVw17KHEqPr4S1vcbOzraH+8fEPWO0noVNZ3wMzeuipIhb3C8AT4QSFb6yxEbhaJWd4bAZHa5ueLof2vrZWeyD8gtSfg2uZVlXybp+vF/4TMtGRk/K8Fjajz+BginGIHJuKV1pxQ2myc7ItGU9X09FdZPm0i32rSp16HepSQmtc45cUXPUkfLyBQplUmuY0GI0oar9/ARL3eJFW1pUAZHM4CZvWsUV/M SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2018 09:43:08.4947 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72e79b58-388b-44dd-4097-08d55cc58d23 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2691 Subject: Re: [dpdk-dev] [PATCH v4 05/15] net/dpaa2: use rte_eth_linkstatus_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 09:43:11 -0000 On Tuesday 16 January 2018 03:14 PM, Shreyansh Jain wrote: > On Thursday 11 January 2018 10:36 PM, Ferruh Yigit wrote: >> From: Stephen Hemminger >> >> Use new helper function to update the link status. >> As a good side effect this fixes a but because this driver was not >                               ^^^^^^ >                           needs rephrasing > >> returning correct status (should be -1 in link_status changed). >> >> Signed-off-by: Stephen Hemminger >> --- >>   drivers/net/dpaa2/dpaa2_ethdev.c | 65 >> +++++----------------------------------- >>   1 file changed, 7 insertions(+), 58 deletions(-) > > Other than the change in commit message highlighted above: > > Acked-by: Shreyansh Jain > > Thanks. > Also, I forgot to add in previous email, I am assuming _rte_eth_linkstatus_get would be rte_eth_linkstatus_get eventually. I concur with your comments in [1] - it certainly would be better to have either @internal or _rte - and not both. http://dpdk.org/ml/archives/dev/2018-January/086742.html