From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id B08D94C99 for ; Tue, 14 Aug 2018 14:09:26 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31F4B5BCD3; Tue, 14 Aug 2018 12:09:26 +0000 (UTC) Received: from [10.36.112.43] (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A467D2026D7E; Tue, 14 Aug 2018 12:09:24 +0000 (UTC) To: Jens Freimann Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com References: <20180808152323.9660-1-maxime.coquelin@redhat.com> <20180808152323.9660-2-maxime.coquelin@redhat.com> <20180810070902.we3jf4xfpbgu5vst@jenstp.localdomain> From: Maxime Coquelin Message-ID: <2004c11d-6c2a-bed5-389d-bd92fee25ed1@redhat.com> Date: Tue, 14 Aug 2018 14:09:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180810070902.we3jf4xfpbgu5vst@jenstp.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 14 Aug 2018 12:09:26 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 14 Aug 2018 12:09:26 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [RFC 1/2] vhost: add packed ring support to vring base requests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 12:09:26 -0000 Hi Jens, On 08/10/2018 09:09 AM, Jens Freimann wrote: > On Wed, Aug 08, 2018 at 05:23:22PM +0200, Maxime Coquelin wrote: >> For consistency with Vhost kernel backend, save the wrap >> counter value into bit 31 of num's vring state field. >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost_user.c | 16 ++++++++++++---- >> 1 file changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/lib/librte_vhost/vhost_user.c >> b/lib/librte_vhost/vhost_user.c >> index a2d4c9ffc..31cfdf163 100644 >> --- a/lib/librte_vhost/vhost_user.c >> +++ b/lib/librte_vhost/vhost_user.c >> @@ -648,10 +648,15 @@ static int >> vhost_user_set_vring_base(struct virtio_net *dev, >>               VhostUserMsg *msg) >> { >> -    dev->virtqueue[msg->payload.state.index]->last_used_idx  = >> -            msg->payload.state.num; >> -    dev->virtqueue[msg->payload.state.index]->last_avail_idx = >> -            msg->payload.state.num; >> +    struct vhost_virtqueue *vq = >> dev->virtqueue[msg->payload.state.index]; >> +    if (dev->features & (1ULL << VIRTIO_F_RING_PACKED)) { >> +        vq->avail_wrap_counter = msg->payload.state.num >> 31; >> +        vq->used_wrap_counter = vq->avail_wrap_counter; > > Maybe I don't understand when this is called, but the wrap counters > could have different values, no? No, because we set the used index to the saved avail index value, so wrap counters must be the same. > Apart from that: > > Reviewed-by: Jens Freimann > regards, > Jens