From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id B5CD22BA7
 for <dev@dpdk.org>; Fri, 20 Jan 2017 11:20:07 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id r126so31046930wmr.0
 for <dev@dpdk.org>; Fri, 20 Jan 2017 02:20:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=7VoeW3xXLw1JQdMQZ1lWS6FqS5JS1pQKRLwLFM6Vurk=;
 b=tT3i772icYi6fqLmbXKXXugC8keNT42KTeFjcVij3/Y6bz0nbWVWwRI7U7+QDTMTVD
 GBS8wq7Vae1YGe4o6zy0ZckRV+9osG4lvJ3XcGwZOKBIxL5lb4+Kh6sA4ilWD1hoZKPM
 EQKpmsIaNsUyVWY/XJIaZWly8GXmDGhnaZqBr0T+JotyDDCpbk2Uqa33uQnOsM1X3kHj
 IqK4VpLVUlPcb+IzHWgLmyYhiy+ngKkCW5yVca4O6T7QzXJGZG9zmI4wB7ZCGebeAV+G
 F5Eew3qKqKxovQ8rc6CIsesA2rdHPVtB4YgTxsRc85jgP+jX9Hg3gZAuTIjenhNGjVCA
 b8Qw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=7VoeW3xXLw1JQdMQZ1lWS6FqS5JS1pQKRLwLFM6Vurk=;
 b=c4GcjXKrL26KXc92A534nUqFnr112kq17fdfGHn6tV4tFOgeP0gVlBS/GYhgZk3TjI
 jTh1UIMKHQbnPzP/49s5Pvr92exKl5i1HSwvt+qcL6Aa1sMjSwGl0n8mpf0wx1rYAWZG
 s/ryayJZpdXe1/6H/mfwhMk+G4vieAiQeBDZbHjkaRjtVCDWSpPB6wBekuLiVJILi7tg
 QTreTm/osE+yAjO5idhBnyEtYZeSkQfFGKtSGVsZdN4+vv4yZxasucDhRP7bMDhz2h0Q
 OKVnqtcLUTd+OA99dC7ZwBcK6CDO/psqdlwPj7/snf0iMWhb5MECWr0xIWvK4H7rTry7
 aT2w==
X-Gm-Message-State: AIkVDXLvQL/MaWtki+HnqdRAxncprvzZMIb9kyZL4NZwP84WXoVO00QlnK8NzXX4oUmDLfew
X-Received: by 10.223.151.99 with SMTP id r90mr10704246wrb.183.1484907607493; 
 Fri, 20 Jan 2017 02:20:07 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id d14sm5084955wmd.19.2017.01.20.02.20.06
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 20 Jan 2017 02:20:07 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Date: Fri, 20 Jan 2017 11:20:06 +0100
Message-ID: <2005966.sVKUI0LeEs@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1484899493-11051-1-git-send-email-yuanhan.liu@linux.intel.com>
References: <1484899493-11051-1-git-send-email-yuanhan.liu@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2017 10:20:07 -0000

2017-01-20 16:04, Yuanhan Liu:
> Fix an silly error by auto-complete while managing the merge conflicts.
> It's the eth_dev_data (but not eth_dev) entry should be memset.
> 
> Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model")

You should describe the impact on this bug.
It will be helpful for those testing the RC1.

> -	memset(&rte_eth_devices[port_id], 0, sizeof(*eth_dev->data));
> +	memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data));

The title should be contain the scope of the bug.
I suggest "fix data reset when allocating port".