From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EB194545B; Fri, 14 Jun 2024 14:48:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2DF1402D3; Fri, 14 Jun 2024 14:48:20 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 29A2140264 for ; Fri, 14 Jun 2024 14:48:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718369299; x=1749905299; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=3hYDyFbG6wFTr4tlDWKGy9xHUfCyrdUU0b94rdLtsmU=; b=MDNNHk1r/Lb8fZV2FEV6Vcl41AQ7mSZiLklGgJ4MQM+CQyVN58/rmvo8 pzBPepQlp/Ec0/X+04lferctIJtYKSXUwv29STJ9Ubpu6fIuamkfZp//i HxY5tVlopE9RqQn6C8FPmvSYGBWCdRCUmII1dAvl2SGSN+MmywNUvRv7M 0+JJnGsHWZUbkslNMYI7uqWICG9CSqymy0BbjCpLhPhAaZvC92fmlcsGf fj8M6tf+hj1rQQDnENqRO5ZfSKI8X9OnRpSSgES0GWamI86VjMnH1UXO0 HeWUvrIIDGn370DZJc4A+eysllAx2yxE/kSE8xFaxfluPk6JuWQcIwEfR A==; X-CSE-ConnectionGUID: DnvHE5mWT0y9UpIvUZdbNg== X-CSE-MsgGUID: NOEsGnpxQJWEReoN04pWSQ== X-IronPort-AV: E=McAfee;i="6700,10204,11103"; a="26648834" X-IronPort-AV: E=Sophos;i="6.08,237,1712646000"; d="scan'208";a="26648834" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2024 05:48:18 -0700 X-CSE-ConnectionGUID: NH8s4FZWT6K58RC6qDJvZg== X-CSE-MsgGUID: oERlVRr1RMiFtsfdrNyFVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,237,1712646000"; d="scan'208";a="40454030" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Jun 2024 05:48:18 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 14 Jun 2024 05:48:17 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 14 Jun 2024 05:48:17 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 14 Jun 2024 05:48:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LX5QTztx23kYCv73QwKLiT/GK2H7XCT2KHLoWxMsIaibW++6Q/L/p+5hMgvhIFfB/iPlXFMHPKg/OtoMhUnS7PzJQMSWuGtgDcmP5md24hX9OqfOOR9fZ8uGir8m8GBN3LrQZ5lrXV/nb18L0bxrhNCJ4jd8toY2fezYaQaId9NiRxlI90qE9LcxB99hA9duuxHdlHOUI0EG9MdMc9YhtbeiSYejOEdWIKTQqPE+zi2Pzq6HbhPb6FyPU4Ye/bmus0Mgw2ojebbp3Co09zyafI/snJwZcQ6DC89i/Oc+yFP0sE7gm9Hoevj2N0PpEYiz8ddiEa6+4kPoVJiApWScCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N9wbCVu/fPnD8VG/OGwBcDqUDN0NOg5kNclAGSVIpyM=; b=jAsrycglsSRbY9htVnQkhe15/U3GbKJIpxDznnJNoyW27KNV8xSlYF57DQ8a4bKXeWFeQxBEuf5O34/jgSdqtCCOtbrJGHQVk7WABw6uwOZMYXBFFfZTizOcK/SxHX2+rfkLY7j1Phfq3jPRv4gvfJv1JF2F+1p2wEPD9Io6dpkS5ZgTwRBOPZ4ltM3wXxYtenpoaZAShd5bCCKnPM+DcP3e2H3+sh5vDG0qHzYPlb++wX2KfL7qyU7HCkLaPzUSmHf7HmZofCBcldFeSLCQcKu6BDuvAHzFNCRkdaF5DJQbBTJFO5g7AcOht9T6aOMJ0FEXb6VWNcuYzY/0giP94A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by DM6PR11MB4737.namprd11.prod.outlook.com (2603:10b6:5:2a2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.24; Fri, 14 Jun 2024 12:48:16 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 12:48:16 +0000 Message-ID: <20059c02-8d73-4609-8100-b6f8aa3da4e8@intel.com> Date: Fri, 14 Jun 2024 14:48:09 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 00/22] Update MEV TS Base Driver To: Soumyadeep Hore , CC: References: <20240604080611.2197835-1-soumyadeep.hore@intel.com> <20240612035257.2245824-1-soumyadeep.hore@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20240612035257.2245824-1-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::27) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|DM6PR11MB4737:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d830e0d-4606-49d9-34d1-08dc8c70426a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bHpUZHFwVWdRS1lrUTFZRnljZnJWdjVuejVFRGNTMkYyblB0TTZzYUJiQWpm?= =?utf-8?B?U21DaXVhbW40MERUaG0vdTdHSGdoOFR4dlJERlFudlJOekp5RWpjUldUTnFh?= =?utf-8?B?VUxWT2VCWnNTQkYrRERQWDJJdXdpOS9qbENqaFVGOFYrTmoydEtQeGhqanNJ?= =?utf-8?B?WjVVTjRFNXg3Y1ZYS01CSHdaNjZrcVlLclhpdjN4WVBxU0ROSTlCck1JK3BN?= =?utf-8?B?RGlVQmlPQTZCMUptRVdoTnpjSkFHc1RrZ2M2eXJVU1dseWNmYldmOGcxellX?= =?utf-8?B?R1F6blVVV1NCSmt0MzFMSndaM2Zmd2VXS1RYc0VEamcrZ3g0QWJKelpGM2I1?= =?utf-8?B?OXFZdEJucE5SNnNCWCtYSW9rTXN0dFVncEpyaGxMTU8zeERFTDVmSUtvS2wz?= =?utf-8?B?OHdOcmxzNGNuQmEyMENBQy93RjYvMkZjWU05eHpYdGJtdmZmL0l3L3hEV0h1?= =?utf-8?B?R01DRk5qcGhOb3pXQXlseExod3RmYjM1TVFTbExyYmJTVXRIaFkwMmc2SHdt?= =?utf-8?B?bzBmUjhHclVRWWZzeFE1ckdiS2NDY1R3YUM0ZU5SY3IrQkFib1haMWhteVhw?= =?utf-8?B?eUlyUWtKajZzNGI3b2ZhQk5VZnlhanVzeG1KWVVReWRsTm1VQTRhWGdZTW5N?= =?utf-8?B?eU91TE80WGcrSC9nOEg5VjUrTUxWRG11Nm9oLzgzWEc4cS9aVy9oYk1ZTjlY?= =?utf-8?B?RGt5SVlpdTdhRHJvS3Z3czEvTWhmM2VXUzM0dGhBOU9HV21aTHh6S3o2K1hy?= =?utf-8?B?ZW5ZaDQ3MnNPcUpjMHd1NHBnZU9tazIvSDh2N3p1NnpLZXYvMjk1L3lPWVZ1?= =?utf-8?B?Tk8wNllZVWU3eUNYU1BIQVlmMjJDcmNxamVOa2NmYmtUd25PRzFaeEtZUnNi?= =?utf-8?B?cjg4eE1XaFFzUGpPOU1weXBDcG82SXlGbS95MkovWldDMDMxRXRUKzhmaWFZ?= =?utf-8?B?c244SG9nMkw1c0lQelJzN3hMNGdpU1ZHbER0QU1aUkxCZFBDRmpFZmV3dUVy?= =?utf-8?B?eldsVUgxQmduMkN0NzVGb0Vjdzlxc1RBSHBXaGJaZnNFSTZvOW9NeENxMFZq?= =?utf-8?B?NWx0U2s5SWdBaXZia3d1ajBhcEEyYTgwMTltSWxQV3NSWWtOc0o5SkpFS0Nn?= =?utf-8?B?RHgwbmdocng3TTA0d25SQU5mRzFsSTIrYVllV2VRaUZ6Y2crL3J6ekV2NENa?= =?utf-8?B?eDF3bTNHaUdHTDB6dGJjdFJFaG5vMWRqYUlqUGErRGNWaHNhYlM3cmlPRExn?= =?utf-8?B?TnJHdEEva09zcUpYcXh2b0Vtb1p3NUM0YnhnbTh1V1Y4R3pjRjFLRjYrdVFa?= =?utf-8?B?Z3kveExnVGFpZDNJamtjR3BmQ2xEVlVpL291M3lKK1FkMGFwdFVOSDJQTU8y?= =?utf-8?B?c0dCUnpwMm1IVkZTbERoRm1tZGZHUjlQeFQxV0dhM3pPK3k2ZzlEWjBIVmdp?= =?utf-8?B?QTVaVWI1b1RHYzFjUGxzdVVMTkwrQSsySk1URDc3QUVqUFBNaGlyVllOMi9x?= =?utf-8?B?dHUvekFZNWtrUWRNdThWdUNKS0FGYTZ0SENvNzBndmhLVVR2OUdyWThUZDB3?= =?utf-8?B?SGVORytJRXQvRkM1b1g5aTcwZTM1YXdNb0ZrcW1FVTJQQ1RJeDZWSGN4a1Na?= =?utf-8?B?NjlKV0diRDg1ZEpiWG9zZHhoZW0xZXhlTUZSb1JNR0ZYTEJsTHRxNFc1SEww?= =?utf-8?B?UzdXaENkZkljMDNkMDhqWTVRZ3RPbWVJdDhiRlNxUXJFUmUzN1p1ZkREMWI1?= =?utf-8?Q?XoeJ0d88vFdtK6NQ3a7UK9yrPafXFsXvBhTPNwE?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTdSRFNCQmFXN0hlMUoxUnh2WXV0d0g5SEhKRXdDcmk1em5vaW1ra0dBdFhL?= =?utf-8?B?T1Ryd2pwQmZkVnlTemxLVU1yeWNkbDQ3TVJwRncyZk4xbUNSTjJNTjJ4VUZi?= =?utf-8?B?a040U3ZqcjY5NkZyNmg1c3J1K2VqcGFFSSs4KzU2L0xjajlIMG10eEQyVm5k?= =?utf-8?B?SHFCek9uUjdaM1haOHZ3Wnl6QVN2Vlh6MEcrR1c5VERkcVVCallTRnVKZXRV?= =?utf-8?B?SDJabHo2ckp1UmpZMFdNckpPeEZ0YW5LQ0xiaWZIOVl6RzQ5TE53ZzFDR3lv?= =?utf-8?B?WW1XbmFTMmhuTEtEd1JRdHkvcnVkb2hSblRJSktrM1BIdEZFQzhjNE04T3FR?= =?utf-8?B?NWlxWHEvQUdhSitZVTRvb1lJNkU1dVpMWW5tUXA1MUZnNlpzQVBvb2ZoMGMw?= =?utf-8?B?Wm1QZ1VTMmZOUnZxWWgrekN5eUt5KzdIWmdCb3lwNzRBbkhWNEUwdmhkcVNV?= =?utf-8?B?NGVRaUd6NHR2NzNTdUpkUTdPdTJUU0xwSjZOdlV4YjNrWVB3TGRxUWxDVElq?= =?utf-8?B?VEtjZnVYdTZzd2Y1b1JQTXNsdGllTTVlYm5ydWpxOWE5MzkrNGxLVUtzZUdV?= =?utf-8?B?OTJkZFUvR3VJOGpUOFJUZXVjZWRaTjlTT0c2cVJCUjdnbWh2SXBZOTNoaUxC?= =?utf-8?B?dHB3TWhSc01zSVRnQ24yT0Y4MldaRXdBRjZ4QktQMGcxUEhDMVZUMnM0RGRP?= =?utf-8?B?R1BYOHdqdDF3TG1SRDdTRTFxcHlscG9MWSszRDI1bmYvVnRYRmhQdVpDUEpT?= =?utf-8?B?Y2xUN3p6b1JYR2J4Y09ad0NXY09jeGhPMzUwR0ltQzA5dWltQkcxeHRJWUMy?= =?utf-8?B?Rk11cE9vbjQ3VHRTTlo2RHkwbzVoNmRxY2xUOWlmN0ZXUjVMRjJoS0hSUHB3?= =?utf-8?B?R24wbFVzZCtXUmd2azdIR0lhck5LVWh3YlpxUDZMaEJBODYwTFR6ak1ORjkz?= =?utf-8?B?YjVFWXk5VzF4aWlXeldKYU5yMDBnbzJLR0s5N3Z5Rk5KOW5nUlVrblJYRmxM?= =?utf-8?B?N3p2Tkw3NWRGemlWRDBMT3NReXdxVUw4UktwMXZHR0d3ZmNOK1dzSzh0M1BT?= =?utf-8?B?VkV4WE1lc0pHMXphaFowMCtsZmc3VjJ6NGFTeEkxRURZUkxocDZpSXZraXJm?= =?utf-8?B?LzEyYmdOcjQyMWxnOGJQVjVWQ3hnb0ZIT0IyMXJxUHIyQTBJUnhjdy92cE9z?= =?utf-8?B?VXMvZ3ZYaUVablVaZlpta2lneitVaW0yMkUyNGNVc3RWeStzMmlkSlFHYi9w?= =?utf-8?B?d3JKb3BBYW9kOUpodWlmYVphOGZmMi8yZDd0VzJsYStpUFdXV3NFMnVPa0FX?= =?utf-8?B?MUNweXVTd2g5V1R2a1NLL1FoT0dZSUhMU0tEVlpDaHkrbE5HbHZ2cVVnMWlw?= =?utf-8?B?MG0yNktPQ2xMN1lMWWlReUMxZ09vajhtZUpVeHdqRDdpeEU4bUsyWlZ2QTk5?= =?utf-8?B?Tk5mWURpczRSWFZiR3F2Z0g1M2k1S1BCQnkyZlZKL0p5eUt0MnpFdXowNGdX?= =?utf-8?B?Z3Q2V0d3T2FGVURFeFlIYzZCT0sveU1rSHY4WS81aHJqWlZkblZYSkJ1WDhm?= =?utf-8?B?NmZYWDNuUERURWVvVHAzaDluSDQ4SDd5dGYvRzRYcmtVM09MZTFYT3dzK2Rj?= =?utf-8?B?VldHU3hyTnpvazIvU3U2TFU5SnVzdzU1cGNUaFFqcVNNVlVSeERqTnY5cEd0?= =?utf-8?B?emtkSnpsL21jWlkyd3JROHhwWjd6bTFuaWM1ZDBqdnVCKzlhcE16Q0J0QTlP?= =?utf-8?B?enQwNW1VV2gvUEMzUzVIUktMaE51RytLQ3Z3aGJXdklsU21CWURrWnNSQTAz?= =?utf-8?B?dTdKcXhJT0E1SkdSMW9FRHNhRWQ0cEV0ZkZoMXpxcW1Sc0cvVnBVOHRLdWs3?= =?utf-8?B?QkVwMVd1UWFnY1didVRrOGNuR3duSTgxbFE2K1c5TE5NKyt0emdGbVdlWHpk?= =?utf-8?B?czRlV2w5YUdMcDhSZUtRRzFMWlBOWEdqUjZ4QkRUZlJ4ZmxVdnI3U3JEdjFX?= =?utf-8?B?YUYwY3lCU1lucVI3QlVkeW9rdUdlbVZURnc2b2JmU0kzeTNCQS9DTEhyZHZz?= =?utf-8?B?SW4vRzdVMlFCN2ZHbk1GbjZaUXhnWDZzZEpwdEJnTWk0MmFaZVcyK205MGNJ?= =?utf-8?B?V0NkS1dHMXRGUHlSNXF2VldoQWRSb1ZIV2Zab25neFNFdEhtV09vNHZrbjNY?= =?utf-8?B?a2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8d830e0d-4606-49d9-34d1-08dc8c70426a X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 12:48:16.1025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MbDGTFcBq+sGCt+VCcdOiC9RMHsLY5LZS2dT9hG3AyrqGkvEy145ZdxujpRVruEYexETA5BSloCRwTOYrNHJno84Bl/oYYVAlgp4rAMZq6w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4737 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: > These patches integrate the latest changes in MEV TS IDPF Base driver. > > --- > v3: > - Removed additional whitespace changes > - Fixed warnings of CI > - Updated documentation relating to MEV TS FW release > --- Off list, I don't know anything about idpf driver, but as far as I'm aware, usually when base code is updated, we resolve all #ifdef's by stripping these tags and assuming that they were (or were not) defined at compile time, so the resulting code is devoid of any compile-time switching. This is the biggest question I have for this review. Is there any reason why you've kept the #ifdef's in this base code update? Should we perhaps strip them out and assume NVME_CPF is always defined? And if not, then perhaps we should at least provide feedback to base driver developers that we'd rather their code handle both cases when NVME_CPF is defined, rather than switching between two different code paths at compile time with no ability to combine them? -- Thanks, Anatoly