* [dpdk-dev] [PATCH] app: fix gcc -O3 compiler errors
@ 2017-08-15 13:53 Keith Wiles
2017-10-04 12:59 ` Burakov, Anatoly
0 siblings, 1 reply; 3+ messages in thread
From: Keith Wiles @ 2017-08-15 13:53 UTC (permalink / raw)
To: dev
When using EXTRA_CFLAGS="-g -O3" in the build the -O3 causes
compiler warnings for these two applications. Using Ubuntu 17.04
gcc compiler.
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
app/proc_info/main.c | 4 +++-
app/test-crypto-perf/cperf_test_verify.c | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/app/proc_info/main.c b/app/proc_info/main.c
index 8b753a2ee..12566e27d 100644
--- a/app/proc_info/main.c
+++ b/app/proc_info/main.c
@@ -524,7 +524,9 @@ nic_xstats_display(uint8_t port_id)
sprintf(buf, "PUTVAL %s/dpdkstat-port.%u/%s-%s N:%"
PRIu64"\n", host_id, port_id, counter_type,
xstats_names[i].name, values[i]);
- write(stdout_fd, buf, strlen(buf));
+ ret = write(stdout_fd, buf, strlen(buf));
+ if (ret < 0)
+ goto err;
} else {
printf("%s: %"PRIu64"\n", xstats_names[i].name,
values[i]);
diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c
index a314646c2..4548e7241 100644
--- a/app/test-crypto-perf/cperf_test_verify.c
+++ b/app/test-crypto-perf/cperf_test_verify.c
@@ -366,6 +366,8 @@ cperf_verify_op(struct rte_crypto_op *op,
auth = 1;
auth_offset = vector->aad.length + options->test_buffer_size;
break;
+ default:
+ return 1;
}
if (cipher == 1) {
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app: fix gcc -O3 compiler errors
2017-08-15 13:53 [dpdk-dev] [PATCH] app: fix gcc -O3 compiler errors Keith Wiles
@ 2017-10-04 12:59 ` Burakov, Anatoly
2017-10-06 22:00 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Burakov, Anatoly @ 2017-10-04 12:59 UTC (permalink / raw)
To: Keith Wiles, dev
On 15-Aug-17 2:53 PM, Keith Wiles wrote:
> When using EXTRA_CFLAGS="-g -O3" in the build the -O3 causes
> compiler warnings for these two applications. Using Ubuntu 17.04
> gcc compiler.
>
> Signed-off-by: Keith Wiles <keith.wiles at intel.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app: fix gcc -O3 compiler errors
2017-10-04 12:59 ` Burakov, Anatoly
@ 2017-10-06 22:00 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-10-06 22:00 UTC (permalink / raw)
To: Keith Wiles; +Cc: dev, Burakov, Anatoly
04/10/2017 14:59, Burakov, Anatoly:
> On 15-Aug-17 2:53 PM, Keith Wiles wrote:
> > When using EXTRA_CFLAGS="-g -O3" in the build the -O3 causes
> > compiler warnings for these two applications. Using Ubuntu 17.04
> > gcc compiler.
> >
> > Signed-off-by: Keith Wiles <keith.wiles at intel.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Rebased and re-targetted to procinfo only as the crypto app
is already fixed by Olivier for -Og compilation.
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-06 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-15 13:53 [dpdk-dev] [PATCH] app: fix gcc -O3 compiler errors Keith Wiles
2017-10-04 12:59 ` Burakov, Anatoly
2017-10-06 22:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).