From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C64671B668 for ; Mon, 16 Oct 2017 12:59:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2750420B7C; Mon, 16 Oct 2017 06:59:02 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 16 Oct 2017 06:59:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=f08+2UC6nZrMrwTwQD6ltqtJjB 1WciaFol/BWMKljwE=; b=iopLqtD1XePHLxWnpz1b+f/b9R8JA9i7Nh4662s3cC X5bdjzXsRLMThKwdlBEzrAH9MTbGkKB7XT16QezwNpV3VmwhCWoqtnyExj1cOVzI XJ2XWzZnK5YidsZejmSBjIQ40uWVSiyLi2WDTek7NeEIGD8RKztiqHA1yzMWF6/l c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=f08+2U C6nZrMrwTwQD6ltqtJjB1WciaFol/BWMKljwE=; b=fI9eXngf7Hj/EqtgfjcTVb G7LPgEA+thmoYmADXMeKwgfKu3D8v/UDCYjXeEUtE84Kck5NRZx3QS5fzXQHo9BU Ftkv4MXl+Cnvv8NUoRY5MNb4jRnGNi++Kv4mBq/a2t9J8iwji9VPpAWhiAP2rCQG v+WyIG3FE4GBaSaL7FVv8Q9N0pGGQQKjWZAA/Ue3PrThVDH62QSn6f+8piKk/n2o 6O4ql26tlDCG+TDoNdfAVNci0fmkKeROLseQHn9kq1dqUp9tTjnPUTEpjidsgXgk qXeS0oRwYuR1y04vEcNxE2yrx1D1+9JeiAJCnZE0wNwJkZp1fMx0WSSy4pgAOMFA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CEC337F961; Mon, 16 Oct 2017 06:59:01 -0400 (EDT) From: Thomas Monjalon To: "Wu, Jingjing" Cc: dev@dpdk.org, "Tan, Jianfeng" Date: Mon, 16 Oct 2017 12:59:00 +0200 Message-ID: <2009183.piveRrLndW@xps> In-Reply-To: References: <1508119093-42500-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 10:59:03 -0000 16/10/2017 12:10, Tan, Jianfeng: > From: Wu, Jingjing > > > > Compile fails when kernel version is <= 3.17 with error: > > "dereferencing pointer to incomplete type". This is because struct > > uio_device definition is not exposed in kernel earlier than 3.17. > > > > This patch fixes it by using pointer of rte_uio_pci_dev as > > dev_id instead of uio_device for irq device handler. > > > > Fixes: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in VM") > > > > Signed-off-by: Jingjing Wu > > > Yes, we don't have to use struct uio_device as the cookie; what we need is struct uio_info for notification. > > Reviewed-by: Jianfeng Tan Applied, thanks