From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6BFA31E35 for ; Thu, 25 Jan 2018 11:48:03 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CB63E21784; Thu, 25 Jan 2018 05:48:02 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 25 Jan 2018 05:48:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=LUaJKWN8VKSPCTGmd3QBYTDn/9 ZMO/bKbqxT0TAoW14=; b=MDBpjORiyeeGfqBrdti23W8w3WWJBMUxlHk9mUcdgY Rnqh7FkF9g4v40oY5Q8KO8E+ZDpX8m56XtR7VGmrKwqKe821xZDc1IHZR3XDO94d 2g+cRMC8YSphUy7vhMZFOCqLgTuZlFcDWyGbUFWEmi33hxGHHca5j5oFBxT9JXsj 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LUaJKW N8VKSPCTGmd3QBYTDn/9ZMO/bKbqxT0TAoW14=; b=PMEBd/RCetUnARiZX5Ywzy ACcs26tDotHkhoVkFPFkB4q4Gcc11ELpxN7E29t8HKB3f19swhc8e1/bxWTppNhK MC1JBPyYa/K5wVgt5DqdDXtSz/1F9nqm9CIby/uHrkZZdDhHyfuFoPyPPJcLU/wW 9Y2/p/R98xmWTU8XQSM2Mv/FoIchIEdweO7EOFWETHmyygHM19UEjkNpFvWRQH8t ChOCKKBjgY4A+CBaF6s0GPN7UXyMp5bcd2hapc+LWpxjWZ3ZmxB8PyfrpjUCwrwY u6hCD2lfX7LHIiU8GnHeeMxMDFlYK+B46QsGmopkYrlCyMHBJ+P2fBLP14bUvplA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 778D7241E0; Thu, 25 Jan 2018 05:48:02 -0500 (EST) From: Thomas Monjalon To: Jianfeng Tan Cc: dev@dpdk.org, anatoly.burakov@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com Date: Thu, 25 Jan 2018 11:47:20 +0100 Message-ID: <2010166.0Q39LqRaO8@xps> In-Reply-To: <1516853783-108023-4-git-send-email-jianfeng.tan@intel.com> References: <1512067450-59203-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-4-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 3/3] vfio: use the generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 10:48:03 -0000 25/01/2018 05:16, Jianfeng Tan: > Previously, vfio uses its own private channel for the secondary > process to get container fd and group fd from the primary process. > > This patch changes to use the generic mp channel. There was a private request to get it in 18.02-rc2. I have 3 concerns: 1/ It is late 2/ It is not yet reviewed by Anatoly and Konstantin 3/ We try to not rework the existing code in RC2, because it would totally invalidate the validation work done for RC1.