From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EBC2A37A6
 for <dev@dpdk.org>; Fri, 30 Jun 2017 14:54:11 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 85E6A209F7;
 Fri, 30 Jun 2017 08:54:11 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Fri, 30 Jun 2017 08:54:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=14fzNxrEfkMfcme
 ZpeNxQ+wz8758i8hG4RQAn67uXRw=; b=ZgYRDBOjbQGf03sdaMbg7gWCE2lnzUP
 j2CFoMeT0b1pCNmgIKXnrf7ZAnDCKspD55Swq4NIACt6bB088qSpC++kQzqH7vO+
 zs0plkNKbgKeiwlBXpWR0bQRzSjNs4n+upEVli92lcMdbYy9HZiB8ouVHBnt5qVi
 KsypYpLf2/a4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=14fzNxrEfkMfcmeZpeNxQ+wz8758i8hG4RQAn67uXRw=; b=HuC7N2AL
 /55q4Y8ceD0lxWOjkUvI2bgsSO0QEynKpR9EfHefLDvwCQvkcQABM4rKe50GMIjt
 fJTlIamql17ajbFurzf4jRsTHaO5dbwGGlebffQ2zuNuT0B3xOg+wAlSrgBuwR3I
 Lat0SLPnZ0ss1wsdbZS886HZP4EKOySKOuLyyvp6tiGOD9/dTCJReooHCa7wlbW1
 ghOolmr5e7iPfjVzSCVvUxWiVmYhSJiBUqslceT2dUzrePXG8DmRMFMNhhNWOWdA
 xXgDM5PFsrGCoNMGyw7M87rshOkvdf4okiuh6IaSAXjVD2ViFTFDnKFuCSn0CtEh
 TKFsFXn06nCHPA==
X-ME-Sender: <xms:80lWWRNn2hGxYkscqAi1EJrAdqY4VdpnwiHvfJzI2aP9FnkJFThQ2w>
X-Sasl-enc: yiC7PncYbz/rPnIUW3DAr8Xhubp5HjAgIws8SjpG7S8L 1498827251
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 3E3287E51B;
 Fri, 30 Jun 2017 08:54:11 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com
Date: Fri, 30 Jun 2017 14:54:10 +0200
Message-ID: <2011189.8JlBii0GeG@xps>
In-Reply-To: <20170629182206.1072-14-jblunck@infradead.org>
References: <cover.1498577192.git.gaetan.rivet@6wind.com>
 <20170629182206.1072-1-jblunck@infradead.org>
 <20170629182206.1072-14-jblunck@infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 13/15] eal: add hotplug add/remove
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jun 2017 12:54:12 -0000

It seems a function is missing in this patch:

29/06/2017 20:22, Jan Blunck:
> +int rte_eal_hotplug_add(const char *busname, const char *devname,
> +			const char *devargs)
> +{
> +	struct rte_bus *bus;
> +	struct rte_device *dev;
> +	int ret;
> +
> +	bus = rte_bus_find_by_name(busname);
> +	if (!bus) {
> +		RTE_LOG(ERR, EAL, "Cannot find bus (%s)\n", busname);
> +		return -ENOENT;
> +	}
> +
> +	if (!bus->plug) {
> +		RTE_LOG(ERR, EAL, "Function plug not supported by bus (%s)\n",
> +			bus->name);
> +		return -ENOTSUP;
> +	}
> +
> +	ret = bus->scan();
> +	if (ret)
> +		return ret;
> +
> +	dev = bus->find_device(NULL, cmp_detached_dev_name, devname);

fatal error: use of undeclared identifier 'cmp_detached_dev_name'