From: Thomas Monjalon <thomas@monjalon.net>
To: "Varghese, Vipin" <vipin.varghese@intel.com>
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Byrne, Stephen1" <stephen1.byrne@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/service_cores: check lcores before test run
Date: Mon, 29 Oct 2018 03:06:27 +0100 [thread overview]
Message-ID: <2011444.UUVssWKW1k@xps> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA65E2EEBE5@IRSMSX102.ger.corp.intel.com>
17/10/2018 16:57, Van Haaren, Harry:
> From: Varghese, Vipin
> >
> > The service core samples has varied profiles created to run on specified
> > lcore count. The patch adds the check before each run, to ensure
> > example has sufficent lcores to be added as service cores on given run
> > profile. If sufficent cores are not found, the run is skipped with user
> > notification.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
>
> The +1 feels weird, but given there's a core offset of 1 above,
> this seems like the best solution:
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-10-29 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 13:14 Vipin Varghese
2018-10-17 14:57 ` Van Haaren, Harry
2018-10-29 2:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2011444.UUVssWKW1k@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=stephen1.byrne@intel.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).