From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 2D79D6ADF for ; Tue, 16 Apr 2013 17:11:57 +0200 (CEST) Received: by mail-wg0-f46.google.com with SMTP id e11so592790wgh.13 for ; Tue, 16 Apr 2013 08:11:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id:x-gm-message-state; bh=U3JY1IlCBYdc+z8ERNbFB7DS/7xjXlnLKRcmXUQrfGE=; b=U7M+FJ6brXpYdEx2/FxhTANdQstQ79nYu4+0PMDQncBQ8NHNALyyqFkA7DfWAUwiy4 8r6edxvasZuTPW29m0yBim04t071yHVOMizYzlQbJDBwSU/lGEhX7fROPVizElZJZDMC 8XhpOTRmUO+xXc0sIXfzy5JVpTPnloHu4MrT+zNZkscHdWPoYCU+Ro9bPU+ncYE8hl8M QYL/m6cZNLeeyniX3EHjbj3tUfu1x/V88hzXjIeHpvm6NZB0Ds/+s8eO9cY+IDMzYX0Z cFW+CUAxNzfbBa0dJLuPYL6UuhsAR+Gbi61JoA0mpZC3DAnVDVKE+A8OTR50qTLfvmmR XKqQ== X-Received: by 10.194.177.200 with SMTP id cs8mr4739941wjc.22.1366125062569; Tue, 16 Apr 2013 08:11:02 -0700 (PDT) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPS id k5sm3593945wiy.5.2013.04.16.08.11.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 16 Apr 2013 08:11:01 -0700 (PDT) From: Thomas Monjalon Organization: 6WIND To: Julien Courtat Date: Tue, 16 Apr 2013 17:11:01 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <1366101108-14177-1-git-send-email-julien.courtat@6wind.com> In-Reply-To: <1366101108-14177-1-git-send-email-julien.courtat@6wind.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201304161711.01205.thomas.monjalon@6wind.com> X-Gm-Message-State: ALoCoQmRpMROvrHH5dG1uOuRi5EuWBlguA3Wh9Am6RXXQCfOvd+j2d0HNY8ez9NdrZwwAgVSXXdX Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pci: fix probing blacklisted device with RTE_PCI_DRV_MULTIPLE flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2013 15:11:57 -0000 pushed, thanks ! 16/04/2013 10:31, Julien Courtat : > When blacklisting network adapters that share a PCI bus address with multiple > ports such as Mellanox ConnectX-3 (librte_pmd_mlx4), RTE applications > enter infinite loops while probing PCI devices. > > This commit removes this probe on subsequent instances for blacklisted devices > that have RTE_PCI_DRV_MULTIPLE set. > > Acked-by: Adrien Mazarguil > Signed-off-by: Julien Courtat > --- > lib/librte_eal/common/eal_common_pci.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c > index 3a6ab70..4e1a944 100644 > --- a/lib/librte_eal/common/eal_common_pci.c > +++ b/lib/librte_eal/common/eal_common_pci.c > @@ -91,9 +91,11 @@ pci_probe_all_drivers(struct rte_pci_device *dev) > if (rte_eal_pci_probe_one_driver(dr, dev)) > continue; > /* initialize subsequent driver instances for this device */ > - if (dr->drv_flags & RTE_PCI_DRV_MULTIPLE) > + if ((dr->drv_flags & RTE_PCI_DRV_MULTIPLE) && > + (!dev->blacklisted)) { > while (rte_eal_pci_probe_one_driver(dr, dev) == 0) > ; > + } > return 0; > } > return -1;