From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-x22c.google.com (mail-ea0-x22c.google.com [IPv6:2a00:1450:4013:c01::22c]) by dpdk.org (Postfix) with ESMTP id CD67F234 for ; Mon, 3 Jun 2013 18:28:54 +0200 (CEST) Received: by mail-ea0-f172.google.com with SMTP id g14so1419206eak.17 for ; Mon, 03 Jun 2013 09:29:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id:x-gm-message-state; bh=Ko8/r3A1/3sbmN1YjAzu1smDYwmP9TDFTQvhrXPkNeo=; b=gddRLEp1a28ARbnhBMVDgEWR5GWnqTqs6gt0KZkaMg7SN0jmhAXGqoLRADd1KrbPjw YgamGUtimTOjHZ/quxwpKNW8zIpBY8TUuLp9weLfbGs3T5AEZmaF9jflMTdc8h5vMBza LPV5kUCzeABqRhcQzfy2D6tgZfeJrwMqXFLIzsTCS95OUW2FzXwAX8jRSvcJIRWaONj2 rbLna0NyW7MXXmP95SgFAlh0F5v0tdcQP/vekDQ1jWuRPo6xtOuVnIUFLHzMJdnWwHQw oJZto76E9ujtKHiyjc94HB+BgRJPfzQx7GYxikzrfOfx4r8OmZpAWSC+3B4DQW5BolOE 161A== X-Received: by 10.14.122.135 with SMTP id t7mr23572152eeh.141.1370276941788; Mon, 03 Jun 2013 09:29:01 -0700 (PDT) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id bo9sm71996940eeb.9.2013.06.03.09.28.59 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Jun 2013 09:29:00 -0700 (PDT) From: Thomas Monjalon Organization: 6WIND To: Antti Kantee Date: Mon, 3 Jun 2013 18:29:02 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <20130530171234.301927271@vyatta.com> <51AC5A99.1050207@6wind.com> <51ACBF95.1030109@iki.fi> In-Reply-To: <51ACBF95.1030109@iki.fi> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201306031829.02984.thomas.monjalon@6wind.com> X-Gm-Message-State: ALoCoQlDKq4mT32TWdqcMg2j/UmeI2wPCS/R42JQPsB2zKz5wzuYFUIZqPVgo5JnA1pMxsWrvqPq Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 4/7] eal: support different modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2013 16:28:55 -0000 03/06/2013 18:08, Antti Kantee : > On 03.06.2013 10:58, Damien Millescamps wrote: > >> -/** Device needs igb_uio kernel module */ > >> -#define RTE_PCI_DRV_NEED_IGB_UIO 0x0001 > >> > >> /** Device driver must be registered several times until failure */ > >> > >> -#define RTE_PCI_DRV_MULTIPLE 0x0002 > >> +#define RTE_PCI_DRV_MULTIPLE 0x0001 > > > > You are breaking a public API here, and I don't see any technical reason > > to do so. The RTE_PCI_DRV_NEED_IGB_UIO flag could be deprecated, but > > there is no way its value could be recycled into an already existing > > flag. > > Is breaking the API a bad thing in this context? IMHO the > initialization APIs need work before they're general enough and > perpetually supporting the current ones seems like an unnecessary > burden. I'm trying to understand the general guidelines of the project. > > (and nittily, recycling flag values is fine for static-only libs as long > as you remove the old macro, but of course removal is the API breakage > you mentioned) Yes, DPDK is a young project but breaking API should be always justified. In this case it is not mandatory to change it. -- Thomas