From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com
 [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 1DEC2532D
 for <dev@dpdk.org>; Wed,  5 Jun 2013 17:49:23 +0200 (CEST)
Received: by mail-pd0-f169.google.com with SMTP id y10so2031824pdj.28
 for <dev@dpdk.org>; Wed, 05 Jun 2013 08:49:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer
 :mime-version:content-type:content-transfer-encoding
 :x-gm-message-state;
 bh=E/neXSQ9dx3iDOJT2G4wiosiPnGE9GRSm1mQ2ocPgIw=;
 b=KtsLDisfBgF/kKaMBZ48uLq0GMgWkoSM3sID2QpxFiXIy2YcuVHX+E1ArnSc+OZT2j
 5w1OfZ2KOL5/8b40WrnPueknF7GXlyHvMY2ow/PhWbxqbXMYCoquvIkWgp0iPtWRlD+e
 KUWU3Ad4PL3JHBPtzCzDV9HsqUEPrcOf9B3eC3tLWU/i0PKVppN+MG4XdEPIaskaA/a1
 sCYWZECR6GwVlMbiVGz6j73J5/FhWxH33zuYkYk1mbSx7Oa/ngseBekBiln/Wn6iLxsO
 YCoiH7SI1IvMDRHyjYIyiBjVqqs+6Qa9G1llT1+2eyDA1dpd3/+h5WGOAMDx9Phuhq46
 a0HQ==
X-Received: by 10.66.190.104 with SMTP id gp8mr35616319pac.84.1370447371257;
 Wed, 05 Jun 2013 08:49:31 -0700 (PDT)
Received: from nehalam.linuxnetplumber.net
 (static-50-53-71-109.bvtn.or.frontiernet.net. [50.53.71.109])
 by mx.google.com with ESMTPSA id xu10sm73246164pab.3.2013.06.05.08.49.30
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Wed, 05 Jun 2013 08:49:30 -0700 (PDT)
Date: Wed, 5 Jun 2013 08:49:27 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Damien Millescamps <damien.millescamps@6wind.com>
Message-ID: <20130605084927.34f138c1@nehalam.linuxnetplumber.net>
In-Reply-To: <51AF501B.5060306@6wind.com>
References: <20130530171234.301927271@vyatta.com>
 <20130530171627.005239011@vyatta.com> <51AF501B.5060306@6wind.com>
X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQkoGFXr3nlxKB9mHkWe/iKpk9AumLFOPL8TnIxJflotnfIH/JHgF0ByTdd8Uo43TbR6V3yX
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/7] pci: support multiple PCI regions per
 device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2013 15:49:24 -0000

On Wed, 05 Jun 2013 16:50:03 +0200
Damien Millescamps <damien.millescamps@6wind.com> wrote:

> Hi Stephen,
> 
> Overall this patch is very nice. My only comment on this one is why do
> you limit the max number of memory resources to 5 ?
> The PCI configuration space permits to store up to 6 base addresses.
> 
> > +#define PCI_MEM_RESOURCE 5
> 
> Please, can you add a log/comment with your patch, too ?
> 
> 
> Cheers,

Only because I was trying to save some space, and I didn't see any hardware
with that many useful regions. Also the kernel UIO driver has some control
over which regions get exposed.