From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9B86F2C5; Tue, 7 Aug 2018 15:41:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E2CB221BE6; Tue, 7 Aug 2018 09:41:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 07 Aug 2018 09:41:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=LA/HowhUt1ixHwO66a6G28mUQW FLM6FjuCxql1DFAU8=; b=kNPUPZPgRF1MqfseFRrNaWR+MefyTCrsuxaitWZnvi mVWQT+AacHbjksbLreJVdki8bs0tdfhiFQVlnQ/Cs1f13FAGyNc//bo1wSSds1Ws TPOR/kdSJpwvHRqHe/J1WQrFf2vVeFdnpIWLlScX8Z6sTIO+qV7RaEPzaQfF4vkf A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=LA/How hUt1ixHwO66a6G28mUQWFLM6FjuCxql1DFAU8=; b=SI0oSkRFepi11NnYBJ6fOS q9qfujC1BizwUIsVwDHJqlPRNfqth0S9uwtvLB6x4I3AfU3ipEPtTXVJTVPYQjUr ezYZbcI+CMrv5Z6H6OZ31Esb9dU+9JwSKk+JRj0ux32HbN+xPscfhz2ThPm4gUk8 pGNxbj1FjXraXXo6sijsZ8tXSk4q1JgIQIDPcV9Gx2JJefhgI8xskfkVQqhKjg99 /8oMjavtQ4cxqbW7BNj/lk6viN1Em3Rshw+gswrcEn99BH312x4wMZLl6V9KgE1N bWskLSAMmcz/bZrELbFalCVhs+2ijF+oT91Z9WQEsXSIPkvoE6OHogrClr8Xoi4A == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (91.198.136.77.rev.sfr.net [77.136.198.91]) by mail.messagingengine.com (Postfix) with ESMTPA id 88C20E48A9; Tue, 7 Aug 2018 09:41:49 -0400 (EDT) From: Thomas Monjalon To: Pablo de Lara Cc: dev@dpdk.org, bruce.richardson@intel.com, stable@dpdk.org, Petr Houska Date: Tue, 07 Aug 2018 15:41:45 +0200 Message-ID: <2013436.7W4QKxfn50@xps> In-Reply-To: <20180807020004.9218-1-pablo.de.lara.guarch@intel.com> References: <20180807020004.9218-1-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] hash: fix Doxygen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Aug 2018 13:41:52 -0000 07/08/2018 04:00, Pablo de Lara: > rte_hash_lookup_data() and rte_hash_lookup_with_hash_data() > functions return the index of the table where the key is stored > when this is found, and not 0 as the Doxygen currently states. > > Also, these functions, and rte_hash_get_key_with_position() > return negative values when keys are not found (-EINVAL and -ENOENT), > where the minus sign was missing. > > Fixes: 473d1bebce43 ("hash: allow to store data in hash table") > Fixes: 6dc34e0afe7a ("hash: retrieve a key given its position") > Cc: stable@dpdk.org > > Reported-by: Petr Houska > Signed-off-by: Pablo de Lara Bugzilla ID: 78 Applied, thanks