[dpdk-dev] [dpdk-announce] [HELP REQUIRED] call for reviews

[dpdk-dev] [dpdk-announce] [HELP REQUIRED] call for reviews

[Thomas Monjalon]

Hi all,

Our next milestone is approaching, 20.08-rc1 should be in 12 days :
	http://core.dpdk.org/roadmap/#dates
and the roadmap is very long:
	http://core.dpdk.org/roadmap/#2008

We all want to have our code reviewed and accepted.
In order to have a small hope of reaching our goals,
we need a large participation in reviews.

PLEASE REVIEW some patches from the list below.

If you need a breath between two reviews,
please enjoy a satifying video from https://twitter.com/engineers_feed
Now that you are ready, here is the list to cherry-pick from:

- introduce global debug flag
  http://inbox.dpdk.org/dev/20200422214555.11837-1-l.wojciechow@partner.samsung.com/

- one more step in makefiles deprecation
  http://inbox.dpdk.org/dev/20200625214338.1838457-1-thomas@monjalon.net/

- Experimental/internal libraries cleanup
  http://inbox.dpdk.org/dev/20200626081638.29890-1-david.marchand@redhat.com/

- rename blacklist/whitelist to block/allow
  http://inbox.dpdk.org/dev/20200613000055.7909-1-stephen@networkplumber.org/

- Change references to master/slave
  http://inbox.dpdk.org/dev/20200605225811.26342-1-stephen@networkplumber.org/

- plugin loading
  http://inbox.dpdk.org/dev/20200622143337.562637-1-bruce.richardson@intel.com/

- rte init framework
  http://inbox.dpdk.org/dev/1586787714-13890-1-git-send-email-xiangxia.m.yue@gmail.com/

- Register non-EAL threads as lcore
  http://inbox.dpdk.org/dev/20200626144736.11011-1-david.marchand@redhat.com/

- rte_log registration usage improvement
  http://inbox.dpdk.org/dev/20200617063047.1555518-1-jerinj@marvell.com/

- EAL resources cleanup
  http://inbox.dpdk.org/dev/20200428235827.15383-1-stephen@networkplumber.org/

- proc-info cleanup
  http://inbox.dpdk.org/dev/20200506195758.27057-1-stephen@networkplumber.org/

- PRNG compat
  http://inbox.dpdk.org/dev/20200422234255.7066-1-dg@adax.com/

- malloc debug
  http://inbox.dpdk.org/dev/1587110623-405-1-git-send-email-xuemingl@mellanox.com/#t

- ring: make ring implementation non-inlined
  http://inbox.dpdk.org/dev/20200320164138.8510-1-konstantin.ananyev@intel.com/

- ring: add scatter gather and serial dequeue APIs 
  http://inbox.dpdk.org/dev/20200224203931.21256-1-honnappa.nagarahalli@arm.com/

- mempool ring + HTS
  http://inbox.dpdk.org/dev/20200521132027.28219-1-konstantin.ananyev@intel.com/

- Use of WFE in ring and spinlock
  http://inbox.dpdk.org/dev/20200426083909.897-1-gavin.hu@arm.com/

- x86 only IO API
  http://inbox.dpdk.org/dev/1592568380-27120-1-git-send-email-radu.nicolau@intel.com/

- eal: use c11 atomics for interrupt status
  http://inbox.dpdk.org/dev/1591871065-12461-2-git-send-email-phil.yang@arm.com/

- mbuf: use c11 atomics for refcnt operations
  http://inbox.dpdk.org/dev/1591871178-12542-1-git-send-email-phil.yang@arm.com/

- mbuf: accurate packet Tx scheduling
  http://inbox.dpdk.org/dev/1591771085-24959-1-git-send-email-viacheslavo@mellanox.com/

- mbuf: add Tx offloads for packet marking
  http://inbox.dpdk.org/dev/20200417072254.11455-1-nithind1988@gmail.com/

- add new kv hash table
  http://inbox.dpdk.org/dev/cover.1588967562.git.vladimir.medvedkin@intel.com/

- TCP flow classification using 4-tuple and flags
  http://inbox.dpdk.org/dev/cover.1578936382.git.sowmini.varadhan@microsoft.com/

- fib + AVX512
  http://inbox.dpdk.org/dev/cover.1589890262.git.vladimir.medvedkin@intel.com/

- RCU integration in LPM
  http://inbox.dpdk.org/dev/20200608051658.144417-1-ruifeng.wang@arm.com/

- compile librte_net for windows
  http://inbox.dpdk.org/dev/20200610120040.17968-1-fady@mellanox.com/

- Windows bus/pci support
  http://inbox.dpdk.org/dev/20200624082847.21344-1-talshn@mellanox.com/

- cmdline: support Windows
  http://inbox.dpdk.org/dev/20200620210511.13134-1-dmitry.kozliuk@gmail.com/

- ethdev: verify reserved HW ring
  http://inbox.dpdk.org/dev/20200624093520.2142722-1-ferruh.yigit@intel.com/

- ethdev: allow unknown link speed
  http://inbox.dpdk.org/dev/20200615090158.18912-1-i.dyukov@samsung.com/

- Power-optimized RX for Ethernet devices
  http://inbox.dpdk.org/dev/cover.1590598121.git.anatoly.burakov@intel.com/

- ethdev: add rte_device to port_id function 
  http://inbox.dpdk.org/dev/a62bdf6dad57737ffc169e1d2d6717efdec9436d.1587142035.git.grive@u256.net/

- add flow action map
  http://inbox.dpdk.org/dev/1591194009-4086-1-git-send-email-bernard.iremonger@intel.com/

- add flow action context API
  http://inbox.dpdk.org/dev/20200620133231.12355-1-andrey.vesnovaty@gmail.com/

- support the flow-based traffic sampling
  http://inbox.dpdk.org/dev/1593102379-400132-1-git-send-email-jiaweiw@mellanox.com/

- ethdev: tunnel offload model 
  http://inbox.dpdk.org/dev/20200625160348.26220-1-getelson@mellanox.com/

- Introduce flow perf application
  http://inbox.dpdk.org/dev/20200604133502.28491-1-wisamm@mellanox.com/

- Introduce IF proxy library
  http://inbox.dpdk.org/dev/20200622092128.3560-1-aostruszka@marvell.com/

- add support for DOCSIS protocol
  http://inbox.dpdk.org/dev/20200623101423.9215-1-david.coyle@intel.com/

- RegEx
  http://inbox.dpdk.org/dev/1588844756-10086-1-git-send-email-orika@mellanox.com/
  http://inbox.dpdk.org/dev/1591219752-46544-1-git-send-email-orika@mellanox.com/

Re: [dpdk-dev] [dpdk-announce] [HELP REQUIRED] call for reviews

[Or Gerlitz]

On Fri, Jun 26, 2020 at 7:43 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> Our next milestone is approaching, 20.08-rc1 should be in 12 days :
>         http://core.dpdk.org/roadmap/#dates
> and the roadmap is very long:
>         http://core.dpdk.org/roadmap/#2008
>
> We all want to have our code reviewed and accepted.
> In order to have a small hope of reaching our goals,
> we need a large participation in reviews.
>
> PLEASE REVIEW some patches from the list below.
[..]

Hi Thomas,

Wanted to check re the flow perf application which AFAIK almost made it
for 20.05 but now is still waiting in patchworks [1]. I am using it and actually
there are few enhancements to be applied for serving more advanced use-cases
waiting for the initial acceptance to be submitted. I am politely
watching it in patchworks
without any real progress for couple of weeks.. so?

Thanks,

Or.

[1] https://patchwork.dpdk.org/cover/70851/

Re: [dpdk-dev] [dpdk-announce] [HELP REQUIRED] call for reviews

[Kevin Traynor]

On 01/04/2020 02:29, Thomas Monjalon wrote:
> Hi,
> 
> DPDK 20.05-rc1 is planned to be released in less than three weeks.
> This is challenging because some patches are missing reviews.
> 
> We all want to have our code reviewed and accepted.
> It will happen if everybody take time to read ideas,
> comment the designs and review the implementations.
> 
> Before starting, do not hesitate to prepare yourself comfortably:
>     https://www.jango.com/browse_music
> 
> Below are some suggested readings, please pick one or more in the list:
> 
>     - gcc 10 support
>       http://inbox.dpdk.org/dev/20200325141137.7088-1-ktraynor@redhat.com/

Also this one from Gavin,
http://inbox.dpdk.org/dev/20200307155629.45021-1-gavin.hu@arm.com/

> 
>     - clean-up compiler hint attributes
>       http://inbox.dpdk.org/dev/20200210162032.1177478-1-thomas@monjalon.net/
> 
>     - data type for AVX512
>       http://inbox.dpdk.org/dev/1583757826-375246-2-git-send-email-vladimir.medvedkin@intel.com/
> 
>     - helpers for bit operations
>       http://inbox.dpdk.org/dev/20200309095410.28983-2-joyce.kong@arm.com/
> 
>     - C11 atomics
>       http://inbox.dpdk.org/dev/1584407863-774-2-git-send-email-phil.yang@arm.com/
>       http://inbox.dpdk.org/dev/a6df56db-b0d3-2e45-c872-1f3eb54b1aad@ericsson.com/
> 
>     - ring enhancemements
>       http://inbox.dpdk.org/dev/20200331164330.28854-1-konstantin.ananyev@intel.com/
>       http://inbox.dpdk.org/dev/20200224203931.21256-1-honnappa.nagarahalli@arm.com/
>       http://inbox.dpdk.org/dev/2445314.H8VbNj7W2P@xps/
> 
>     - basic memory management for Windows
>       http://inbox.dpdk.org/dev/20200330041026.784624-1-dmitry.kozliuk@gmail.com/
> 
>     - cleanup more resources on shutdown
>       http://inbox.dpdk.org/dev/20200104013341.19809-1-stephen@networkplumber.org/
> 
>     - probing control
>       http://inbox.dpdk.org/dev/2593334.B0Pyx7erxp@xps/
> 
>     - ethdev close behaviour and usage
>       http://inbox.dpdk.org/dev/1913442.o4kTbAZ4gJ@xps/
> 
>     - vectorize virtio packed ring datapath
>       http://inbox.dpdk.org/dev/20200327165412.87359-1-yong.liu@intel.com/
> 
>     - clean-up NIC features matrix in documentation
>       http://inbox.dpdk.org/dev/20200311230136.63452-1-thomas@monjalon.net/
> 
>     - fixes and tests for rte_security
>       http://inbox.dpdk.org/dev/20200312151654.7218-1-l.wojciechow@partner.samsung.com/
> 
>     - nodes graph as packet processing pipeline
>       http://inbox.dpdk.org/dev/20200331192945.2466880-1-jerinj@marvell.com/
> 
>     - telemetry rework
>       http://inbox.dpdk.org/dev/20200319171907.60891-1-ciara.power@intel.com/
> 
>     - tracepoints compatible with LTTng
>       http://inbox.dpdk.org/dev/20200329144342.1543749-1-jerinj@marvell.com/
> 
>     - internal symbol marking
>       http://inbox.dpdk.org/dev/1929042.qExNQAuVzC@xps/
> 
> 
> And to prepare next releases, some design discussions need to progress:
> 
>     - VFIO token for PF
>       http://inbox.dpdk.org/dev/20200305043311.17065-1-vattunuru@marvell.com/
> 
>     - IF proxy
>       http://inbox.dpdk.org/dev/20200310111037.31451-1-aostruszka@marvell.com/
> 
>     - ethdev capabilities and feature enabling
>       http://inbox.dpdk.org/dev/13121897.9FIjf2LrnR@xps/
>       http://inbox.dpdk.org/dev/8032312.HfnmF1KY9p@xps/
>       http://inbox.dpdk.org/dev/20200319075851.GA26440@chelsio.com/
> 
> 
> Thanks a lot for helping releases to happen!
> 
> 

[dpdk-dev] [dpdk-announce] [HELP REQUIRED] call for reviews

[Thomas Monjalon]

Hi,

DPDK 20.05-rc1 is planned to be released in less than three weeks.
This is challenging because some patches are missing reviews.

We all want to have our code reviewed and accepted.
It will happen if everybody take time to read ideas,
comment the designs and review the implementations.

Before starting, do not hesitate to prepare yourself comfortably:
    https://www.jango.com/browse_music

Below are some suggested readings, please pick one or more in the list:

    - gcc 10 support
      http://inbox.dpdk.org/dev/20200325141137.7088-1-ktraynor@redhat.com/

    - clean-up compiler hint attributes
      http://inbox.dpdk.org/dev/20200210162032.1177478-1-thomas@monjalon.net/

    - data type for AVX512
      http://inbox.dpdk.org/dev/1583757826-375246-2-git-send-email-vladimir.medvedkin@intel.com/

    - helpers for bit operations
      http://inbox.dpdk.org/dev/20200309095410.28983-2-joyce.kong@arm.com/

    - C11 atomics
      http://inbox.dpdk.org/dev/1584407863-774-2-git-send-email-phil.yang@arm.com/
      http://inbox.dpdk.org/dev/a6df56db-b0d3-2e45-c872-1f3eb54b1aad@ericsson.com/

    - ring enhancemements
      http://inbox.dpdk.org/dev/20200331164330.28854-1-konstantin.ananyev@intel.com/
      http://inbox.dpdk.org/dev/20200224203931.21256-1-honnappa.nagarahalli@arm.com/
      http://inbox.dpdk.org/dev/2445314.H8VbNj7W2P@xps/

    - basic memory management for Windows
      http://inbox.dpdk.org/dev/20200330041026.784624-1-dmitry.kozliuk@gmail.com/

    - cleanup more resources on shutdown
      http://inbox.dpdk.org/dev/20200104013341.19809-1-stephen@networkplumber.org/

    - probing control
      http://inbox.dpdk.org/dev/2593334.B0Pyx7erxp@xps/

    - ethdev close behaviour and usage
      http://inbox.dpdk.org/dev/1913442.o4kTbAZ4gJ@xps/

    - vectorize virtio packed ring datapath
      http://inbox.dpdk.org/dev/20200327165412.87359-1-yong.liu@intel.com/

    - clean-up NIC features matrix in documentation
      http://inbox.dpdk.org/dev/20200311230136.63452-1-thomas@monjalon.net/

    - fixes and tests for rte_security
      http://inbox.dpdk.org/dev/20200312151654.7218-1-l.wojciechow@partner.samsung.com/

    - nodes graph as packet processing pipeline
      http://inbox.dpdk.org/dev/20200331192945.2466880-1-jerinj@marvell.com/

    - telemetry rework
      http://inbox.dpdk.org/dev/20200319171907.60891-1-ciara.power@intel.com/

    - tracepoints compatible with LTTng
      http://inbox.dpdk.org/dev/20200329144342.1543749-1-jerinj@marvell.com/

    - internal symbol marking
      http://inbox.dpdk.org/dev/1929042.qExNQAuVzC@xps/


And to prepare next releases, some design discussions need to progress:

    - VFIO token for PF
      http://inbox.dpdk.org/dev/20200305043311.17065-1-vattunuru@marvell.com/

    - IF proxy
      http://inbox.dpdk.org/dev/20200310111037.31451-1-aostruszka@marvell.com/

    - ethdev capabilities and feature enabling
      http://inbox.dpdk.org/dev/13121897.9FIjf2LrnR@xps/
      http://inbox.dpdk.org/dev/8032312.HfnmF1KY9p@xps/
      http://inbox.dpdk.org/dev/20200319075851.GA26440@chelsio.com/


Thanks a lot for helping releases to happen!