From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 2DEEADE0
 for <dev@dpdk.org>; Fri, 17 Jan 2014 12:24:06 +0100 (CET)
Received: by mail-wg0-f51.google.com with SMTP id z12so4278991wgg.18
 for <dev@dpdk.org>; Fri, 17 Jan 2014 03:25:21 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id;
 bh=8v01s6oSq0i4t8tyzplBDl3gXW05arxmLVP5AlwscoE=;
 b=dhOoH08q5iPlhyZVVI1wc6hJ07Bagxzd+N9KgxfjtTJlPs7WfW8K0PT5x8f+gbK7Xb
 KoTp9VRSElzHHIoep5IOvQy10bDQ8vBll2xQxrnpJiqONcje8iNW+fsWseKY8LW+d+EH
 5GLCFmEsYSvFI5ZZB8xF+Qhu2CWSsOsta9KlB6mgGanKfd+b/fbDPEZdNZEB7/BqsKVW
 rB3i2tpsxGy5IpQKSm4ZSEpKYP3Qe8/SCT2iFhd9guh1LSfAgmXs4iY81A7Tmbo/r0Od
 3LSA4biRRzIGHXfhn71HLIvO9T7Wcsmkw9PH8+TYju9/8jNwzpvOe6R+LXK2z+oagzLv
 yyqA==
X-Gm-Message-State: ALoCoQmtRTOHs284kKV+a1v5PHlO0ZcPDXOq7NRE2IUYVD/2VBCNEGEE922Wu10bynYFCdYhB/X7
X-Received: by 10.180.207.10 with SMTP id ls10mr2090563wic.52.1389957920933;
 Fri, 17 Jan 2014 03:25:20 -0800 (PST)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id po3sm9037200wjc.3.2014.01.17.03.25.19
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 17 Jan 2014 03:25:20 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: Daniel Kan <dan@nyansa.com>
Date: Fri, 17 Jan 2014 12:25:18 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <CAEykdvr+9JD0MKwwGqf-4+jSnVaPFGPnMYnr_VFfgCn2+hPcEg@mail.gmail.com>
 <1389832299-30033-1-git-send-email-dan@nyansa.com>
 <CAEykdvp9RP9rA8t_stNNygAw9rZyLRxUo3G-ej-Wy=pEkvTzrg@mail.gmail.com>
In-Reply-To: <CAEykdvp9RP9rA8t_stNNygAw9rZyLRxUo3G-ej-Wy=pEkvTzrg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201401171225.18818.thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: fix RSS rx by setting mq_mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2014 11:24:06 -0000

> > The mq_mode was not set when rxq is > 0; it's defaulted to
> > ETH_MQ_RX_NONE. As a result, RSS remains inactive. The fix is to set
> > mq_mode to ETH_MQ_RX_RSS when hf is non-zero.
> > 
> > This bug was introduced by commit
> > 243db2ddee3094a2cb39fdd4b17e26df4e7735e1 igb/ixgbe: ETH_MQ_RX_NONE
> > should disable RSS
> > 
> > Signed-off-by: Daniel Kan <dan@nyansa.com>
> 
> Acked-by: Maxime Leroy <maxime.leroy@6wind.com>

Applied.
Thanks for the patch and the reworks.

-- 
Thomas