From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 3273D68F2 for ; Wed, 19 Feb 2014 17:50:50 +0100 (CET) Received: by mail-we0-f172.google.com with SMTP id u56so565659wes.3 for ; Wed, 19 Feb 2014 08:52:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=7C7lgcxkb9xtxD5VxNE00+rrstviVP7m6xUb+6yOKxc=; b=IUHJCa01Xs0zpjFfRYxodfBBTvv4vfeIzhetgTp6aFhFDvtMruVq7DOTiSKjITF6Ti BUW5zLgNdiBwBPVcjfAW/NRoIxClIhBAhSTuyb5dsrvHMZdlSHbF4y7DvLjPXB/VaTnM /PvgdZT7x/pZf6qfG1q6ZA+H0CDUj5pKwHmSeyhWXMjDmXp/ISVSepXXEpueOJWDPo9I xfohUxqRfUAgh+le5XLvspE9ktueAsBF1z8CLhg0/dKWGcyAEaehsBJmSxuz2r77RLSS DHj24NgF14t4aHF2yo0IroPx/HDcxP7lQYTR6tDHS1lVSLwzaQY6FS8CCPNbPPnBqWsa OY3g== X-Gm-Message-State: ALoCoQnWbP+aytHII0oDowT+2s+A042AX9q8Lzoy0bufGI6hmW20aMdyxjqAGxkAtnGZg2b8zVfE X-Received: by 10.180.83.137 with SMTP id q9mr2391103wiy.55.1392828734640; Wed, 19 Feb 2014 08:52:14 -0800 (PST) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id hy8sm1876462wjb.2.2014.02.19.08.52.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Feb 2014 08:52:13 -0800 (PST) From: Thomas Monjalon Organization: 6WIND To: "Ananyev, Konstantin" Date: Wed, 19 Feb 2014 17:52:11 +0100 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <1392811162-28527-1-git-send-email-didier.pallard@6wind.com> <1392811162-28527-2-git-send-email-didier.pallard@6wind.com> <2601191342CEEE43887BDE71AB97725808E689E6@IRSMSX105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725808E689E6@IRSMSX105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201402191752.11989.thomas.monjalon@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 2/2] ixgbe: release software locked semaphores on initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Feb 2014 16:50:50 -0000 19/02/2014 13:41, Ananyev, Konstantin: > Can the patch be reworked to keep changes under librte_pmd_ixgbe/ixgbe > directory untouched? Those files are derived directly from the BSD driver > baseline, and any changes will make future merges of newer code more > challenging. The changes should be limited to files in the > librte_pmd_ixgbe directory (and ethdev). Thanks Please, could you send an url to the BSD driver baseline ? By the way, git is very good at rebasing such patches. And if the fix is good, it should be applied on the baseline. Refusing a fix without alternative is not an option. -- Thomas