From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id C91F71F3 for ; Sat, 29 Mar 2014 13:59:00 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1WTss8-0001qi-PQ; Sat, 29 Mar 2014 09:00:32 -0400 Date: Sat, 29 Mar 2014 09:00:27 -0400 From: Neil Horman To: Thomas Monjalon Message-ID: <20140329130027.GA13408@hmsreliant.think-freely.org> References: <1396056749-11738-1-git-send-email-nhorman@tuxdriver.com> <3857255.iofc7hnFnA@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3857255.iofc7hnFnA@x220> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pcap: remove test for PCAP_CAN_SEND X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Mar 2014 12:59:01 -0000 On Sat, Mar 29, 2014 at 11:34:46AM +0100, Thomas Monjalon wrote: > Hi Neil, > > 28/03/2014 21:32, Neil Horman : > > The libpcap library has had the ability to send packets since 2004, theres > > really no need to test for it. Especially in the way dpdk is doing as, as > > according to the libpcap git tree pcap_sendpacket has never been a #define, > > and dpdk tests for its existance with an #ifdef. Its easier just to remove > > the test entirely > > > > Signed-off-by: Neil Horman > > A similar patch is already applied on HEAD: > http://dpdk.org/browse/dpdk/commit/?id=2a315d698510e7b33 > My bad, thanks! Neil > -- > Thomas >