From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 9ED62AA36
 for <dev@dpdk.org>; Sun, 13 Apr 2014 20:22:31 +0200 (CEST)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1WZP2k-0003mJ-UJ; Sun, 13 Apr 2014 14:22:30 -0400
Date: Sun, 13 Apr 2014 14:22:14 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20140413182214.GA10525@hmsreliant.think-freely.org>
References: <1397140907-17856-1-git-send-email-linville@tuxdriver.com>
 <5680509.vJ63cQx4Bi@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5680509.vJ63cQx4Bi@xps13>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] rte_pmd_init_all: initialize non-PCI PMDs
 provided by EAL
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Apr 2014 18:22:31 -0000

On Fri, Apr 11, 2014 at 03:23:27PM +0200, Thomas Monjalon wrote:
> Hi John,
> 
> 2014-04-10 10:41, John W. Linville:
> > These PMDs were being initialized by the EAL layer, but many apps were
> > relying on the return value of rte_pmd_init_all to indicate that
> > ethernet interfaces were available for use.  Move the initialization of
> > the non-PCI PMDs to this centralized function to have all of the PMDs
> > treated equally.
> > 
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 
> We are using constuctors to initialize these drivers. See the patches from 
> Olivier Matz.
> The function rte_pmd_init_all() should be removed.
> 
Actually, from what I see in the git tree and of his patch set, he's only
converted the virtual devices to use constructors with registration functions.
The physical pmd's still use rte_pmd_init_all, so until that changes, this still
seems like a reasonable interim step.

Neil

> So this patch won't be applied.
> 
> Your help to continue cleaning this area is welcome.
> -- 
> Thomas
>