From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 589BCB0A6 for ; Fri, 25 Apr 2014 15:19:28 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Wdg26-0004og-C7; Fri, 25 Apr 2014 09:19:29 -0400 Date: Fri, 25 Apr 2014 09:19:12 -0400 From: Neil Horman To: Olivier Matz Message-ID: <20140425131912.GD14074@hmsreliant.think-freely.org> References: <1398427188-14914-1-git-send-email-olivier.matz@6wind.com> <1398427188-14914-9-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398427188-14914-9-git-send-email-olivier.matz@6wind.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 08/10] bsd/mk: use the Q variable instead of @ for quiet commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2014 13:19:28 -0000 On Fri, Apr 25, 2014 at 01:59:46PM +0200, Olivier Matz wrote: > This allows to use V=1 to be more verbose to debug the build process > of a bsd kernel module. > > Signed-off-by: Olivier Matz This doesnt seem like it should really be part of this series, given that everything else in it is here to fix build breaks. Nothing wrong with it that I can see, but should probably be posted independently. Neil > --- > mk/rte.bsdmodule.mk | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/mk/rte.bsdmodule.mk b/mk/rte.bsdmodule.mk > index 6224715..28b5189 100644 > --- a/mk/rte.bsdmodule.mk > +++ b/mk/rte.bsdmodule.mk > @@ -74,24 +74,24 @@ build: _postbuild > # Link all sources in build directory > %_link: FORCE > $(if $(call compare,$(notdir $*),$*),\ > - @if [ ! -f $(notdir $(*)) ]; then ln -nfs $(SRCDIR)/$(*) . ; fi,\ > - @if [ ! -f $(notdir $(*)) ]; then ln -nfs $(SRCDIR)/$(*) . ; fi) > + $(Q)if [ ! -f $(notdir $(*)) ]; then ln -nfs $(SRCDIR)/$(*) . ; fi,\ > + $(Q)if [ ! -f $(notdir $(*)) ]; then ln -nfs $(SRCDIR)/$(*) . ; fi) > > # build module > $(MODULE).ko: $(SRCS_LINKS) > - @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > - @if [ ! -f $(notdir BSDmakefile) ]; then ln -nfs $(SRCDIR)/BSDmakefile . ; fi > - @MAKEFLAGS= $(BSDMAKE) -v > + $(Q)if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > + $(Q)if [ ! -f $(notdir BSDmakefile) ]; then ln -nfs $(SRCDIR)/BSDmakefile . ; fi > + $(Q)MAKEFLAGS= $(BSDMAKE) > > # install module in $(RTE_OUTPUT)/kmod > $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko > - @echo INSTALL-MODULE $(MODULE).ko > - @[ -d $(RTE_OUTPUT)/kmod ] || mkdir -p $(RTE_OUTPUT)/kmod > - @cp -f $(MODULE).ko $(RTE_OUTPUT)/kmod > + $(Q)echo INSTALL-MODULE $(MODULE).ko > + $(Q)[ -d $(RTE_OUTPUT)/kmod ] || mkdir -p $(RTE_OUTPUT)/kmod > + $(Q)cp -f $(MODULE).ko $(RTE_OUTPUT)/kmod > > # install module > modules_install: > - @MAKEFLAGS= $(BSDMAKE) install > + $(Q)MAKEFLAGS= $(BSDMAKE) install > > .PHONY: clean > clean: _postclean > @@ -99,12 +99,12 @@ clean: _postclean > # do a make clean and remove links > .PHONY: doclean > doclean: > - @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > + $(Q)if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > $(Q)$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) clean > - @$(foreach FILE,$(SRCS-y) $(SRCS-n) $(SRCS-),\ > + $(Q)$(foreach FILE,$(SRCS-y) $(SRCS-n) $(SRCS-),\ > if [ -h $(notdir $(FILE)) ]; then rm -f $(notdir $(FILE)) ; fi ;) > - @if [ -h $(notdir Makefile) ]; then rm -f $(notdir Makefile) ; fi > - @rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \ > + $(Q)if [ -h $(notdir Makefile) ]; then rm -f $(notdir Makefile) ; fi > + $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \ > $(INSTALL-FILES-all) > > include $(RTE_SDK)/mk/internal/rte.install-post.mk > -- > 1.9.2 > >