From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id EA7CBB0B1 for ; Wed, 14 May 2014 18:41:54 +0200 (CEST) Received: by mail-pa0-f41.google.com with SMTP id lj1so1901962pab.0 for ; Wed, 14 May 2014 09:42:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=3xymWgzeOP8ZkDeVREa2erNxMCMxIJNjkt0I8iNx/Co=; b=VAfg1etBfoJhzna4nEOIbHCRj/gPEj2xWRq9g+fYJX8pSVxFn1w4HREPjGG5MJED8T LRYgBsK/S5kz/ierT46Lvr0Gu/nqmJDWDu5s7QCIvjLi4ilyyLxf/YkjxWUEDOwzxhJB KsZAMW2qCcadY1KCtLU9hhN2YoCyLy3BgxODYJFYTErd9IkFPlFZpZnJZ5hvnuAHdPlT oOogOeKQOL70QvOjXbEPw0l1Xj9kfM2xsdHRAFLgUE4jzcwRcIK+h6x7aJ61Q8IvxAVJ giphSoBVNfZCjk4IhL9vQn0w6wdz3gcyxkjStXnlaxWyOykLCdvFwkcLLHtusXCOHXcv vlXw== X-Gm-Message-State: ALoCoQnRM9nzTVYqQKHxyo1amxC3127WG8zlU33Xk5eWeaQaqGInQ6w1tz3TatxhVneXOYhirlcc X-Received: by 10.66.221.99 with SMTP id qd3mr5899232pac.46.1400085722293; Wed, 14 May 2014 09:42:02 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51]) by mx.google.com with ESMTPSA id gg3sm4387107pbc.34.2014.05.14.09.42.01 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 14 May 2014 09:42:02 -0700 (PDT) Date: Wed, 14 May 2014 09:41:59 -0700 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20140514094159.435928e3@nehalam.linuxnetplumber.net> In-Reply-To: <1559974.KXN93MZ8m0@xps13> References: <20140514081932.37847146@nehalam.linuxnetplumber.net> <1559974.KXN93MZ8m0@xps13> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Don't inline string functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2014 16:41:55 -0000 On Wed, 14 May 2014 17:47:01 +0200 Thomas Monjalon wrote: > 2014-05-14 08:19, Stephen Hemminger: > > It makes no sense to inline string functions, in fact snprintf > > can't be inlined because the function supports variable number of > > arguments. > > > > Signed-off-by: Stephen Hemminger > > > > --- > > Resend because of lack of response > > Please do not resend patches. I prefer a ping request in the original thread. > > By the way, you didn't take into account my first comments: > http://dpdk.org/ml/archives/dev/2014-April/002028.html All the issues there are changed. includes, copyright etc. > and I'm still waiting answers to these patches: > http://dpdk.org/ml/archives/dev/2014-March/001673.html This is in the rte_sched group. patch 1 > http://dpdk.org/ml/archives/dev/2014-March/001676.html This is more of a mess than want to get into right now. header conflicts are nuisance.