From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com
 [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 3DC32B0C2
 for <dev@dpdk.org>; Wed, 14 May 2014 18:35:03 +0200 (CEST)
Received: by mail-pa0-f52.google.com with SMTP id fa1so1877694pad.39
 for <dev@dpdk.org>; Wed, 14 May 2014 09:35:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:user-agent:date:from:to:cc:subject
 :references:mime-version:content-type:content-disposition;
 bh=bAW6VBhYZ2S3jOamNFqfylElKQFlIDa1SfRT9bV7Ac8=;
 b=YYQ1E8vahnXfB5UGCSpyqEM4kSkm34sx1nzyy5MA4gSYOExp0R7sJZK+dGpc6HlO/r
 Ue9OINM4G1fDBnQQWMxuHT1lUUiBRfcdOdOLnhxtalNONEdBVt4BP6ds4Yr9BbGJ8yiR
 /un1exgCfv9m3f/xmd7bpVeXDftyDqXck//PaLp0dEjudwSeHqt05w6asbBlvJThqfPS
 X5GWvmiO4U5vhVaJkyUS3Pl4fQ9P8REQkGcV6S3KGAfq27i+Js+rYjPIvnAQfx6xvCtS
 qJZCjUi0jzL2Fphfk6UHHQkJUbX0aPPHADKwNATP8VWLyaylTvpKw8oBlxTXztIOwnk6
 j8Wg==
X-Gm-Message-State: ALoCoQlKh+iyoG6fzdEYRe8j26FvUh7fG9ldbvINcbJZJdRkEynxSTDnpCAOmZliLOzLxpn+ULhB
X-Received: by 10.66.180.200 with SMTP id dq8mr5810577pac.104.1400085310667;
 Wed, 14 May 2014 09:35:10 -0700 (PDT)
Received: from localhost (static-50-53-83-51.bvtn.or.frontiernet.net.
 [50.53.83.51])
 by mx.google.com with ESMTPSA id ha3sm4373495pbc.5.2014.05.14.09.35.08
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 14 May 2014 09:35:09 -0700 (PDT)
Message-Id: <20140514163508.082399018@networkplumber.org>
User-Agent: quilt/0.61-1
Date: Wed, 14 May 2014 09:34:04 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
References: <20140514163401.079384157@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Disposition: inline; filename=igb-uio-module-param.patch
Cc: Stephen Hemminger <shemming@brocade.com>
Subject: [dpdk-dev] [PATCH 3/5] igb_uio: mark module param read/only
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2014 16:35:03 -0000

The module parameter is read-only since changing mode after loading
isn't going to work.

Signed-off-by: Stephen Hemminger <shemming@brocade.com>

--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c	2014-05-14 09:32:17.214827796 -0700
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c	2014-05-14 09:32:17.214827796 -0700
@@ -656,7 +656,7 @@ igbuio_pci_exit_module(void)
 module_init(igbuio_pci_init_module);
 module_exit(igbuio_pci_exit_module);
 
-module_param(intr_mode, charp, S_IRUGO | S_IWUSR);
+module_param(intr_mode, charp, S_IRUGO);
 MODULE_PARM_DESC(intr_mode,
 "igb_uio interrupt mode (default=msix):\n"
 "    msix       Use MSIX interrupt\n"