From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id A57CD58E4 for ; Thu, 5 Jun 2014 13:03:31 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1WsVSP-0007K6-Sz; Thu, 05 Jun 2014 07:03:44 -0400 Date: Thu, 5 Jun 2014 07:03:40 -0400 From: Neil Horman To: declan.doherty@intel.com Message-ID: <20140605110340.GB20841@hmsreliant.think-freely.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/4] Link Bonding Library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2014 11:03:32 -0000 On Wed, Jun 04, 2014 at 04:18:01PM +0100, declan.doherty@intel.com wrote: > From: Declan Doherty > > v2 patch additions, > fix for tx burst broadcast, incrementing the reference count on each mbuf by the number of slaves - 1 > add/remove slave behavior chnange to fix primary slave port assignment > patchcheck code fixes > > Initial release of Link Bonding Library (lib/librte_bond) with support for bonding modes : > 0 - Round Robin > 1 - Active Backup > 2 - Balance l2 / l23 / l34 > 3 - Broadcast > > patches split: > 1 - library + makefile changes > 2 - Unit test suite, including code to generate packet bursts for > testing rx and tx functionality of bonded device and a > virtual/stubbed out ethdev for use as slave ethdev in testing > 3 - Link bonding integration into testpmd, including : > - Includes the ability to create new bonded devices. > - Add /remove bonding slave devices. > - Interogate bonded device stats/configuration > - Change bonding modes and select balance transmit polices > 4 - Add Link Bonding Library to Doxygen > > > app/test-pmd/cmdline.c | 570 ++++++ > app/test-pmd/config.c | 4 +- > app/test-pmd/parameters.c | 4 +- > app/test-pmd/testpmd.c | 37 +- > app/test-pmd/testpmd.h | 2 + > app/test/Makefile | 3 + > app/test/commands.c | 3 + > app/test/packet_burst_generator.c | 289 +++ > app/test/packet_burst_generator.h | 78 + > app/test/test.h | 1 + > app/test/test_link_bonding.c | 3943 +++++++++++++++++++++++++++++++++++++ > app/test/virtual_pmd.c | 574 ++++++ > app/test/virtual_pmd.h | 74 + > config/common_bsdapp | 5 + > config/common_linuxapp | 5 + > doc/doxy-api-index.md | 1 + > doc/doxy-api.conf | 1 + > lib/Makefile | 1 + > lib/librte_bond/Makefile | 28 + > lib/librte_bond/rte_bond.c | 1682 ++++++++++++++++ > lib/librte_bond/rte_bond.h | 228 +++ > mk/rte.app.mk | 5 + > 22 files changed, 7531 insertions(+), 7 deletions(-) > create mode 100644 app/test/packet_burst_generator.c > create mode 100644 app/test/packet_burst_generator.h > create mode 100644 app/test/test_link_bonding.c > create mode 100644 app/test/virtual_pmd.c > create mode 100644 app/test/virtual_pmd.h > create mode 100644 lib/librte_bond/Makefile > create mode 100644 lib/librte_bond/rte_bond.c > create mode 100644 lib/librte_bond/rte_bond.h > > -- > 1.8.5.3 > > This doesn't address any of the comments I made previously. Neil