From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id A1A11B15A for ; Wed, 18 Jun 2014 18:18:13 +0200 (CEST) Received: from nat-pool-rdu-u.redhat.com ([66.187.233.203] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1WxIZ7-0006wA-Lu; Wed, 18 Jun 2014 12:18:27 -0400 Date: Wed, 18 Jun 2014 12:18:19 -0400 From: Neil Horman To: Declan Doherty Message-ID: <20140618161819.GF3301@localhost.localdomain> References: <1402917513-19495-1-git-send-email-declan.doherty@intel.com> <1403108063-27169-1-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403108063-27169-1-git-send-email-declan.doherty@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 0/6] Link Bonding Library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2014 16:18:14 -0000 On Wed, Jun 18, 2014 at 05:14:17PM +0100, Declan Doherty wrote: > This patch contains the initial release of the Link Bonding PMD Library > > Supporting bonding modes: > 0 - Round Robin > 1 - Active Backup > 2 - Balance (Supporting 3 transmission polices) > layer 2, layer 2+3, layer 3+4 > 3 - Broadcast > > Version 5 of patch set: > Contains changes to EAL code to allow initialisation of Bonded devices from > application startup options. rte_eal_init now calls rte_eal_pci_probe > between calling rte_eal_dev_init with PRE and POST PCI probe flags. This gets > around polluting the eal pci code with references to link bonding devices. > Also rte_eal_pci_probe can now be called multiple times and will not try to > re-initialize the driver if one already exists, this means that existing > applications which currently call rte_eal_pci_probe will not be affected > by this change > > > Patch Set Description: > 0001 - librte_pmd_bond + makefile changes > 0002 - librte_ether changes to support unique naming of pmds > 0003 - librte_eal changes to support bonding device intialization > 0005 - link bonding unti test suite > 0005 - testpmd link bonding support changes > 0006 - doxygen additions > > > Declan Doherty (6): > Link Bonding Library (lib/librte_pmd_bond) > Support for unique interface naming of pmds > EAL support for link bonding device initialization > Link bonding Unit Tests > testpmd link bonding additions > Link Bonding Library doxygen additions > > app/test-pmd/cmdline.c | 579 ++++ > app/test-pmd/config.c | 4 +- > app/test-pmd/parameters.c | 3 + > app/test-pmd/testpmd.c | 40 +- > app/test-pmd/testpmd.h | 2 + > app/test/Makefile | 4 +- > app/test/commands.c | 7 + > app/test/packet_burst_generator.c | 287 ++ > app/test/packet_burst_generator.h | 78 + > app/test/test.h | 1 + > app/test/test_link_bonding.c | 3958 +++++++++++++++++++++++++++ > app/test/virtual_pmd.c | 574 ++++ > app/test/virtual_pmd.h | 74 + > config/common_bsdapp | 5 + > config/common_linuxapp | 5 + > doc/doxy-api-index.md | 1 + > doc/doxy-api.conf | 1 + > lib/Makefile | 1 + > lib/librte_eal/bsdapp/eal/eal.c | 10 +- > lib/librte_eal/common/eal_common_dev.c | 58 +- > lib/librte_eal/common/eal_common_pci.c | 3 + > lib/librte_eal/common/include/eal_private.h | 7 - > lib/librte_eal/common/include/rte_dev.h | 13 +- > lib/librte_eal/linuxapp/eal/eal.c | 11 +- > lib/librte_ether/rte_ethdev.c | 32 +- > lib/librte_ether/rte_ethdev.h | 7 +- > lib/librte_pmd_bond/Makefile | 32 + > lib/librte_pmd_bond/rte_eth_bond.c | 2148 +++++++++++++++ > lib/librte_pmd_bond/rte_eth_bond.h | 255 ++ > lib/librte_pmd_pcap/rte_eth_pcap.c | 22 +- > lib/librte_pmd_ring/rte_eth_ring.c | 32 +- > lib/librte_pmd_ring/rte_eth_ring.h | 3 +- > lib/librte_pmd_xenvirt/rte_eth_xenvirt.c | 2 +- > mk/rte.app.mk | 5 + > 34 files changed, 8193 insertions(+), 71 deletions(-) > create mode 100644 app/test/packet_burst_generator.c > create mode 100644 app/test/packet_burst_generator.h > create mode 100644 app/test/test_link_bonding.c > create mode 100644 app/test/virtual_pmd.c > create mode 100644 app/test/virtual_pmd.h > create mode 100644 lib/librte_pmd_bond/Makefile > create mode 100644 lib/librte_pmd_bond/rte_eth_bond.c > create mode 100644 lib/librte_pmd_bond/rte_eth_bond.h > > For the series Acked-by: Neil Horman Thanks for all the hard work! Neil