From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AFA7F6893 for ; Mon, 29 Sep 2014 12:41:52 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 29 Sep 2014 03:39:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="392969452" Received: from bricha3-mobl.ger.corp.intel.com (HELO bricha3-mobl.ir.intel.com) ([10.243.20.21]) by FMSMGA003.fm.intel.com with SMTP; 29 Sep 2014 03:42:11 -0700 Received: by bricha3-mobl.ir.intel.com (sSMTP sendmail emulation); Mon, 29 Sep 2014 11:48:24 +0001 Date: Mon, 29 Sep 2014 11:48:24 +0100 From: Bruce Richardson To: Jijiang Liu Message-ID: <20140929104824.GD12072@BRICHA3-MOBL> References: <1411696929-13856-1-git-send-email-jijiang.liu@intel.com> <1411696929-13856-3-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411696929-13856-3-git-send-email-jijiang.liu@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.22 (2013-10-16) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 10:41:53 -0000 On Fri, Sep 26, 2014 at 10:02:03AM +0800, Jijiang Liu wrote: > Support tunneling UDP port configuration on i40e in librte_pmd_i40e. > Currently, only VxLAN is implemented, which include > - VxLAN UDP port initialization > - Implement the APIs to configure VxLAN UDP port in librte_pmd_i40e. > > Signed-off-by: Jijiang Liu > Acked-by: Helin Zhang > Acked-by: Jingjing Wu > Acked-by: Jing Chen > > --- > config/common_linuxapp | 5 + > lib/librte_mbuf/rte_mbuf.h | 2 + > lib/librte_pmd_i40e/i40e_ethdev.c | 200 ++++++++++++++++++++++++++++++++++++- > lib/librte_pmd_i40e/i40e_ethdev.h | 5 + > lib/librte_pmd_i40e/i40e_rxtx.c | 10 ++ > 5 files changed, 221 insertions(+), 1 deletions(-) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index 5bee910..75a4cd7 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -212,6 +212,11 @@ CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 > CONFIG_RTE_LIBRTE_I40E_ITR_INTERVAL=-1 > > # > +# Compile tunneling UDP port support > +# > +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=4789 > + > +# > # Compile burst-oriented VIRTIO PMD driver > # > CONFIG_RTE_LIBRTE_VIRTIO_PMD=y > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 1c6e115..4955684 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -538,6 +538,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf *m) > m->port = 0xff; > > m->ol_flags = 0; > + m->reserved = 0; > m->data_off = (RTE_PKTMBUF_HEADROOM <= m->buf_len) ? > RTE_PKTMBUF_HEADROOM : m->buf_len; > > @@ -607,6 +608,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *md) > mi->pkt_len = mi->data_len; > mi->nb_segs = 1; > mi->ol_flags = md->ol_flags; > + mi->reserved = md->reserved; > > __rte_mbuf_sanity_check(mi, 1); > __rte_mbuf_sanity_check(md, 0); If the "reserved" field in the mbuf is now being used, it should be renamed to what its actually being used for. If it is still not being used, why this change? /Bruce