From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id EA42668CD
 for <dev@dpdk.org>; Mon,  6 Oct 2014 16:43:24 +0200 (CEST)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1Xb9cH-0001Hv-Sd; Mon, 06 Oct 2014 10:50:31 -0400
Date: Mon, 6 Oct 2014 10:50:20 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: =?iso-8859-1?Q?Nicol=E1s?= Pernas Maradei <nico@emutex.com>,
 f@hmsreliant.think-freely.org
Message-ID: <20141006145020.GE22304@hmsreliant.think-freely.org>
References: <005307> <1412461457-29061-1-git-send-email-nico@emutex.com>
 <209a96ce6067cf0b5239b8d9143fbb2a@statler.emutex.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <209a96ce6067cf0b5239b8d9143fbb2a@statler.emutex.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Fix librte_pmd_pcap driver double stop
 error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Oct 2014 14:43:25 -0000

On Sun, Oct 05, 2014 at 07:37:11PM +0100, Nicolás Pernas Maradei wrote:
> Hi,
> 
> New in Patch v2:
> 
> - Fixes an issue in eth_dev_start/stop where a single interface was always
> opened/closed even though pcap files had been selected for rx/tx streams.
> - The link_status was not being properly updated in case of using a single
> interface for rx/tx streams.
> 
> Nico.
> 
> On 2014-10-04 23:24, Nicolás Pernas Maradei wrote:
> >From: Nicolás Pernas Maradei <nicolas.pernas.maradei@emutex.com>
> >
> >librte_pmd_pcap driver was opening the pcap/interfaces only at init time
> >and
> >closing them only when the port was being stopped. This behaviour would
> >cause
> >problems (leading to segfault) if the user closed the port 2 times. The
> >first
> >time the pcap/interfaces would be normally closed but libpcap would throw
> >an
> >error causing a segfault if the closed pcaps/interfaces were closed again.
> >This behaviour is solved by re-openning pcaps/interfaces when the port is
> >started (only if these weren't open already for example at init time).
> >
> >Signed-off-by: Nicolás Pernas Maradei <nico@emutex.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>