From: Neil Horman <nhorman@tuxdriver.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: dev@dpdk.org, Daniel Mrzyglod <dtmrzglx@sivswdev02.ir.intel.com>
Subject: Re: [dpdk-dev] [PATCH] Modify tools/setup.sh to be compatible with fedora 21
Date: Wed, 8 Oct 2014 10:36:52 -0400 [thread overview]
Message-ID: <20141008143652.GC5279@localhost.localdomain> (raw)
In-Reply-To: <1412773891-25774-1-git-send-email-danielx.t.mrzyglod@intel.com>
On Wed, Oct 08, 2014 at 02:11:31PM +0100, Daniel Mrzyglod wrote:
> From: Daniel Mrzyglod <dtmrzglx@localhost.localdomain>
>
> script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
> there are Compressed kernel modules - xz (LZMA)
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
> tools/setup.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/setup.sh b/tools/setup.sh
> index 369e09e..6a9d23c 100755
> --- a/tools/setup.sh
> +++ b/tools/setup.sh
> @@ -169,7 +169,7 @@ load_igb_uio_module()
>
> /sbin/lsmod | grep -s uio > /dev/null
> if [ $? -ne 0 ] ; then
> - if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
> + if ls /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko* &> /dev/null; then
> echo "Loading uio module"
> sudo /sbin/modprobe uio
> fi
> --
> 2.1.0
>
>
Just use modinfo uio and test the exit code. That will make the setup script
agnostic to both filename extension and to kernel version, as modinfo looks in
the running kernel path automatically
Neil
prev parent reply other threads:[~2014-10-08 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 13:11 Daniel Mrzyglod
2014-10-08 13:58 ` Mrzyglod, DanielX T
2014-10-08 14:36 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008143652.GC5279@localhost.localdomain \
--to=nhorman@tuxdriver.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
--cc=dtmrzglx@sivswdev02.ir.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).