From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id A160D7FC1
 for <dev@dpdk.org>; Fri, 10 Oct 2014 13:26:00 +0200 (CEST)
Received: from cpe-098-026-066-094.nc.res.rr.com ([98.26.66.94] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1XcYRj-0006eq-4L; Fri, 10 Oct 2014 07:33:25 -0400
Date: Fri, 10 Oct 2014 07:33:13 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Message-ID: <20141010113313.GC19499@hmsreliant.think-freely.org>
References: <1412935688-16991-1-git-send-email-danielx.t.mrzyglod@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1412935688-16991-1-git-send-email-danielx.t.mrzyglod@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] Modify tools/setup.sh to be compatible
 with fedora 21
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Oct 2014 11:26:00 -0000

On Fri, Oct 10, 2014 at 11:08:08AM +0100, Daniel Mrzyglod wrote:
> script was expecting /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko but in fedora 21
> there are Compressed kernel modules - xz (LZMA)
> 
> V3 patch: Remove sudo
> V2 patch: Use modinfo instead ls
> V1 patch: use ls instead checking if specific file exist
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>  tools/setup.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/setup.sh b/tools/setup.sh
> index 369e09e..14e319c 100755
> --- a/tools/setup.sh
> +++ b/tools/setup.sh
> @@ -169,7 +169,8 @@ load_igb_uio_module()
>  
>  	/sbin/lsmod | grep -s uio > /dev/null
>  	if [ $? -ne 0 ] ; then
> -		if [ -f /lib/modules/$(uname -r)/kernel/drivers/uio/uio.ko ] ; then
> +		modinfo uio > /dev/null
> +		if [ $? -eq 0 ]; then
>  			echo "Loading uio module"
>  			sudo /sbin/modprobe uio
>  		fi
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>