From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 640C27E62
for <dev@dpdk.org>; Fri, 24 Oct 2014 14:26:47 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga101.jf.intel.com with ESMTP; 24 Oct 2014 05:35:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,780,1406617200"; d="scan'208";a="624625471"
Received: from bricha3-mobl.ger.corp.intel.com (HELO
bricha3-mobl.ir.intel.com) ([10.243.20.25])
by orsmga002.jf.intel.com with SMTP; 24 Oct 2014 05:34:59 -0700
Received: by bricha3-mobl.ir.intel.com (sSMTP sendmail emulation);
Fri, 24 Oct 2014 13:34:58 +0001
Date: Fri, 24 Oct 2014 13:34:58 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Message-ID: <20141024123458.GA7648@BRICHA3-MOBL>
References: <1414138209-24431-1-git-send-email-changchun.ouyang@intel.com>
<1414138209-24431-3-git-send-email-changchun.ouyang@intel.com>
<2601191342CEEE43887BDE71AB9772582139EBAF@IRSMSX105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2601191342CEEE43887BDE71AB9772582139EBAF@IRSMSX105.ger.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] pmd: RX function need keep EXTERNAL_MBUF
flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Oct 2014 12:26:47 -0000
On Fri, Oct 24, 2014 at 10:46:06AM +0000, Ananyev, Konstantin wrote:
> Hi Changchun,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ouyang Changchun
> > Sent: Friday, October 24, 2014 9:10 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH 2/3] pmd: RX function need keep EXTERNAL_MBUF flag
> >
> > Every pmd RX function need keep the EXTERNAL_MBUF flag
> > in mbuf.ol_flags, and can't overwrite it when filling ol_flags from
> > descriptor to mbuf, otherwise, it probably cause to crash when freeing a mbuf
> > and trying to freeing its attached external buffer, say, from guest space.
> >
>
> Don't really like the idea to put:
> mb->ol_flags = pkt_flags | (mb->ol_flags & EXTERNAL_MBUF);
> in each and every PMD from now on...
>
> From other side, it is probably not very good that RX functions update whole ol_flags, not only RX related part.
> Wonder can we reserve low 32bits of ol_flags for RX, and high 32bits for TX and generic stuff.
> So our ol_flags will look something like that:
>
> union {
> uint64_t ol_raw_flags;
> struct {
> uint32_t rx;
> uint32_t gen_tx;
> } ol_flags
> };
>
> And make all PMD RX functions to operate on rx part of the flags only:
> mb->ol_flags.rx = pkt_flags;
> ?
>
> Konstantin
>
I would tend to agree with this. Changchun, did you get to assess the
performance impact of making this change to the PMDs? I suspect that making
the changes to each PMD would impact performance, while Konstantin's
suggestion should eliminate that impact.
The downside there is that we are limiting the flexibility we have in
expanding beyond 32 RX flags and 24 TX flags. :-(
/Bruce