From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 828A63F9 for ; Tue, 18 Nov 2014 13:58:11 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 18 Nov 2014 05:08:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,409,1413270000"; d="scan'208";a="633842374" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.33]) by fmsmga002.fm.intel.com with SMTP; 18 Nov 2014 05:08:29 -0800 Received: by (sSMTP sendmail emulation); Tue, 18 Nov 2014 13:08:28 +0025 Date: Tue, 18 Nov 2014 13:08:28 +0000 From: Bruce Richardson To: "Ananyev, Konstantin" Message-ID: <20141118130828.GA10768@bricha3-MOBL3> References: <1416296251-7534-1-git-send-email-jijiang.liu@intel.com> <2601191342CEEE43887BDE71AB977258213B581A@IRSMSX105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB977258213B581A@IRSMSX105.ger.corp.intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 12:58:12 -0000 On Tue, Nov 18, 2014 at 11:33:24AM +0000, Ananyev, Konstantin wrote: > Hi Frank, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > > Sent: Tuesday, November 18, 2014 7:37 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 0/4] Translate packet types for i40e > > > > The i40e NIC can recognize many packet types, including ordinary L2 packet format and tunneling packet format such as IP in IP, IP in > > GRE, MAC in GRE and MAC in UDP. > > > > This patch set provides abstract definitions of packet types, > > which can help user to use these packet types directly in their applications to speed up receive packet analysis. > > > > Moreover, this patch set translates i40e packet types to abstract packet types in i40e driver, > > and make the corresponding changes in test applications. > > > > Jijiang Liu (4): > > Add packet type and IP header check in rte_mbuf > > Remove the PKT_RX_TUNNEL_IPV4_HDR and the PKT_RX_TUNNEL_IPV6_HDR > > Translate i40e packet types > > Make the corresponding changes in test-pmd > > > > app/test-pmd/csumonly.c | 12 +- > > app/test-pmd/rxonly.c | 15 +- > > lib/librte_mbuf/rte_mbuf.h | 225 ++++++++++++++- > > lib/librte_pmd_i40e/i40e_rxtx.c | 604 +++++++++++++++++++++------------------ > > 4 files changed, 569 insertions(+), 287 deletions(-) > > > > The patch looks good to me in general. > Though I think it is not complete: we need to make sure that all PMDs RX functions will set mbuf's packet_type > to the defined value. > As right now, only i40e implementation can distinguish packet_type properly, I think all other PMDs > for the freshly received packet should do: > mbuf->packet_type = RTE_PTYPE_UNDEF; > > Another thing: right now mbuf's packet_type is uint16_t. > While enum rte_eth_packet_type will be interpreted by the compiler as 'int' (32bits). > We can either change enum to a lot of defines (which I don't really like to do) or probably just > add a comment somewhere that enum rte_eth_packet_type should never exceed UINT16_MAX value? > Add a RTE_PTYPE_MAX value = UINT16_MAX to the enum, perhaps? /Bruce