From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 395597F60
 for <dev@dpdk.org>; Thu, 20 Nov 2014 12:07:01 +0100 (CET)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1XrPjs-0000XT-65; Thu, 20 Nov 2014 06:17:29 -0500
Date: Thu, 20 Nov 2014 06:17:27 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Tapio Tallgren <tapio.tallgren@gmail.com>
Message-ID: <20141120111727.GA2609@hmsreliant.think-freely.org>
References: <CAJi57Qn8MbCNMS9K3TaBEKMUT6CXfDtkqXiy2sNajejNXBj4WQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJi57Qn8MbCNMS9K3TaBEKMUT6CXfDtkqXiy2sNajejNXBj4WQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Newbie question: compiling virtio-net-pmd v1.2 fails
 with dpdk 1.7 on a VM
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Nov 2014 11:07:01 -0000

On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote:
> Hi,
> 
> I am probably doing something obviously wrong but I cannot figure it out
> right now..
> I have dpdk version 1.7.1 installed and compiled (from the git repository)
> and virtio-net-pmd driver version v1.2 from git.dpdk.org. When I try to
> compile virtio-net-pmd with
> 
> make RTE_INCLUDE=../dpdk/build/include
> 
> I get errors like this:
> 
> virtio_user.c: In function rte_rmxbuf_alloc:
> virtio_user.c:208:44: error: macro "__rte_mbuf_sanity_check" passed 3
> arguments, but takes just 2
> 
> Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so what
> am I doing wrong?
> 
> -- 
> -Tapio
> 

Nothing, its a bug.  DPDK changed the API here with commit
9aaccf1abdb2894ec23870e1d2199a657f85850e but it never got changed in the
virtio_user pmd.  You need to modify the pmd like the other call sites have been
in the above commit.

This is why those external pmds need to be merged into the dpdk tree.

Neil