Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Nov 20, 2014 at 12:03:40PM -0500, Neil Horman wrote:
> On Thu, Nov 20, 2014 at 04:42:23PM +0000, Gonzalez Monroy, Sergio wrote:
> > > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > > Sent: Thursday, November 20, 2014 2:21 PM
> > > On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> > > > Some features of the cmdline were broken in FreeBSD as a result of
> > > > termios not being compiled.
> > > >
> > > > Signed-off-by: Sergio Gonzalez Monroy
> > > > <sergio.gonzalez.monroy@intel.com>
> > > 
> > > Not sure I understand the changelog above.  You're removing ifdefs below
> > > which makes sense, but are you now assuming that BSD will be built with
> > > termios support, or do you need to add some alternate dependency check
> > > during the configuration of DPDK?
> > > Neil
> > > 
> > Yes, I was assuming that BSD has termios support.
> > Is it not a fair assumption?
> > 
> No, I think its a perfectly fair assumption.  I was just trying to understand
> the history of the ifdefs there.  Sounds like it was a dumb idea to intiially
> ifdef the termios stuff out way back when.
> 

The ifdef probably dates from when there were just two versions of DPDK: linux
and baremetal. Guess which one didn't have the termios support :-)

/Bruce

> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> 
> > Sergio
> >