* [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
@ 2014-11-20 14:17 Sergio Gonzalez Monroy
2014-11-20 14:20 ` Neil Horman
2014-11-21 9:18 ` Bruce Richardson
0 siblings, 2 replies; 8+ messages in thread
From: Sergio Gonzalez Monroy @ 2014-11-20 14:17 UTC (permalink / raw)
To: dev
Some features of the cmdline were broken in FreeBSD as a result of
termios not being compiled.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
lib/librte_cmdline/cmdline.h | 2 --
lib/librte_cmdline/cmdline_socket.c | 10 +---------
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/lib/librte_cmdline/cmdline.h b/lib/librte_cmdline/cmdline.h
index 4c28d37..06ae086 100644
--- a/lib/librte_cmdline/cmdline.h
+++ b/lib/librte_cmdline/cmdline.h
@@ -71,9 +71,7 @@ struct cmdline {
cmdline_parse_ctx_t *ctx;
struct rdline rdl;
char prompt[RDLINE_PROMPT_SIZE];
-#ifdef RTE_EXEC_ENV_LINUXAPP
struct termios oldterm;
-#endif
};
struct cmdline *cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out);
diff --git a/lib/librte_cmdline/cmdline_socket.c b/lib/librte_cmdline/cmdline_socket.c
index b51b537..6820b6d 100644
--- a/lib/librte_cmdline/cmdline_socket.c
+++ b/lib/librte_cmdline/cmdline_socket.c
@@ -93,7 +93,6 @@ struct cmdline *
cmdline_stdin_new(cmdline_parse_ctx_t *ctx, const char *prompt)
{
struct cmdline *cl;
-#ifdef RTE_EXEC_ENV_LINUXAPP
struct termios oldterm, term;
tcgetattr(0, &oldterm);
@@ -101,14 +100,12 @@ cmdline_stdin_new(cmdline_parse_ctx_t *ctx, const char *prompt)
term.c_lflag &= ~(ICANON | ECHO | ISIG);
tcsetattr(0, TCSANOW, &term);
setbuf(stdin, NULL);
-#endif
cl = cmdline_new(ctx, prompt, 0, 1);
-#ifdef RTE_EXEC_ENV_LINUXAPP
if (cl)
memcpy(&cl->oldterm, &oldterm, sizeof(term));
-#endif
+
return cl;
}
@@ -118,10 +115,5 @@ cmdline_stdin_exit(struct cmdline *cl)
if (!cl)
return;
-#ifdef RTE_EXEC_ENV_LINUXAPP
tcsetattr(fileno(stdin), TCSANOW, &cl->oldterm);
-#else
- /* silent the compiler */
- (void)cl;
-#endif
}
--
2.1.0
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
2014-11-20 14:17 [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD Sergio Gonzalez Monroy
@ 2014-11-20 14:20 ` Neil Horman
2014-11-20 16:42 ` Gonzalez Monroy, Sergio
2014-11-21 9:18 ` Bruce Richardson
1 sibling, 1 reply; 8+ messages in thread
From: Neil Horman @ 2014-11-20 14:20 UTC (permalink / raw)
To: Sergio Gonzalez Monroy; +Cc: dev
On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> Some features of the cmdline were broken in FreeBSD as a result of
> termios not being compiled.
>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Not sure I understand the changelog above. You're removing ifdefs below which
makes sense, but are you now assuming that BSD will be built with termios
support, or do you need to add some alternate dependency check during the
configuration of DPDK?
Neil
> ---
> lib/librte_cmdline/cmdline.h | 2 --
> lib/librte_cmdline/cmdline_socket.c | 10 +---------
> 2 files changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/lib/librte_cmdline/cmdline.h b/lib/librte_cmdline/cmdline.h
> index 4c28d37..06ae086 100644
> --- a/lib/librte_cmdline/cmdline.h
> +++ b/lib/librte_cmdline/cmdline.h
> @@ -71,9 +71,7 @@ struct cmdline {
> cmdline_parse_ctx_t *ctx;
> struct rdline rdl;
> char prompt[RDLINE_PROMPT_SIZE];
> -#ifdef RTE_EXEC_ENV_LINUXAPP
> struct termios oldterm;
> -#endif
> };
>
> struct cmdline *cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out);
> diff --git a/lib/librte_cmdline/cmdline_socket.c b/lib/librte_cmdline/cmdline_socket.c
> index b51b537..6820b6d 100644
> --- a/lib/librte_cmdline/cmdline_socket.c
> +++ b/lib/librte_cmdline/cmdline_socket.c
> @@ -93,7 +93,6 @@ struct cmdline *
> cmdline_stdin_new(cmdline_parse_ctx_t *ctx, const char *prompt)
> {
> struct cmdline *cl;
> -#ifdef RTE_EXEC_ENV_LINUXAPP
> struct termios oldterm, term;
>
> tcgetattr(0, &oldterm);
> @@ -101,14 +100,12 @@ cmdline_stdin_new(cmdline_parse_ctx_t *ctx, const char *prompt)
> term.c_lflag &= ~(ICANON | ECHO | ISIG);
> tcsetattr(0, TCSANOW, &term);
> setbuf(stdin, NULL);
> -#endif
>
> cl = cmdline_new(ctx, prompt, 0, 1);
>
> -#ifdef RTE_EXEC_ENV_LINUXAPP
> if (cl)
> memcpy(&cl->oldterm, &oldterm, sizeof(term));
> -#endif
> +
> return cl;
> }
>
> @@ -118,10 +115,5 @@ cmdline_stdin_exit(struct cmdline *cl)
> if (!cl)
> return;
>
> -#ifdef RTE_EXEC_ENV_LINUXAPP
> tcsetattr(fileno(stdin), TCSANOW, &cl->oldterm);
> -#else
> - /* silent the compiler */
> - (void)cl;
> -#endif
> }
> --
> 2.1.0
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
2014-11-20 14:20 ` Neil Horman
@ 2014-11-20 16:42 ` Gonzalez Monroy, Sergio
2014-11-20 17:03 ` Neil Horman
0 siblings, 1 reply; 8+ messages in thread
From: Gonzalez Monroy, Sergio @ 2014-11-20 16:42 UTC (permalink / raw)
To: Neil Horman; +Cc: dev
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Thursday, November 20, 2014 2:21 PM
> On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> > Some features of the cmdline were broken in FreeBSD as a result of
> > termios not being compiled.
> >
> > Signed-off-by: Sergio Gonzalez Monroy
> > <sergio.gonzalez.monroy@intel.com>
>
> Not sure I understand the changelog above. You're removing ifdefs below
> which makes sense, but are you now assuming that BSD will be built with
> termios support, or do you need to add some alternate dependency check
> during the configuration of DPDK?
> Neil
>
Yes, I was assuming that BSD has termios support.
Is it not a fair assumption?
Sergio
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
2014-11-20 16:42 ` Gonzalez Monroy, Sergio
@ 2014-11-20 17:03 ` Neil Horman
2014-11-20 17:19 ` Bruce Richardson
0 siblings, 1 reply; 8+ messages in thread
From: Neil Horman @ 2014-11-20 17:03 UTC (permalink / raw)
To: Gonzalez Monroy, Sergio; +Cc: dev
On Thu, Nov 20, 2014 at 04:42:23PM +0000, Gonzalez Monroy, Sergio wrote:
> > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > Sent: Thursday, November 20, 2014 2:21 PM
> > On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> > > Some features of the cmdline were broken in FreeBSD as a result of
> > > termios not being compiled.
> > >
> > > Signed-off-by: Sergio Gonzalez Monroy
> > > <sergio.gonzalez.monroy@intel.com>
> >
> > Not sure I understand the changelog above. You're removing ifdefs below
> > which makes sense, but are you now assuming that BSD will be built with
> > termios support, or do you need to add some alternate dependency check
> > during the configuration of DPDK?
> > Neil
> >
> Yes, I was assuming that BSD has termios support.
> Is it not a fair assumption?
>
No, I think its a perfectly fair assumption. I was just trying to understand
the history of the ifdefs there. Sounds like it was a dumb idea to intiially
ifdef the termios stuff out way back when.
Acked-by: Neil Horman <nhorman@tuxdriver.com>
> Sergio
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
2014-11-20 17:03 ` Neil Horman
@ 2014-11-20 17:19 ` Bruce Richardson
2014-11-20 18:31 ` Neil Horman
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Richardson @ 2014-11-20 17:19 UTC (permalink / raw)
To: Neil Horman; +Cc: dev
On Thu, Nov 20, 2014 at 12:03:40PM -0500, Neil Horman wrote:
> On Thu, Nov 20, 2014 at 04:42:23PM +0000, Gonzalez Monroy, Sergio wrote:
> > > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > > Sent: Thursday, November 20, 2014 2:21 PM
> > > On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> > > > Some features of the cmdline were broken in FreeBSD as a result of
> > > > termios not being compiled.
> > > >
> > > > Signed-off-by: Sergio Gonzalez Monroy
> > > > <sergio.gonzalez.monroy@intel.com>
> > >
> > > Not sure I understand the changelog above. You're removing ifdefs below
> > > which makes sense, but are you now assuming that BSD will be built with
> > > termios support, or do you need to add some alternate dependency check
> > > during the configuration of DPDK?
> > > Neil
> > >
> > Yes, I was assuming that BSD has termios support.
> > Is it not a fair assumption?
> >
> No, I think its a perfectly fair assumption. I was just trying to understand
> the history of the ifdefs there. Sounds like it was a dumb idea to intiially
> ifdef the termios stuff out way back when.
>
The ifdef probably dates from when there were just two versions of DPDK: linux
and baremetal. Guess which one didn't have the termios support :-)
/Bruce
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
> > Sergio
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
2014-11-20 17:19 ` Bruce Richardson
@ 2014-11-20 18:31 ` Neil Horman
0 siblings, 0 replies; 8+ messages in thread
From: Neil Horman @ 2014-11-20 18:31 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Thu, Nov 20, 2014 at 05:19:19PM +0000, Bruce Richardson wrote:
> On Thu, Nov 20, 2014 at 12:03:40PM -0500, Neil Horman wrote:
> > On Thu, Nov 20, 2014 at 04:42:23PM +0000, Gonzalez Monroy, Sergio wrote:
> > > > From: Neil Horman [mailto:nhorman@tuxdriver.com]
> > > > Sent: Thursday, November 20, 2014 2:21 PM
> > > > On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> > > > > Some features of the cmdline were broken in FreeBSD as a result of
> > > > > termios not being compiled.
> > > > >
> > > > > Signed-off-by: Sergio Gonzalez Monroy
> > > > > <sergio.gonzalez.monroy@intel.com>
> > > >
> > > > Not sure I understand the changelog above. You're removing ifdefs below
> > > > which makes sense, but are you now assuming that BSD will be built with
> > > > termios support, or do you need to add some alternate dependency check
> > > > during the configuration of DPDK?
> > > > Neil
> > > >
> > > Yes, I was assuming that BSD has termios support.
> > > Is it not a fair assumption?
> > >
> > No, I think its a perfectly fair assumption. I was just trying to understand
> > the history of the ifdefs there. Sounds like it was a dumb idea to intiially
> > ifdef the termios stuff out way back when.
> >
>
> The ifdef probably dates from when there were just two versions of DPDK: linux
> and baremetal. Guess which one didn't have the termios support :-)
>
> /Bruce
>
Ah, thanks for the history Bruce :)
Neil
> > Acked-by: Neil Horman <nhorman@tuxdriver.com>
> >
> > > Sergio
> > >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
2014-11-20 14:17 [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD Sergio Gonzalez Monroy
2014-11-20 14:20 ` Neil Horman
@ 2014-11-21 9:18 ` Bruce Richardson
2014-11-24 15:51 ` Thomas Monjalon
1 sibling, 1 reply; 8+ messages in thread
From: Bruce Richardson @ 2014-11-21 9:18 UTC (permalink / raw)
To: Sergio Gonzalez Monroy; +Cc: dev
On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> Some features of the cmdline were broken in FreeBSD as a result of
> termios not being compiled.
>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_cmdline/cmdline.h | 2 --
> lib/librte_cmdline/cmdline_socket.c | 10 +---------
> 2 files changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/lib/librte_cmdline/cmdline.h b/lib/librte_cmdline/cmdline.h
> index 4c28d37..06ae086 100644
> --- a/lib/librte_cmdline/cmdline.h
> +++ b/lib/librte_cmdline/cmdline.h
> @@ -71,9 +71,7 @@ struct cmdline {
> cmdline_parse_ctx_t *ctx;
> struct rdline rdl;
> char prompt[RDLINE_PROMPT_SIZE];
> -#ifdef RTE_EXEC_ENV_LINUXAPP
> struct termios oldterm;
> -#endif
> };
>
> struct cmdline *cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out);
> diff --git a/lib/librte_cmdline/cmdline_socket.c b/lib/librte_cmdline/cmdline_socket.c
> index b51b537..6820b6d 100644
> --- a/lib/librte_cmdline/cmdline_socket.c
> +++ b/lib/librte_cmdline/cmdline_socket.c
> @@ -93,7 +93,6 @@ struct cmdline *
> cmdline_stdin_new(cmdline_parse_ctx_t *ctx, const char *prompt)
> {
> struct cmdline *cl;
> -#ifdef RTE_EXEC_ENV_LINUXAPP
> struct termios oldterm, term;
>
> tcgetattr(0, &oldterm);
> @@ -101,14 +100,12 @@ cmdline_stdin_new(cmdline_parse_ctx_t *ctx, const char *prompt)
> term.c_lflag &= ~(ICANON | ECHO | ISIG);
> tcsetattr(0, TCSANOW, &term);
> setbuf(stdin, NULL);
> -#endif
>
> cl = cmdline_new(ctx, prompt, 0, 1);
>
> -#ifdef RTE_EXEC_ENV_LINUXAPP
> if (cl)
> memcpy(&cl->oldterm, &oldterm, sizeof(term));
> -#endif
> +
> return cl;
> }
>
> @@ -118,10 +115,5 @@ cmdline_stdin_exit(struct cmdline *cl)
> if (!cl)
> return;
>
> -#ifdef RTE_EXEC_ENV_LINUXAPP
> tcsetattr(fileno(stdin), TCSANOW, &cl->oldterm);
> -#else
> - /* silent the compiler */
> - (void)cl;
> -#endif
> }
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
2014-11-21 9:18 ` Bruce Richardson
@ 2014-11-24 15:51 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2014-11-24 15:51 UTC (permalink / raw)
To: Sergio Gonzalez Monroy; +Cc: dev
> > Some features of the cmdline were broken in FreeBSD as a result of
> > termios not being compiled.
> >
> > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-11-24 15:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-20 14:17 [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD Sergio Gonzalez Monroy
2014-11-20 14:20 ` Neil Horman
2014-11-20 16:42 ` Gonzalez Monroy, Sergio
2014-11-20 17:03 ` Neil Horman
2014-11-20 17:19 ` Bruce Richardson
2014-11-20 18:31 ` Neil Horman
2014-11-21 9:18 ` Bruce Richardson
2014-11-24 15:51 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).