From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4DD8758E4 for <dev@dpdk.org>; Tue, 25 Nov 2014 09:33:53 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 25 Nov 2014 00:41:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,454,1413270000"; d="scan'208";a="613607227" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.15]) by orsmga001.jf.intel.com with SMTP; 25 Nov 2014 00:44:40 -0800 Received: by (sSMTP sendmail emulation); Tue, 25 Nov 2014 08:44:40 +0025 Date: Tue, 25 Nov 2014 08:44:40 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Chao Zhu <chaozhu@linux.vnet.ibm.com> Message-ID: <20141125084439.GA6696@bricha3-MOBL3> References: <1416792142-23132-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1416792142-23132-2-git-send-email-chaozhu@linux.vnet.ibm.com> <20141123220246.GA27315@hmsreliant.think-freely.org> <5473FCB1.9080507@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5473FCB1.9080507@linux.vnet.ibm.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 01/14] Add compiling definations for IBM Power architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 25 Nov 2014 08:33:53 -0000 On Tue, Nov 25, 2014 at 11:51:13AM +0800, Chao Zhu wrote: > Neil, > Current Power related patches are not a full functional one. Some of the > libraries are not migrated. So > common_linuxapp_powerpc is used to turn off the uncompiled part. Hi Chao, just to re-echo what Neil says - this would be better as a defconfig_powerpc-native-linuxapp-gcc config file including common_linuxapp. Anything you need to turn off in the config can be turned off in the defconfig file after you include the common_linuxapp one - later definitions override earlier ones. It also makes things clearer to read as you end up with a powerpc config file that essentially reads as "use common linux settings except for this, and this, and this, etc...." Regards, /Bruce > This file > is a copy of the common_linuxapp. And this file is intended to be removed > when all of the libraries are migrated to Power. Actually, it's the current > common file for linux and other OS, such as BSD. However, I didn't try the > compilation on BSD. But this probably needs to be done. > > On 2014/11/24 6:02, Neil Horman wrote: > >On Sun, Nov 23, 2014 at 08:22:09PM -0500, Chao Zhu wrote: > >>To make DPDK run on IBM Power architecture, configuration files for > >>Power architecuture are added. Also, the compiling related .mk files are > >>added. > >> > >>Signed-off-by: Chao Zhu <chaozhu@linux.vnet.ibm.com> > >>--- > >> config/common_linuxapp_powerpc | 394 +++++++++++++++++++++++++++ > >> config/defconfig_ppc_64-power8-linuxapp-gcc | 40 +++ > >> mk/arch/ppc_64/rte.vars.mk | 39 +++ > >> mk/machine/power8/rte.vars.mk | 57 ++++ > >> 4 files changed, 530 insertions(+), 0 deletions(-) > >> create mode 100644 config/common_linuxapp_powerpc > >> create mode 100644 config/defconfig_ppc_64-power8-linuxapp-gcc > >> create mode 100644 mk/arch/ppc_64/rte.vars.mk > >> create mode 100644 mk/machine/power8/rte.vars.mk > >> > >>diff --git a/config/common_linuxapp_powerpc b/config/common_linuxapp_powerpc > >>new file mode 100644 > >>index 0000000..d230a0b > >>--- /dev/null > >>+++ b/config/common_linuxapp_powerpc > >This filename is common_linuxapp_powerpc, but given that it explicitly specifies > >all the build options, there isn't really anything common about it. I think > >what you want to do is rename this defconfig_powerpc-native-linuxapp-gcc, and > >have it include common_linuxapp, then change any power-specific option you see > >fit. > > > >Also, does BSD build on power? I presume so. You likely want to create a > >corresponding bsd power config > > > >