From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id AD8AB58E4
 for <dev@dpdk.org>; Tue, 25 Nov 2014 09:36:49 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 25 Nov 2014 00:44:40 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,454,1413270000"; d="scan'208";a="613608303"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.15])
 by orsmga001.jf.intel.com with SMTP; 25 Nov 2014 00:47:38 -0800
Received: by  (sSMTP sendmail emulation); Tue, 25 Nov 2014 08:47:37 +0025
Date: Tue, 25 Nov 2014 08:47:37 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20141125084737.GB6696@bricha3-MOBL3>
References: <1416866980-23002-1-git-send-email-thomas.monjalon@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1416866980-23002-1-git-send-email-thomas.monjalon@6wind.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix doxygen comments about RSS
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2014 08:36:50 -0000

On Mon, Nov 24, 2014 at 11:09:40PM +0100, Thomas Monjalon wrote:
> The parameters port_id didn't match with comments about port.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_ether/rte_ethdev.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index fec4d4c..78a9d37 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -3370,7 +3370,7 @@ int rte_eth_dev_bypass_wd_reset(uint8_t port);
>   /**
>   * Configuration of Receive Side Scaling hash computation of Ethernet device.
>   *
> - * @param port
> + * @param port_id
>   *   The port identifier of the Ethernet device.
>   * @param rss_conf
>   *   The new configuration to use for RSS hash computation on the port.
> @@ -3387,7 +3387,7 @@ int rte_eth_dev_rss_hash_update(uint8_t port_id,
>   * Retrieve current configuration of Receive Side Scaling hash computation
>   * of Ethernet device.
>   *
> - * @param port
> + * @param port_id
>   *   The port identifier of the Ethernet device.
>   * @param rss_conf
>   *   Where to store the current RSS hash configuration of the Ethernet device.
> -- 
> 2.1.3
>