From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id CD1C28040
for <dev@dpdk.org>; Thu, 4 Dec 2014 15:42:19 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga101.fm.intel.com with ESMTP; 04 Dec 2014 06:40:06 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="425052115"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.23])
by FMSMGA003.fm.intel.com with SMTP; 04 Dec 2014 06:29:45 -0800
Received: by (sSMTP sendmail emulation); Thu, 04 Dec 2014 14:40:04 +0025
Date: Thu, 4 Dec 2014 14:40:04 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>
Message-ID: <20141204144003.GB9300@bricha3-MOBL3>
References: <1417703181-23093-1-git-send-email-jean-mickael.guerin@6wind.com>
<1417703181-23093-3-git-send-email-jean-mickael.guerin@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1417703181-23093-3-git-send-email-jean-mickael.guerin@6wind.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] ixgbe: don't override mbuf buffer length
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Dec 2014 14:42:20 -0000
On Thu, Dec 04, 2014 at 03:26:21PM +0100, Jean-Mickael Guerin wrote:
> The template mbuf_initializer is hard coded with a buflen which
> might have been set differently by the application at the time of
> mbuf pool creation.
>
> Switch to a mbuf allocation, to fetch the correct default values.
> There is no performance impact because this is not a data-plane API.
>
> Signed-off-by: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>
> Acked-by: David Marchand <david.marchand@6wind.com>
> Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes")
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> index c1b5a78..f7b02f5 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> @@ -732,17 +732,22 @@ static struct ixgbe_txq_ops vec_txq_ops = {
> int
> ixgbe_rxq_vec_setup(struct igb_rx_queue *rxq)
> {
> - struct rte_mbuf mb_def = { .buf_addr = 0 }; /* zeroed mbuf */
> + struct rte_mbuf *mb_def;
>
> - mb_def.nb_segs = 1;
> - mb_def.data_off = RTE_PKTMBUF_HEADROOM;
> - mb_def.buf_len = rxq->mb_pool->elt_size - sizeof(struct rte_mbuf);
> - mb_def.port = rxq->port_id;
> - rte_mbuf_refcnt_set(&mb_def, 1);
> + mb_def = rte_pktmbuf_alloc(rxq->mb_pool);
> + if (mb_def == NULL) {
> + PMD_INIT_LOG(ERR, "ixgbe_rxq_vec_setup: could not allocate one mbuf");
> + return -1;
> + }
> + /* nb_segs, refcnt, data_off and buf_len are already set */
> + mb_def->port = rxq->port_id;
>
> /* prevent compiler reordering: rearm_data covers previous fields */
> rte_compiler_barrier();
> - rxq->mbuf_initializer = *((uint64_t *)&mb_def.rearm_data);
> + rxq->mbuf_initializer = *((uint64_t *)&mb_def->rearm_data);
> +
> + rte_pktmbuf_free(mb_def);
> +
> return 0;
> }
>
> --
> 2.1.3
>